From: Shuah Khan <shuahkh@osg.samsung.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: lei.yang@windriver.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests: remove obsolete kconfig fragment for cpu-hotplug
Date: Wed, 1 Nov 2017 16:59:24 -0600 [thread overview]
Message-ID: <33c654fe-7d48-15e4-ee3b-1dba7dd41dd4@osg.samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1711012351480.1942@nanos>
On 11/01/2017 04:52 PM, Thomas Gleixner wrote:
> On Wed, 1 Nov 2017, Shuah Khan wrote:
>> On 10/17/2017 08:10 PM, lei.yang@windriver.com wrote:
>>> From: Lei Yang <Lei.Yang@windriver.com>
>>>
>>> Kconfig CONFIG_CPU_NOTIFIER_ERROR_INJECT has been removed since kernel 4.10
>>> check commit:
>>> commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
>>> Author: Thomas Gleixner <tglx@linutronix.de>
>>> Date: Wed Dec 21 20:19:53 2016 +0100
>>>
>>> cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions
>>>
>>> hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(),
>>> register_hotcpu_notifier(), register_cpu_notifier(),
>>> __register_hotcpu_notifier(), __register_cpu_notifier(),
>>> unregister_hotcpu_notifier(), unregister_cpu_notifier(),
>>> __unregister_hotcpu_notifier(), __unregister_cpu_notifier()
>>> <snip>
>>>
>>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>>> ---
>>> tools/testing/selftests/cpu-hotplug/config | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/cpu-hotplug/config b/tools/testing/selftests/cpu-hotplug/config
>>> index e6ab090..d4aca2a 100644
>>> --- a/tools/testing/selftests/cpu-hotplug/config
>>> +++ b/tools/testing/selftests/cpu-hotplug/config
>>> @@ -1,2 +1 @@
>>> CONFIG_NOTIFIER_ERROR_INJECTION=y
>>> -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
>>>
>>
>> Yes. It is removed from the kernel. However, selftests from the latest
>> release do get run routinely on older stable releases. Dropping the
>> config will impact coverage on older releases.
>>
>> Thomas/Greg,
>>
>> Any ideas on what we should do about this. On one hand it is a good idea
>> to remove it, however my concern is coverage on older releases.
>
> Can you check the kernel version on which you are running and do it runtime
> conditionally?
>
I have been avoiding adding kernel version checks to tests. Maybe this is
one exception since the functionality is obsoleted.
In any case, just removing the config isn't the complete solution. I will
have to think about this some.
thanks,
-- Shuah
next prev parent reply other threads:[~2017-11-01 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 2:10 lei.yang
2017-11-01 22:14 ` Shuah Khan
2017-11-01 22:52 ` Thomas Gleixner
2017-11-01 22:59 ` Shuah Khan [this message]
2017-11-02 2:13 ` lyang0
2017-11-03 3:55 ` Sumit Semwal
2017-11-03 7:34 ` lyang0
2017-11-02 8:46 ` Greg Kroah-Hartman
2017-11-02 22:14 ` Shuah Khan
2017-11-02 22:25 ` Yang, Lei
2017-11-03 14:03 ` lei yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c654fe-7d48-15e4-ee3b-1dba7dd41dd4@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=lei.yang@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®