From: Markus Elfring <Markus.Elfring@web.de>
To: "Junrui Luo" <moonafterrain@outlook.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Prike Liang" <Prike.Liang@amd.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Yuhao Jiang <danisjiang@gmail.com>
Subject: Re: [PATCH] drm/amdgpu/userq: fix memory leak in MQD creation error paths
Date: Mon, 16 Mar 2026 12:00:29 +0100 [thread overview]
Message-ID: <33c8a45a-3548-4ee7-8e32-4b401f4feeb4@web.de> (raw)
In-Reply-To: <F21AC290-0B53-40AF-A0A0-0647B86AD2C3@outlook.com>
…
> static int mes_userq_mqd_init_compute(struct amdgpu_device *adev,
> struct amdgpu_usermode_queue *queue,
> struct drm_amdgpu_userq_in *mqd_user,
> struct amdgpu_mqd_prop *userq_props)
> {
> struct drm_amdgpu_userq_mqd_compute_gfx11 *mqd __free(kfree) = NULL;
…
How do you think about to use a direct assignment without the variable initialisation “NULL”?
Regards,
Markus
next prev parent reply other threads:[~2026-03-16 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 15:33 Junrui Luo
2026-03-14 20:04 ` Markus Elfring
2026-03-15 5:25 ` Junrui Luo
2026-03-15 9:50 ` Markus Elfring
2026-03-16 3:32 ` [PATCH] " Liang, Prike
2026-03-16 10:10 ` Junrui Luo
2026-03-16 11:00 ` Markus Elfring [this message]
2026-03-16 12:21 ` Liang, Prike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c8a45a-3548-4ee7-8e32-4b401f4feeb4@web.de \
--to=markus.elfring@web.de \
--cc=Prike.Liang@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=danisjiang@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moonafterrain@outlook.com \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®