mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] dt-bindings: soc: socionext: Add UniPhier AHCI glue layer
Date: Thu, 1 Dec 2022 18:30:02 +0900	[thread overview]
Message-ID: <33ca35f4-acee-6b2b-1a73-41ed5882819e@socionext.com> (raw)
In-Reply-To: <20221129103509.9958-9-hayashi.kunihiko@socionext.com>

Hi Krzysztof,

On 2022/11/29 19:35, Kunihiko Hayashi wrote:
> Add DT binding schema for components belonging to the platform-specific
> AHCI glue layer implemented in UniPhier SoCs.
> 
> This AHCI glue layer works as a sideband logic for the host controller,
> including core reset, PHYs, and some signals to the controller.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

(snip)

> +examples:
> +  - |
> +    sata-controller@65700000 {
> +        compatible = "socionext,uniphier-pxs3-ahci-glue", "simple-mfd";
> +        reg = <0x65b00000 0x400>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges = <0 0x65700000 0x100>;

In PATCH 7/8, you suggested that the node name of "USB glue layer" should
changes to the generic node name "usb@...".

However, in case of this "AHCI glue layer", I can't change "sata-controller"
to the generic node name "sata@...", because ata/sata-common.yaml has pattern
"^sata(@.*)?$", and the changed node matches this pattern unintentionally.

This layer isn't a sata host controller, so it's hard to give a generic name
to this node. I'd like you opinion.

Thank you,

---
Best Regards
Kunihiko Hayashi

  parent reply	other threads:[~2022-12-01  9:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 10:35 [PATCH 0/8] dt-bidnings: soc: Introduce UniPhier miscelaneous register blocks Kunihiko Hayashi
2022-11-29 10:35 ` [PATCH 1/8] dt-bindings: soc: socionext: Add UniPhier system controller Kunihiko Hayashi
2022-11-29 13:32   ` Rob Herring
2022-11-29 14:41   ` Krzysztof Kozlowski
2022-11-30  8:59     ` Kunihiko Hayashi
2022-11-30 15:24       ` Krzysztof Kozlowski
2022-12-01  8:29         ` Kunihiko Hayashi
2022-11-29 10:35 ` [PATCH 2/8] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Kunihiko Hayashi
2022-11-29 14:43   ` Krzysztof Kozlowski
2022-11-30  8:59     ` Kunihiko Hayashi
2022-11-30 15:27       ` Krzysztof Kozlowski
2022-12-01  8:29         ` Kunihiko Hayashi
2022-11-29 10:35 ` [PATCH 3/8] dt-bindings: soc: socionext: Add UniPhier peripheral block Kunihiko Hayashi
2022-11-29 13:32   ` Rob Herring
2022-11-29 14:46   ` Krzysztof Kozlowski
2022-11-30  9:00     ` Kunihiko Hayashi
2022-11-29 10:35 ` [PATCH 4/8] dt-bindings: soc: socionext: Add UniPhier media I/O block Kunihiko Hayashi
2022-11-29 13:32   ` Rob Herring
2022-11-29 10:35 ` [PATCH 5/8] dt-bindings: soc: socionext: Add UniPhier SD interface block Kunihiko Hayashi
2022-11-29 10:35 ` [PATCH 6/8] dt-bindings: soc: socionext: Add UniPhier ADAMV block Kunihiko Hayashi
2022-11-29 13:32   ` Rob Herring
2022-11-29 10:35 ` [PATCH 7/8] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer Kunihiko Hayashi
2022-11-29 13:32   ` Rob Herring
2022-11-29 14:52   ` Krzysztof Kozlowski
2022-11-30  9:00     ` Kunihiko Hayashi
2022-11-30 15:32       ` Krzysztof Kozlowski
2022-12-01  8:30         ` Kunihiko Hayashi
2022-11-29 10:35 ` [PATCH 8/8] dt-bindings: soc: socionext: Add UniPhier AHCI " Kunihiko Hayashi
2022-11-29 13:32   ` Rob Herring
2022-12-01  9:30   ` Kunihiko Hayashi [this message]
2022-12-02 12:08     ` Krzysztof Kozlowski
2022-12-02 12:14       ` Kunihiko Hayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33ca35f4-acee-6b2b-1a73-41ed5882819e@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®