mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>,
	<dmitry.torokhov@gmail.com>, <robh@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<jikos@kernel.org>, <benjamin.tissoires@redhat.co>,
	<dianders@google.com>, <hsinyi@google.com>, <jagan@edgeble.ai>,
	<neil.armstrong@linaro.org>, <dmitry.baryshkov@linaro.org>
Cc: <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 5/5] drm/panel: jd9365da: Add the function of adjusting orientation
Date: Mon, 24 Jun 2024 17:43:44 -0700	[thread overview]
Message-ID: <33cb6804-7a9a-45bb-803f-0506c4aa0160@quicinc.com> (raw)
In-Reply-To: <20240624141926.5250-6-lvzhaoxiong@huaqin.corp-partner.google.com>



On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote:
> This driver does not have the function to adjust the orientation,
> so this function is added.
> 
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

> ---
> Changes between V5 and V4:
> - 1. Change dev_err() to dev_err_probe().
> 
> V4:https://lore.kernel.org/all/20240620080509.18504-5-lvzhaoxiong@huaqin.corp-partner.google.com/
> 
> Changes between V4 and V3:
> - No changes.
> 
> ---
>   drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 593e12b31ebd..c6b669866fed 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -42,7 +42,7 @@ struct jadard {
>   	struct drm_panel panel;
>   	struct mipi_dsi_device *dsi;
>   	const struct jadard_panel_desc *desc;
> -
> +	enum drm_panel_orientation orientation;
>   	struct regulator *vdd;
>   	struct regulator *vccio;
>   	struct gpio_desc *reset;
> @@ -178,12 +178,20 @@ static int jadard_get_modes(struct drm_panel *panel,
>   	return 1;
>   }
>   
> +static enum drm_panel_orientation jadard_panel_get_orientation(struct drm_panel *panel)
> +{
> +	struct jadard *jadard = panel_to_jadard(panel);
> +
> +	return jadard->orientation;
> +}
> +
>   static const struct drm_panel_funcs jadard_funcs = {
>   	.disable = jadard_disable,
>   	.unprepare = jadard_unprepare,
>   	.prepare = jadard_prepare,
>   	.enable = jadard_enable,
>   	.get_modes = jadard_get_modes,
> +	.get_orientation = jadard_panel_get_orientation,
>   };
>   
>   static int radxa_display_8hd_ad002_init_cmds(struct jadard *jadard)
> @@ -880,6 +888,10 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>   	drm_panel_init(&jadard->panel, dev, &jadard_funcs,
>   		       DRM_MODE_CONNECTOR_DSI);
>   
> +	ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
> +	if (ret < 0)
> +		return dev_err_probe(dev, ret, "failed to get orientation\n");
> +
>   	ret = drm_panel_of_backlight(&jadard->panel);
>   	if (ret)
>   		return ret;
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2024-06-25  0:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 14:19 [PATCH v5 0/5] Add kd101ne3-40ti configuration in driver jd9365da Zhaoxiong Lv
2024-06-24 14:19 ` [PATCH v5 1/5] drm/panel: jd9365da: Modify the method of sending commands Zhaoxiong Lv
2024-06-24 16:22   ` Doug Anderson
2024-06-24 23:41   ` Jessica Zhang
2024-06-25 12:13     ` zhaoxiong lv
2024-06-25 17:49       ` Jessica Zhang
2024-06-26 10:55         ` zhaoxiong lv
2024-06-28  8:32   ` neil.armstrong
2024-06-24 14:19 ` [PATCH v5 2/5] dt-bindings: display: panel: Add compatible for kingdisplay-kd101ne3 Zhaoxiong Lv
2024-06-24 14:19 ` [PATCH v5 3/5] drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS functions Zhaoxiong Lv
2024-06-24 15:27   ` Dmitry Baryshkov
2024-06-24 16:31     ` Doug Anderson
2024-06-24 16:33       ` Dmitry Baryshkov
2024-06-24 16:39   ` Doug Anderson
2024-06-24 23:59   ` Jessica Zhang
2024-06-24 14:19 ` [PATCH v5 4/5] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel Zhaoxiong Lv
2024-06-24 16:45   ` Doug Anderson
2024-06-25  0:55   ` Jessica Zhang
2024-06-24 14:19 ` [PATCH v5 5/5] drm/panel: jd9365da: Add the function of adjusting orientation Zhaoxiong Lv
2024-06-24 16:46   ` Doug Anderson
2024-06-25  0:43   ` Jessica Zhang [this message]
2024-06-28  9:07 ` [PATCH v5 0/5] Add kd101ne3-40ti configuration in driver jd9365da Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33cb6804-7a9a-45bb-803f-0506c4aa0160@quicinc.com \
    --to=quic_jesszhan@quicinc.com \
    --cc=benjamin.tissoires@redhat.co \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hsinyi@google.com \
    --cc=jagan@edgeble.ai \
    --cc=jikos@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvzhaoxiong@huaqin.corp-partner.google.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®