From: Hans de Goede <hdegoede@redhat.com>
To: Borislav Petkov <bp@suse.de>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Limonciello, Mario" <mario.limonciello@amd.com>,
"Jan Dąbroś" <jsd@semihalf.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
jarkko.nikula@linux.intel.com, wsa@kernel.org,
rrangel@chromium.org, upstream@semihalf.com,
"Muralidhara M K" <muralimk@amd.com>,
"Naveen Krishna Chatradhi" <nchatrad@amd.com>
Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access
Date: Thu, 22 Sep 2022 16:29:53 +0200 [thread overview]
Message-ID: <33d5cc27-474b-fdec-a6b0-84ac16f7d386@redhat.com> (raw)
In-Reply-To: <YyxrdpUyc+kp48kX@zn.tnic>
Hi,
On 9/22/22 16:04, Borislav Petkov wrote:
> On Thu, Sep 22, 2022 at 03:48:07PM +0200, Hans de Goede wrote:
>> Right, thank you for Cc-ing me. At least on X86 there are several platforms
>> (and 100-s of device models) which use a PMIC connected to the i2c-designware
>> controller and this PMIC gets poked directly from ACPI _S0 and _S3
>> (power on/off) methods. So the I2C bus driver needs to *bind* to the controller
>> as soon as we find its description in ACPI, otherwise we get a whole bunch
>> of failed ACPI OpRegion access errors as well as various actual really issues.
>
> Thanks for explaining - I couldn't find the reason why it has to be a
> subsys_initcall.
>
>> So please keep this as a subsys initcall.
>
> Which means, init_amd_nbs() would have to be sorted to run before
> dw_i2c_init_driver()...
Yes if possible. One solution might be to make it a arch_initcall_sync()
which AFAIK runs after regular arch_initcall()-s but before subsys_initcall()-s.
Regards,
Hans
next prev parent reply other threads:[~2022-09-22 14:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:18 [PATCH -next 0/2] Add i2c arbitration support for new SoCs Jan Dabros
2022-09-16 13:18 ` [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Jan Dabros
2022-09-16 17:38 ` Limonciello, Mario
2022-09-20 16:24 ` Jan Dąbroś
2022-09-21 20:12 ` Borislav Petkov
2022-09-21 20:19 ` Limonciello, Mario
2022-09-21 20:50 ` Borislav Petkov
2022-09-22 9:49 ` Andy Shevchenko
2022-09-22 9:51 ` Andy Shevchenko
2022-09-22 13:48 ` Hans de Goede
2022-09-22 14:04 ` Borislav Petkov
2022-09-22 14:29 ` Hans de Goede [this message]
2022-09-26 12:49 ` Jan Dąbroś
2022-09-26 14:44 ` Borislav Petkov
2022-10-28 8:32 ` Jan Dąbroś
2023-01-09 11:12 ` Borislav Petkov
2023-01-09 17:10 ` Limonciello, Mario
2023-01-16 10:19 ` Jan Dąbroś
2023-01-16 12:38 ` Andy Shevchenko
2023-01-16 16:22 ` Limonciello, Mario
2023-01-16 17:48 ` Andy Shevchenko
2023-01-16 17:54 ` Andy Shevchenko
2023-01-16 21:59 ` Borislav Petkov
2022-09-19 13:59 ` Andy Shevchenko
2022-09-20 16:27 ` Jan Dąbroś
2022-09-16 13:18 ` [PATCH -next 2/2] i2c: designware: Add support for new SoCs in AMDPSP driver Jan Dabros
2022-09-19 13:59 ` Andy Shevchenko
2023-03-17 19:18 ` Mark Hasemeyer
2023-03-20 0:16 ` Mario Limonciello
2022-09-19 13:59 ` [PATCH -next 0/2] Add i2c arbitration support for new SoCs Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d5cc27-474b-fdec-a6b0-84ac16f7d386@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@suse.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=muralimk@amd.com \
--cc=nchatrad@amd.com \
--cc=rrangel@chromium.org \
--cc=upstream@semihalf.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®