From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753445AbdKXKxH convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 05:53:07 -0500
Received: from smtp-out4.electric.net ([192.162.216.184]:58737 "EHLO
        smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753118AbdKXKxF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 05:53:05 -0500
From: David Laight <David.Laight@ACULAB.COM>
To: "'Alan Cox'" <gnomes@lxorguk.ukuu.org.uk>,
        Salvatore Mesoraca <s.mesoraca16@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Kernel Hardening" <kernel-hardening@lists.openwall.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "Alexander Viro" <viro@zeniv.linux.org.uk>,
        Jann Horn <jannh@google.com>, Kees Cook <keescook@chromium.org>,
        Solar Designer <solar@openwall.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Subject: RE: [PATCH v3 2/2] Protected O_CREAT open in sticky directories
Thread-Topic: [PATCH v3 2/2] Protected O_CREAT open in sticky directories
Thread-Index: AQHTY7JHoPTLgqi4okeYgYQKKgWbF6MjW80w
Date: Fri, 24 Nov 2017 10:53:11 +0000
Message-ID: <33dcc007e92349999ce77bf45825be22@AcuMS.aculab.com>
References: <1511337706-8297-1-git-send-email-s.mesoraca16@gmail.com>
        <1511337706-8297-3-git-send-email-s.mesoraca16@gmail.com>
 <20171122165144.07aea7ac@alans-desktop>
In-Reply-To: <20171122165144.07aea7ac@alans-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.202.99.200]
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-Outbound-IP: 156.67.243.126
X-Env-From: David.Laight@ACULAB.COM
X-Proto: esmtps
X-Revdns: 
X-HELO: AcuMS.aculab.com
X-TLS: TLSv1.2:ECDHE-RSA-AES256-SHA384:256
X-Authenticated_ID: 
X-PolicySMART: 3396946, 3397078
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alan Cox
> Sent: 22 November 2017 16:52
> 
> On Wed, 22 Nov 2017 09:01:46 +0100
> Salvatore Mesoraca <s.mesoraca16@gmail.com> wrote:
> 
> > Disallows O_CREAT open missing the O_EXCL flag, in world or
> > group writable directories, even if the file doesn't exist yet.
> > With few exceptions (e.g. shared lock files based on flock())
> 
> Enough exceptions to make it a bad idea.
> 
> Firstly if you care this much *stop* having shared writable directories.
> We have namespaces, you don't need them. You can give every user their
> own /tmp etc.

Looks like a very bad idea to me as well.

Doesn't this stop all shell redirects into a shared /tmp ?
I'm pretty sure most programs use O_CREAT | O_TRUNC for output
files - they'll all stop working.

If there are some directories where you need to force O_EXCL you
need to make it a property of the directory, not the kernel.

	David