From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michael Walle <michael@walle.cc>
Cc: "Clément Perrochaud" <clement.perrochaud@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] NFC: nxp-nci: don't print header length mismatch on i2c error
Date: Wed, 29 Jun 2022 11:21:29 +0200 [thread overview]
Message-ID: <33def8ba-2ca3-c2a3-57ff-9b20dbc2337c@linaro.org> (raw)
In-Reply-To: <20220627170643.98239-2-michael@walle.cc>
On 27/06/2022 19:06, Michael Walle wrote:
> Don't print a misleading header length mismatch error if the i2c call
> returns an error. Instead just return the error code without any error
> message.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> changes since v1:
> - reworded commit message
> - removed fixes tag
> - removed nfc_err() call, as it is done elsewhere in this driver
> - nxp_nci_i2c_fw_read() has the same issue. also handle it there
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-29 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 17:06 [PATCH v2 1/2] NFC: nxp-nci: Don't issue a zero length i2c_master_read() Michael Walle
2022-06-27 17:06 ` [PATCH v2 2/2] NFC: nxp-nci: don't print header length mismatch on i2c error Michael Walle
2022-06-29 9:21 ` Krzysztof Kozlowski [this message]
2022-06-29 13:10 ` [PATCH v2 1/2] NFC: nxp-nci: Don't issue a zero length i2c_master_read() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33def8ba-2ca3-c2a3-57ff-9b20dbc2337c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=clement.perrochaud@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®