From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
broonie@kernel.org, robh+dt@kernel.org, vkoul@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, spapothi@codeaurora.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v5 4/4] ASoC: codecs: add wsa881x amplifier support
Date: Thu, 29 Aug 2019 11:36:52 -0500 [thread overview]
Message-ID: <33e04646-ac7e-3ba1-3e09-a4f27a1b250b@linux.intel.com> (raw)
In-Reply-To: <20190829144442.6210-5-srinivas.kandagatla@linaro.org>
> +static int wsa881x_ramp_pa_gain(struct snd_soc_component *comp,
> + int min_gain, int max_gain, int udelay)
> +{
> + int val;
> +
> + for (val = min_gain; max_gain <= val; val--) {
> + snd_soc_component_update_bits(comp, WSA881X_SPKR_DRV_GAIN,
> + 0xF0, val << 4);
> + /*
> + * 1ms delay is needed for every step change in gain as per
> + * HW requirement.
> + */
> + usleep_range(udelay, udelay + 10);
nit-pick: it'd be nicer to have udelay explicitly set here instead of in
the caller below for consistency with the comments.
> + wsa881x_ramp_pa_gain(comp, min_gain, max_gain, 1000);
But apart from that I didn't see anything blatantly wrong, so
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
prev parent reply other threads:[~2019-08-29 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:44 [PATCH v5 0/4] ASoC: codecs: Add WSA881x Smart Speaker " Srinivas Kandagatla
2019-08-29 14:44 ` [PATCH v5 1/4] dt-bindings: soundwire: add slave bindings Srinivas Kandagatla
2019-08-29 15:42 ` Rob Herring
2019-08-29 15:47 ` Srinivas Kandagatla
2019-08-29 14:44 ` [PATCH v5 2/4] soundwire: core: add device tree support for slave devices Srinivas Kandagatla
2019-08-29 14:44 ` [PATCH v5 3/4] dt-bindings: ASoC: Add WSA881x bindings Srinivas Kandagatla
2019-08-29 15:46 ` Rob Herring
2019-08-29 15:52 ` Srinivas Kandagatla
2019-08-29 19:30 ` Rob Herring
2019-08-29 14:44 ` [PATCH v5 4/4] ASoC: codecs: add wsa881x amplifier support Srinivas Kandagatla
2019-08-29 16:36 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e04646-ac7e-3ba1-3e09-a4f27a1b250b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®