From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.dwurp.de (mail.dwurp.de [185.183.156.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8167F29CE9 for ; Wed, 29 Oct 2025 07:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.183.156.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761721983; cv=none; b=FlI0NeRbmwQovf0InUW30rk0X9QZH9duCUFtqa3NPPttwH8GRg3pA5aD6ap5D13Jv6skFyQSmZI+Qk7xwWPFHPBC5geGF1Ueapi3jPzlZv/R7Bel1tuyGV0GlEItVtautTnqh4FVwRAXf5lKzpeH4/fDngRg55i6pe/Bdo9ApMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761721983; c=relaxed/simple; bh=6SxVBIPQIJOykSnkvoop1RiegR5h2DreMS3u37dkXso=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iAMXU9ZXxFJTWtjXDZS4BPhMz9wldf7mTI/wqCLjrUAtK0FPGqO6mvx2ivOtvCrjWcpGxJtN3s8UQe2mwQPbdUp3nX2AmkBVIpWFeaskrb9sBhpZaCWAN0FwVWIxy7oEVOmCQlTjUr0ze17Qhp0g/bGkzdSz9U7PVSdsSTM1xW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dwurp.de; spf=pass smtp.mailfrom=dwurp.de; dkim=pass (1024-bit key) header.d=dwurp.de header.i=@dwurp.de header.b=XtMPyJig; arc=none smtp.client-ip=185.183.156.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dwurp.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dwurp.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=dwurp.de header.i=@dwurp.de header.b="XtMPyJig" Message-ID: <33e255dc-64f9-4e4f-82eb-6f5e9c1d63d4@dwurp.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dwurp.de; s=mail; t=1761721977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=omGzvBI9DSCb25E1jWi57SCRRWBg2xgmKwZX4A7/h2M=; b=XtMPyJigtJouJI4+RxS78xlgzCynGWtvf3MXaJ9lhBDKu/sOOizXajn1P4Vl/aL/eVOU8L yD7XAjPWzoylcF0JITiP0n9NkZbFXRBv9OreNL4orIDEXKgFZ+ZJmsPMCJvnOEiTfvOdoW 4vUloSxkmy3MUis1vi7Qdj5DGa5mT1o= Date: Wed, 29 Oct 2025 08:12:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] drm/panel: kingdisplay-kd097d04: Disable EoTp To: chf.fritz@googlemail.com Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251028214045.1944956-1-dev@dwurp.de> Content-Language: en-US, de-DE From: Sebastian Fleer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Christoph, On 10/28/25 23:31, Christoph Fritz wrote: > Hi Sebastian > > On Tue, 2025-10-28 at 22:38 +0100, Sebastian Fleer wrote: >> Since commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by >> default") panel output on an Acer Chromebook Tab 10 (google-dru) is corrupted. >> The tablet I use is equipped with a kingdisplay-kd097d04 panel, disabling EoTp >> restores the correct functionality. >> >> Fixes: d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default") > > Just to clarify: This is not a fix for that commit, it is a fix for the > panel driver itself. > > EoTp is the default in Linux, a panel driver cannot enable it, only > disable it. > > Commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by > default") fixed a bug in the synopsys dw-mipi-dsi because EoTp was not > enabled there by default. > > Enabling EoTp in dw-mipi-dsi revealed an underlying issue in panel- > kingdisplay-kd097d04. > > That same issue appears if one would connect this panel to a different > mipi-dsi core (because there EoTp is also enabled by default). > thanks for your clarification. You're right, this change is merely a workaround for the kingdisplay panel. However, I'm in favor of keeping the "Fixes:" line since using bisect, commit d97e71e44937 ("drm/bridge: synopsys: dw-mipi-dsi: enable EoTp by default") is found as the first commit that shows distorted output for that panel. But I can make the nature of the change more clear in the commit message. Would that be OK for you? Best regards, Sebastian >> Signed-off-by: Sebastian Fleer >> --- >> drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c >> index 2fc7b0779b37..893af9b16756 100644 >> --- a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c >> +++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c >> @@ -359,7 +359,7 @@ static int kingdisplay_panel_probe(struct mipi_dsi_device *dsi) >> dsi->lanes = 4; >> dsi->format = MIPI_DSI_FMT_RGB888; >> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | >> - MIPI_DSI_MODE_LPM; >> + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; >> >> kingdisplay = devm_drm_panel_alloc(&dsi->dev, __typeof(*kingdisplay), base, >> &kingdisplay_panel_funcs,