From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B273164AA for ; Mon, 29 Dec 2025 13:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767014795; cv=none; b=s87sdhpckJNAjUdzIH4vVNeEqjjf9XDb5JPxy26slyMMXEZd/prs6GDxnjv5VPXRVgfUUOejtCOSvpQgExnA2hht4JE/3W6vmeFN4Lg+VMwMpPUoQp1DrSO6BE5vw29OeFfgRJwRyr/RiJU11Qpp/uEyYTDcodD34T6ZQPVZuYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767014795; c=relaxed/simple; bh=tu9pbE692wxXiosE+tAqK1si4bIsObC4y9I3BfIvOAw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=QksMGXNc4hjrAku3AUzYQWedXzOpTXl6E9y6tMqnI8fD/lKQ+Cjx1Qp4qCSl7vWQlo46f9ul7KHJc50/8de/U4hkpBpWwW33wd7aNTzb8WlgXv4t4413mqJY0cFxYbIMcK7ZgB6QeFOXciFNnpe0rHduaoDMMEMP0krfzWyiRCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iF9dp4Oc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jCkFvyy4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iF9dp4Oc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jCkFvyy4" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BT9a66P3252780 for ; Mon, 29 Dec 2025 13:26:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YjVb/8rbV2EMth5U/d7jNe4gBOXFEG56654Hv01mIgA=; b=iF9dp4OcJdQaKEOT n1Qluldgwa7Jq7GNsaLsP6ok+iuS7wv22Hb4r0OwkPd3EODrE8wyG3pCgR2vFNaT t2Mg1nLkeqFSJ+Y8Oq6eXEnlYsrY4+PFd6nxZkrLGh+xUGmLQXTiaRpf+84cacA7 NN3C/SMyXK5fDPaJt1jtAMbNUjV1EJSr8rCth1aIOf9dFJnOZ2HgyT25No1AOo8G wdVIbygzHiR+aeZg9wZrBNlfg8mDYHU4w9n2mhlJJwbXkM+QM/K6cFyA5L8VQqyi X25A5A8SEdKr7Y8eRvJe/kDWtMpoR9zeAXjAh3jTf4mdy5fmWJG+v7K1qN80uUbm E+Ajkw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba4tnvm7u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 13:26:32 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee16731ceaso180316901cf.2 for ; Mon, 29 Dec 2025 05:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767014792; x=1767619592; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=YjVb/8rbV2EMth5U/d7jNe4gBOXFEG56654Hv01mIgA=; b=jCkFvyy4d8nwmNw+hNoYPmFi7ZutbitOJWPy/5wfjRHouYNe+Wd2FeL6DdYbrZTnSm 3LjJ2lx4hJx1vDlxkN7p05rqY6kIaDCFXBnNr0gjME51nPXirYlv/QsexCAIkX2lQPAe YEagwOXo0K+ZEWM8staPgHp4NzeD+ryEiZkzyMvCI0igxEJRkwvYSaTvaPs8lY+UYav9 s1hGnjCDLZWdY1i+CzqfTZ3keHb8JNzCD1hAMH+j/5UKLTyg1PhUmvGLGC9RcMa+6w0D vLENZQ9vJ8ekWVhinA7mNLg0B7L6Nm2KPenpE4biEL4EEZJuif6C4iAtOJVZxalW0rHP IZzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767014792; x=1767619592; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YjVb/8rbV2EMth5U/d7jNe4gBOXFEG56654Hv01mIgA=; b=bZbwKYmn0hzxsvRJMVMQNdmoLS8UW+uveaCtJx9PE+5eOpAkZnnYci3844oqRzBWb0 p3N3hDyX4S/scvsyBFn5FTfs3O60Oloy3A4l3QQmMGm33mhpsl2Xjs/8Igk4yuqBpwdk gdAmCvZVQEHVQaCH0N23QrPBShYwkicQE0rocXbdZamtxiSv5W96us4p0Jx9O1J5iHMU spgvfoOUacuWLQP+6vwnwpZKu6ypRg33sUrM70uMdlMfp8NHpnoQzE97uZ0rZbQk1vjH lGAANAac5xj/2EPFd1hNdgEicBTNrAJNRlfMTc8OLzx0bHgdaeRfT9pU+978D8fugYB6 3qmg== X-Forwarded-Encrypted: i=1; AJvYcCV8m5uB05grRwBxeVOWlxn+w2Fp1xE8dRfhWAhreZgaFInXWyHqiujM1Vz0K4FR5yhEbS5Kt1SANHwzg1s=@vger.kernel.org X-Gm-Message-State: AOJu0YwVkkx3Uf0FFZQ+3T0gwdiwkJFC7l3wl/yp5M/iK1/rZPi9Bihn Ys1U0rnv/JU9Bb9ZLQ6c/KJhtxJGu9e9TqcfBuFDjJPG4C095p2udhT7k+vXeY3DauQBNpHb0GG +S8WpfrATGLXWvEUec12r+lvJ52k5mpkdpm0SBCIVyWQALGu/SEo9+Pa/1yO3ov1sKRY= X-Gm-Gg: AY/fxX4l4LjT755lDW4BsDR4bF1Xk9OMnDqSNJp74zRA+BVSeSnIF10s/HuwlcVXHq/ pSa6grlYOkR8ua6qxTgAPk6joyjsWo46P4bptiy/0S6RNiZ4hP5ngJ2Kw8lCm1qoshY81pUc9Cx S2dn3oO1/pysEnWw2UcbtZ/b9iS/43WRKiu9es3PmyxoXZtfRmLfTWTzsoTtMa7xqnDWwgzdToA 9hwAm2yLCOV7yIrEHiCvNJgie4y9ecC7+nyxCWTBL1eeiMiEVqeWtUSJcg6orWeWsNvCYf0qt66 56z414XxsJmnN31Yj1091QjiYa5cJs+q2ZFQKI5lUtQPkoyoF1HFVDjfrGDLdyF421wMVOb91B3 5qZlFGpBrfODe1UWZLclD1Nm7Oh4hnOY+NfpalFwLKqlVV25tNRPVMzcE4ZTVmZETe6ssQdZyqf hfeBrF1LsEPLd6HhmnnWHtHgsPwjoC3d01rDKQ9hq438nbHNICpUYIum467DsaX/5zDQQWijnZC 1R9 X-Received: by 2002:a05:622a:1307:b0:4e8:a413:bb3a with SMTP id d75a77b69052e-4f4abd799fdmr481009821cf.46.1767014792428; Mon, 29 Dec 2025 05:26:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGPYrW7LKNepzxbF9g864ygyvqGatn0G4vZhPzLn2fxtBE60dTlRKJNjMFTzdTDhMDfxbG4w== X-Received: by 2002:a05:622a:1307:b0:4e8:a413:bb3a with SMTP id d75a77b69052e-4f4abd799fdmr481009391cf.46.1767014791895; Mon, 29 Dec 2025 05:26:31 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f519c0sm3306895666b.71.2025.12.29.05.26.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 05:26:30 -0800 (PST) Message-ID: <33e3e806-935f-4867-9a94-fa914d17a3ab@oss.qualcomm.com> Date: Mon, 29 Dec 2025 14:26:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v2 1/3] media: i2c: ov5647: Convert to CCI register access helpers To: Xiaolei Wang , laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, dave.stevenson@raspberrypi.com, jacopo@jmondi.org, mchehab@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, hverkuil+cisco@kernel.org, hverkuil-cisco@xs4all.nl, jai.luthra@ideasonboard.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251229023018.2933405-1-xiaolei.wang@windriver.com> <20251229023018.2933405-2-xiaolei.wang@windriver.com> Content-Language: en-US, nl In-Reply-To: <20251229023018.2933405-2-xiaolei.wang@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=G+YR0tk5 c=1 sm=1 tr=0 ts=69528189 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=t7CeM3EgAAAA:8 a=Wueqb6rkilQwuqZitWQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-GUID: OtphPCPHbfmJFqjs7KJhJpq_kHAPLiip X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDEyNSBTYWx0ZWRfX/sSo+wB1jA2F b0affiEnOznQhsPDDkKcwTUdCBJuxqj9hsFtz/ziFgZSiU3ORGrBZ1N+0U3HJRlUOnElEIN5GCB FuWbru8kh0qYki9HQvnzrzITn8UX0b4YSSxKkNgpo/yL4Qd5pdWhd/ktBNpvCIcjM8QBJ8k+cWZ SAhjLQsgy1r2J3/1mNf4x3IyiS/QJYxwi6/20LdGV5C0ggU0kWmXl524k5ha3govWT/U5HRPeZQ RJZq3QIajtDn2f+//le6Y0V6PJoLTEmCMfd+oFecMH4MTiJk3+Nspvj7p1F8ITzkPG3gXzUHu8L ppDZc7kOuBrae7m1+gdIm1ddxocgmPMezL/7q3/oQipF2iTg66G/fLe5Rskrw8eqHgNEDu/3LgO GonbDtlEGjpZd8NEyx7rkSXzDHic7pesagYenQ1AYliKXmzsxVYToudBmACg9z+RzpOQjv9Op7n rxd6zowkWTSk2Ns10kA== X-Proofpoint-ORIG-GUID: OtphPCPHbfmJFqjs7KJhJpq_kHAPLiip X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_04,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290125 Hi, On 29-Dec-25 03:30, Xiaolei Wang wrote: > Use the new common CCI register access helpers to replace the private > register access helpers in the ov5647 driver. This simplifies the driver > by reducing the amount of code. Thank you for your patch, it is great to see more drivers being converted to the CCI register access helpers. > Signed-off-by: Xiaolei Wang > --- ... > diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c > index e193fef4fced..fd69f1616794 100644 > --- a/drivers/media/i2c/ov5647.c > +++ b/drivers/media/i2c/ov5647.c ... > @@ -130,377 +122,377 @@ static const u8 ov5647_test_pattern_val[] = { > 0x81, /* Random Data */ > }; > > -static const struct regval_list sensor_oe_disable_regs[] = { > - {0x3000, 0x00}, > - {0x3001, 0x00}, > - {0x3002, 0x00}, > +static const struct cci_reg_sequence sensor_oe_disable_regs[] = { > + { CCI_REG8(0x3000), 0x00 }, > + { CCI_REG8(0x3001), 0x00 }, > + { CCI_REG8(0x3002), 0x00 }, > }; > > -static const struct regval_list sensor_oe_enable_regs[] = { > - {0x3000, 0x0f}, > - {0x3001, 0xff}, > - {0x3002, 0xe4}, > +static const struct cci_reg_sequence sensor_oe_enable_regs[] = { > + { CCI_REG8(0x3000), 0x0f }, > + { CCI_REG8(0x3001), 0xff }, > + { CCI_REG8(0x3002), 0xe4 }, > }; For these 2, but also for the 2 much longer arrays with address, value pairs which you are replacing, you are replacing all the register addresses with CCI_REG8(0x3000). Even though some of these are like 16 bit or even 24bit registers, this in itself is not a problem. But if you are replacing them 1:1 like this anyway then IMHO it is better to just: - Directly use struct reg_sequence instead of struct cci_reg_sequence - Call regmap_multi_reg_write() instead of cci_multi_reg_write() then you can keep all the initializer values for the arrays the same (no need to add CCI_REG8() around the addresses). This is also how this was done in other drivers when they were converted to the CCI helpers. This greatly reduces the size of the diff and makes it much easier to review the patch. Regards, Hans