From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7907339F18F for ; Tue, 30 Jun 2026 08:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782806499; cv=none; b=OC5miTa8rx/BpLsUJ5l4MjS9ts4cRfsvn5VrkkzklGuUJ9pKW0fC4dRd5dgenIMUIkDg995MkQ68Hgg9HBFTKb6b+922XrqmQWfAiQijI5ivHI0wAsZjRjxbAXRRJ+4TReAWnRF03m2bmdcbiiZuGUQeLubfcuQJlqcN0szz68k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782806499; c=relaxed/simple; bh=cgCorLCAb0yDNWSRu0XQEpaIFmCxSgaLAb5jZK31Fsk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m2fFoeQ+EP1vggyCXBnpRfUZnEDniYnZSoQHcAtNBExeQQhhAbdRz7toIGsHny6XyauKSwcQAkI6hTAqZIjJW/syWK8iE6J5vodoGs818xqMvwB6HWb7uMEJcoG35g7LX8umDdtK34tgtTg0XrCPx7+H62zxzmCDI1DlPNL3Xls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BmeaAAvr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LjdMzmGv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BmeaAAvr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LjdMzmGv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U6CKaQ1089388 for ; Tue, 30 Jun 2026 08:01:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IswBlb2AzqPmlcHDIkKH8P06/OkA5QrfAQpG7ms3Yg0=; b=BmeaAAvrms5eqOmg W+Vm4pbG8ytGREDBf7XDsDVHNLsWl1UasWjr1y4eugEcs8IWbhO2z+GYX5TesBWd 9cWRbuOHDncliYAH9kpgN1HHh42DviBt0pRQ4tGPsh33c4b/y4pG6+jv7XFF6Lr/ uLr8vW7mImeRJjXGz7Krmhlef5u6XLYYmLp1GtpbzDJ62Kq6RqfPzUP66tHB4Dfw H8tX3PDkiR+kWbmHPVSJgwcMsNDCtOwbrsu72Ix6V+L+/GIa2MCUHZ5ydl4AP5dC +tQ8c2ZUeHq2VODRHDOzZjLoTvac9QYLVqlRnQ/s1x6KYPGSgxu0gelXmPDgSLIX mi4eLQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f43vfheb9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 08:01:37 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-847a483ea41so495655b3a.0 for ; Tue, 30 Jun 2026 01:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782806497; x=1783411297; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IswBlb2AzqPmlcHDIkKH8P06/OkA5QrfAQpG7ms3Yg0=; b=LjdMzmGvfzGjpCmRXwte5GtWT5Zc5ZkKgYgZqK0FswS6Xpqj7FL/mA8XA2NJLj5Yix ls3TmULBdJ6rEjvYgh6YpjpmMpRPK80J/Ci/BMIvhqE8SE3pX/3bUKKQTnzoDxawpt8B /PmfESuygKbHTHd9h4SbYGpmFKEXXW9sFKZnKsq+FTtcM3vSGBNwOhdHmw/2JCHXTaw5 5k49RuCjRMhaxrS95K8hPxX5pfSC5UoAOFGCC4XoQBbVUXmkTEt43QciUAybjL+iba/j GeqrxTCFdIeJ+rDHyDCSEYqh5uiaJl+3dz7puhvJGhWLyq0W4TqDX9QXcVlRCys02Psk JWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782806497; x=1783411297; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IswBlb2AzqPmlcHDIkKH8P06/OkA5QrfAQpG7ms3Yg0=; b=jDCElV3dHMIPSmKAh1ij2iVOMuYBZQESkPdx2GKUwNbpuRN2rxBewfV+vA7XHFvlxq DO5tuCV4HMHq4ZgWwhABQoMXDyEGP6td76tc2LqtuPG9ODzEhy4kN4dQZ00eouQQI+QM G8jHS0isS0syc1qO06hEuemIIsY8tLdYNJiPzdZ0+OJTBzf2p+CKFfTNAiSbWcSub/IR BM3owxlk+w9XLVBV2VFdoEHXEs5EtdYZDmDrSwHBmkYK60cAA7zV4nB4ZbQABlO5+EEi iXZubBY/qGzaoVxITBl9gafNXml4wpb5jQUAlJLFVFeB4C3Zmr4Cr+i64qvhWlvJ08am aS0Q== X-Forwarded-Encrypted: i=1; AHgh+Rp/NtmF08v1WsUcOsyz0ii7B/98vZ5WlItwn2WqFluOeNHnwitrso1bQYHENpT0JS+O88mtgK1UL3cKarM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4Xhq5DinX2VXXZML9owcIbmmLVx1F4rk9u2wjPdGhdtNQ9v1w hJAjlXMgN/7DiXR8ZwdoOy+D7VGtIUa5TqX88KwMkKJvzH9JONYdUv1mjM1L16WCPKAeNiOgq6V XdSwNc5qiKBVBZ1CvFV8afa3ZhT+3v7dslWTK8wfT6G036GCo5KonauAuVWz14bGHzIM= X-Gm-Gg: AfdE7cmxY2dfpDny1E2X/7T+FQj/pkTvHfZgRjAMoXQCi0PlvOzxRSsKJV1Y2Q8AvCQ MU4y0U0Uy78DBM9aYeqE102ZRCjrdpT4+u1KSYUrFi1ob+bMBs7dNHCY1hWyur5/p4IwyTEJ1pr jbzkq9Y0OTJc3+9HE9Mgp/Y5VhL9FMN1IUTbc9pqB3ekri/FK904chSW7CXzVCs21yIihmxinq1 67mNzoJSdSJ3/NXDy85OqdNliZDO7YJAyAIIQDLNobqKP1N3q+nEn8rjQ19PiS16bwb20aj4hwA gx+olsJHj09XDt5qOCZevz7wGFiFegF5uuC6TOglhHju0pajhCytQq/+OLCzC6LeKps37xMcl5I k69fAZ5d1QvUHA1ouTAX1WbgJD/XlqWBlrrUfqn1rur86IhSLXkU3wvhee35gzTEdc/HOF957ZH bieE/nQxQ= X-Received: by 2002:aa7:9307:0:b0:845:df5c:2567 with SMTP id d2e1a72fcca58-847a82501afmr606104b3a.25.1782806496999; Tue, 30 Jun 2026 01:01:36 -0700 (PDT) X-Received: by 2002:aa7:9307:0:b0:845:df5c:2567 with SMTP id d2e1a72fcca58-847a82501afmr606054b3a.25.1782806496280; Tue, 30 Jun 2026 01:01:36 -0700 (PDT) Received: from [10.133.33.239] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a03cd5c2sm1384983b3a.61.2026.06.30.01.01.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 01:01:35 -0700 (PDT) Message-ID: <33ee63e5-c1df-47b6-bde1-4fe6b037878a@oss.qualcomm.com> Date: Tue, 30 Jun 2026 16:01:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 0/7] Provide support for Trigger Generation Unit To: Suzuki K Poulose , Greg KH , Jie Gan Cc: andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org References: <20260417073336.2712426-1-songwei.chai@oss.qualcomm.com> <48c6abce-c492-46a6-84ef-3074983e817c@oss.qualcomm.com> <2026062959-distaste-launder-e253@gregkh> Content-Language: en-US From: "Songwei.Chai" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: zSvo4pqySGNmu7uhPcIJIDuJaYO6y0kY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDA2OSBTYWx0ZWRfX21FQeEt4QijU KJUEt/Qlq0Gxtj2nTzUA6VNXW+JtAJgK2Pj3JqUugCgHTmBI/IolEdf0lLNDSBByRRPMAzMGq6f 7cl/xCZhEXd3ey1By+9ILL5avZQQee+itpyKRHDLcfCAdwi/IVr80ng616U4vGhg3A0VawQSnHK /GKaqUTCHBfwWTuuSy0LUXfEQ7kW2iADOvfcTJlPnycrGyveKlS0l3KP44F+oMobvFP9TlCne1i Sdmd7/BO7Pq268PLlkuRoPemxaC/h2RDUH5qIj3JqVcsiDOpHVpunfW+gXQtcAKwUkEBJPzc+t+ yHsI8U7ByxNEL9KT2Y1kTPezKwgWIT78zpqor824Krw2XUdSQr2ztyPmHpwz4whYucArGgczLN0 lmWmvdDX6hxd4NYnpmrHemh6Ozs//qrBoADxj37qAGe5duPcQDMyHXKEcOzoxF/Sp8fLji552/f LKx7/AA3085YR+U3Hag== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDA2OSBTYWx0ZWRfXwwoyHUS/WnXT AV60vV+R/omF6KXiXal/NMx5m/wIJS0vfmm9SftxNawrG5mMboOmM5Ujt8yGpI4SAB9FD0anAYN l1kuo9UXo1rXurAYRTKoAGGIVHIQ5SU= X-Proofpoint-GUID: zSvo4pqySGNmu7uhPcIJIDuJaYO6y0kY X-Authority-Analysis: v=2.4 cv=PcXPQChd c=1 sm=1 tr=0 ts=6a4377e1 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=fWFuU9I0zHhLgkhYlfEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300069 On 6/29/2026 6:44 PM, Suzuki K Poulose wrote: > Hello, > > On 29/06/2026 11:17, Songwei.Chai wrote: >> >> On 6/29/2026 12:22 PM, Greg KH wrote: >>> On Mon, Jun 29, 2026 at 11:03:33AM +0800, Songwei.Chai wrote: >>>> Hi Greg & Alexander, >>>> >>>> Apologies for interrupting again. >>>> >>>> As the TGU hardware plays an important role in Qualcomm tracing >>>> design, I >>>> would greatly appreciate it if you could kindly take some time to >>>> review >>>> this at your earliest convenience. >>> The merge window _just_ closed, please give us a chance to catch up. >>> >>> Also, why us?  Surely you have other reviewers for this code, right? >> >> Hi Greg, >> >> Understood, thanks for letting us know. >> >> Regarding your question: since this introduces a new >> drivers/hwtracing/ qcom directory, there is no existing maintainer >> for it. >> Given your scope (and Alexander's), we believe you are the most >> relevant reviewers. >> >> The reason for creating the qcom directory is as follows: >> >> /We previously tried to upstream this driver under drivers/hwtracing/ >> coresight,/ >> /but it was not accepted as it is considered Qualcomm-specific and >> not tightly/ >> /coupled with the CoreSight subsystem. Based on this feedback, we are > > Some clarification here: This device is not CoreSight  so we denied > keeping this under drivers/hwtracing/coresight/ - Not because it is > Qualcomm specific. We have TPDM, TPDA, TnoC devices under the coresight > subsystem, which are all Qualcomm specific for e.g. > > That said, there are other drivers in drivers/hwtracing/ which I usually > merge and push to Greg, after some reviews/acks from the respective > people (e.g., PTT HiSilicon PCIe Tune and Trace). > > But, your proposal was that there were other maintainers for your new > subtree and you were going to push this via ,linux-arm-msm ? to which I > didn't have any objections. > > That said, I am fine with pushing this to Greg via the CoreSight pull > requests (similar to Hisilicon PTT driver), but would need someone to > Maintain/Review the driver (with entries in MAINTAINERS, similar to > PTT). > > > Thoughts ? Hi Suzuki, Thank you for your constructive feedback in helping us move this patch forward. As the owner of this driver, together with Jie Gan (who has extensive review experience), we will be responsible for the maintenance and review going forward. The MAINTAINERS update will be included in the next TGU release. Feel free to share any additional comments. Thanks, Songwei > > Kind regards > Suzuki > > > >> exploring/ >> /a dedicated drivers/hwtracing/qcom directory, similar to intel_th, >> to better/ >> /support this and future Qualcomm hwtracing drivers./ >> >> More details can be found in “[PATCH v14 0/7] -- Why we are proposing >> this”. >> >> Thanks, >> Songwei >> >>> >>> thanks, >>> >>> greg k-h >