From: Laura Abbott <labbott@redhat.com>
To: Olof Johansson <olof@lixom.net>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Kocialkowski <contact@paulk.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: build with baremetal linker target instead of Linux when available
Date: Fri, 13 Jul 2018 12:21:37 -0700 [thread overview]
Message-ID: <33f65453-5b6d-0684-8a91-7e9940846143@redhat.com> (raw)
In-Reply-To: <20180713153033.20540-1-olof@lixom.net>
On 07/13/2018 08:30 AM, Olof Johansson wrote:
> Not all toolchains have the baremetal elf targets, RedHat/Fedora ones
> in particular. So, probe for whether it's available and use the previous
> (linux) targets if it isn't.
>
For the Fedora toolchains:
Tested-by: Laura Abbott <labbott@redhat.com>
> Reported-by: Laura Abbott <labbott@redhat.com>
> Cc: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> arch/arm64/Makefile | 9 +++++----
> scripts/Kbuild.include | 4 ++--
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index e7101b19d590..efe61a2e4b5e 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -60,15 +60,16 @@ ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
> KBUILD_CPPFLAGS += -mbig-endian
> CHECKFLAGS += -D__AARCH64EB__
> AS += -EB
> -# We must use the linux target here, since distributions don't tend to package
> -# the ELF linker scripts with binutils, and this results in a build failure.
> -LDFLAGS += -EB -maarch64linuxb
> +# Prefer the baremetal ELF build target, but not all toolchains include
> +# it so fall back to the standard linux version if needed.
> +LDFLAGS += -EB $(call ld-option, -maarch64elfb, -maarch64linuxb)
> UTS_MACHINE := aarch64_be
> else
> KBUILD_CPPFLAGS += -mlittle-endian
> CHECKFLAGS += -D__AARCH64EL__
> AS += -EL
> -LDFLAGS += -EL -maarch64linux # See comment above
> +# Same as above, prefer ELF but fall back to linux target if needed.
> +LDFLAGS += -EL $(call ld-option, -maarch64elf, -maarch64linux)
> UTS_MACHINE := aarch64
> endif
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index c8156d61678c..1e13f502b42f 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -163,8 +163,8 @@ cc-ldoption = $(call try-run,\
> $(CC) $(1) $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -nostdlib -x c /dev/null -o "$$TMP",$(1),$(2))
>
> # ld-option
> -# Usage: LDFLAGS += $(call ld-option, -X)
> -ld-option = $(call try-run, $(LD) $(LDFLAGS) $(1) -v,$(1),$(2))
> +# Usage: LDFLAGS += $(call ld-option, -X, -Y)
> +ld-option = $(call try-run, $(LD) $(LDFLAGS) $(1) -v,$(1),$(2),$(3))
>
> # ar-option
> # Usage: KBUILD_ARFLAGS := $(call ar-option,D)
>
next prev parent reply other threads:[~2018-07-13 19:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 20:09 [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants" Laura Abbott
2018-07-09 23:24 ` Laura Abbott
2018-07-10 0:29 ` Kevin Hilman
2018-07-10 9:01 ` Will Deacon
2018-07-10 9:30 ` Paul Kocialkowski
2018-07-10 9:36 ` Will Deacon
2018-07-13 14:59 ` Olof Johansson
2018-07-13 15:01 ` Olof Johansson
2018-07-13 15:08 ` Paul Kocialkowski
2018-07-13 15:07 ` Will Deacon
2018-07-13 15:15 ` Olof Johansson
2018-07-13 15:30 ` [PATCH] arm64: build with baremetal linker target instead of Linux when available Olof Johansson
2018-07-13 19:21 ` Laura Abbott [this message]
2018-07-13 19:58 ` Olof Johansson
2018-07-18 23:08 ` Masahiro Yamada
2018-07-19 0:18 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f65453-5b6d-0684-8a91-7e9940846143@redhat.com \
--to=labbott@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=contact@paulk.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=olof@lixom.net \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®