mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Hungyu Lin <dennylin0707@gmail.com>, vikash.garodia@oss.qualcomm.com
Cc: dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: qcom: iris: initialize managed OPP pointer
Date: Mon, 8 Jun 2026 11:13:32 +0100	[thread overview]
Message-ID: <33fb108d-97c1-4d10-8740-3376b47b9937@kernel.org> (raw)
In-Reply-To: <20260604000414.32530-1-dennylin0707@gmail.com>

On 04/06/2026 01:04, Hungyu Lin wrote:
> Initialize the __free(put_opp) managed OPP pointer to NULL.
> 
> This ensures the cleanup handler always sees a defined value and
> avoids leaving the managed pointer uninitialized before assignment.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>   drivers/media/platform/qcom/iris/iris_resources.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
> index 773f6548370a..6b22f5cc88ca 100644
> --- a/drivers/media/platform/qcom/iris/iris_resources.c
> +++ b/drivers/media/platform/qcom/iris/iris_resources.c
> @@ -61,7 +61,7 @@ int iris_unset_icc_bw(struct iris_core *core)
> 
>   int iris_opp_set_rate(struct device *dev, unsigned long freq)
>   {
> -	struct dev_pm_opp *opp __free(put_opp);
> +	struct dev_pm_opp *opp __free(put_opp) = NULL;
> 
>   	opp = devfreq_recommended_opp(dev, &freq, 0);
>   	if (IS_ERR(opp))
> --
> 2.34.1
> 
> 

Requires a Fixes:

+ Cc: stable@vger.kernel.org

---
bod

      parent reply	other threads:[~2026-06-08 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <adh8nAvf7xr--5KPtVFALkSnS3fjqr_6gPpV_hWfp_WYNh-qUCry-pXc6jgUGMkNzs-8EfSp2TQFsB2lWga0gg==@protonmail.internalid>
2026-06-04  0:04 ` Hungyu Lin
2026-06-07 21:37   ` Dmitry Baryshkov
2026-06-08 10:13   ` Bryan O'Donoghue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33fb108d-97c1-4d10-8740-3376b47b9937@kernel.org \
    --to=bod@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=dennylin0707@gmail.com \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®