From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <marc.zyngier@arm.com>,
"Joe.C" <yingjoe.chen@mediatek.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Sricharan R <r.sricharan@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
"yingjoe.chen@gmail.com" <yingjoe.chen@gmail.com>,
"yh.chen@mediatek.com" <yh.chen@mediatek.com>,
"arm@kernel.org" <arm@kernel.org>,
"nathan.chung@mediatek.com" <nathan.chung@mediatek.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <Pawel.Moll@arm.com>, Matt Porter <mporter@linaro.org>,
Marc Carino <marc.ceeeee@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"eddie.huang@mediatek.com" <eddie.huang@mediatek.com>,
"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
"hc.yen@mediatek.com" <hc.yen@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>,
Jiang Liu <jiang.liu@linux.intel.com>
Subject: Re: [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain.
Date: Thu, 09 Oct 2014 19:22:29 +0200 [thread overview]
Message-ID: <3400038.iFbzPVHU3g@wuerfel> (raw)
In-Reply-To: <5436BF0C.1030508@arm.com>
On Thursday 09 October 2014 17:59:56 Marc Zyngier wrote:
> > @@ -952,7 +988,11 @@ void __init gic_init_bases(unsigned int gic_nr, int irq_start,
> >
> > gic_irqs -= hwirq_base; /* calculate # of irqs to allocate */
> >
> > - if (of_property_read_u32(node, "arm,routable-irqs",
> > + if (IS_ENABLED(CONFIG_IRQ_DOMAIN_HIERARCHY) &&
> > + of_find_property(node, "arm,irq-domain-hierarchy", NULL))
> > + gic->domain = irq_domain_add_linear(node, gic_irqs,
> > + &gic_irq_domain_hierarchy_ops, gic);
>
> I really think that looking for a property is the wrong thing to do. If
> "node" is non-NULL, then we're pretty sure that we're initializing from
> DT, and that a pure linear domain should be the right thing, leaving the
> legacy stuff for the few non-DT platforms that are still around.
FWIW, these are the remaining ones that use gic:
arch/arm/mach-cns3xxx/core.c: gic_init(0, 29, IOMEM(CNS3XXX_TC11MP_GIC_DIST_BASE_VIRT),
arch/arm/mach-realview/realview_eb.c: gic_init(0, 29, __io_address(REALVIEW_EB11MP_GIC_DIST_BASE),
arch/arm/mach-realview/realview_eb.c: gic_init(1, 96, __io_address(REALVIEW_EB_GIC_DIST_BASE),
arch/arm/mach-realview/realview_eb.c: gic_init(0, 29, __io_address(REALVIEW_EB_GIC_DIST_BASE),
arch/arm/mach-realview/realview_pb1176.c: gic_init(0, IRQ_DC1176_GIC_START,
arch/arm/mach-realview/realview_pb1176.c: gic_init(1, IRQ_PB1176_GIC_START,
arch/arm/mach-realview/realview_pb11mp.c: gic_init(0, 29, __io_address(REALVIEW_TC11MP_GIC_DIST_BASE),
arch/arm/mach-realview/realview_pb11mp.c: gic_init(1, IRQ_PB11MP_GIC_START,
arch/arm/mach-realview/realview_pba8.c: gic_init(0, IRQ_PBA8_GIC_START,
arch/arm/mach-realview/realview_pbx.c: gic_init(0, 29, __io_address(REALVIEW_PBX_TILE_GIC_DIST_BASE),
arch/arm/mach-realview/realview_pbx.c: gic_init(0, IRQ_PBX_GIC_START,
arch/arm/mach-shmobile/intc-sh73a0.c: gic_init(0, 29, gic_dist_base, gic_cpu_base);
arch/arm/mach-tegra/irq.c: gic_init(0, 29, distbase,
arch/arm/mach-vexpress/ct-ca9x4.c: gic_init(0, 29, ioremap(A9_MPCORE_GIC_DIST, SZ_4K),
Linus Walleij is working on realview, Pawel already has a patch for vexpress, the tegra one
can just be removed and the Renesas team will deal with shmobile.
This basically leaves cns3xxx, which now has a new maintainer but I suspect we won't
have DT-only support for it too soon anyway.
Arnd
next prev parent reply other threads:[~2014-10-09 17:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1412864980-20273-1-git-send-email-yingjoe.chen@mediatek.com>
[not found] ` <1412864980-20273-7-git-send-email-yingjoe.chen@mediatek.com>
2014-10-09 14:57 ` [PATCH v3 6/7] dt-bindings: add irq domain parent binding Mark Rutland
[not found] ` <1412864980-20273-4-git-send-email-yingjoe.chen@mediatek.com>
2014-10-09 16:59 ` [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain Marc Zyngier
2014-10-09 17:22 ` Arnd Bergmann [this message]
[not found] ` <1413196996.23455.9.camel@mtksdaap41>
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:27 ` Arnd Bergmann
2014-10-13 9:44 ` Marc Zyngier
[not found] ` <1412864980-20273-2-git-send-email-yingjoe.chen@mediatek.com>
2014-10-13 12:11 ` [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Marc Zyngier
2014-10-13 14:13 ` Jiang Liu
[not found] ` <1412864980-20273-5-git-send-email-yingjoe.chen@mediatek.com>
2014-10-09 14:37 ` [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support Arnd Bergmann
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3400038.iFbzPVHU3g@wuerfel \
--to=arnd@arndb.de \
--cc=Mark.Rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=arm@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@linaro.org \
--cc=hc.yen@mediatek.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.ceeeee@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mporter@linaro.org \
--cc=nathan.chung@mediatek.com \
--cc=olof@lixom.net \
--cc=r.sricharan@ti.com \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yh.chen@mediatek.com \
--cc=yingjoe.chen@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®