From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbcG3UPZ (ORCPT ); Sat, 30 Jul 2016 16:15:25 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:58300 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752840AbcG3UPS (ORCPT ); Sat, 30 Jul 2016 16:15:18 -0400 From: Arnd Bergmann To: Philipp Zabel Cc: Masahiro Yamada , Axel Lin , Linux Kernel Mailing List , Hans de Goede , Maxime Ripard , Lee Jones , linux-arm-kernel Subject: Re: Why do we need reset_control_get_optional() ? Date: Sat, 30 Jul 2016 22:13:54 +0200 Message-ID: <3400649.NoVKUzu81R@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1469797695.3012.48.camel@pengutronix.de> References: <1469797695.3012.48.camel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:y5g1++f3h1HGUGOu64ZlDLLUnSEuP7rqa8mW9ziRH/vi5ptn0P3 Og7m9NEp3srG0dmQu3Bkr5TL5yvONfaKR01NAYwqmg9GASBXsiANq0l2mYHstiyKkgtC98j Vkp6c+THWXu671Sr0gj9HJ+xCiQhuGZZgaxq41ZWnmkDzEeXxeRB1A08x7idAq9WfqEive1 n22YFrluTPKYLK3tg0YJQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:93XrMYcoGxI=:wpL7z32cKahR7CF/z9JRbf 6TKPsO+Ys6TsU8TwwJzuQL4Hcig1gr2ZhAJ1ewkjJRSTwUdru3mpUynDvieurjtNoRDT1XY4m qitDECOtm/ht4gWBioBA8iYt7UFydV4IDctriutHI6WG6cbhpq9vxR/dhzb3Tt6yy0eu6a6IP QSOBqE1pk9xQZ1pOrUJFhygvnGdNlisp5qVFdgoIhGMIcrEbgZ356g58oWAOWps82zHYaSOeg Gmsn89xjMMIBHILophWckyXJ4JI7kKdVbjJOD3AQQixtqSocppXKH4l2T3Umt4INBOqV11dZC LPHa+2/K0wWevkD9XdyRkZakyC/5u560F7zI1kgi3hHkdjZfQmnOWc/P4VIRi3yJnmBOr9Gwc weZiuUY2AwRUGXZtVWSG7EBKfL4XtSlfv/IS7fRC7MtLaXvqUqtNcqiHfqhS7xFs6n2KLdmGJ wk/tXcJA6L1aH/SFdOGYRKfS0u17rg7sQWUohubiCVtqVeatDiNrUmssOYhBD5BIxi++JAkcT 3JG44wvONQf/gTQ0L7usftfcchT0i0Y74AWHxAQHdOMwOaf3zSMYeAhVDxB3rb3X1Zi8RXV01 mta0r0r1Hph/2pPU6KLkvprQNo3GZC0ebK6tcXv2sZzTLShVjpxedjg2ZMwLiskHl6a0OchOK JtkWB6o1XXijR7YRCEKo7fSKTsSbrs6rF7UeLgtTY3PKpURaGdzde5+EuamclU1gkm7l3aSIj B2ZayLzh/Oai7wHO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote: > Hi Masahiro, > > Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: > [...] > > However, I think the following makes more sense: > > > > > > menuconfig RESET_CONTROLLER > > bool "Reset Controller Support" > > depends on (ARCH_HAS_RESET_CONTROLLER || COMPILE_TEST) > > default y > > help > > Generic Reset Controller support. > > That looks sensible to me. You'll only have to enable the reset > controller framework if either some enabled architecture has a reset > controller (in which case you want the driver for it to be activated by > default), or if you want to compile test some of the reset drivers. This still doesn't let a platform 'select RESET_FOO', unless they also select RESET_CONTROLLER and ARCH_HAS_RESET_CONTROLLER. Why do we need to guard all drivers inside of two symbols? Arnd