From: Valdis.Kletnieks@vt.edu
To: Ravi Teja Darbha <ravi2j@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Arjun Krishna Babu <arjunkrishnababu96@gmail.com>,
devel@driverdev.osuosl.org, lidza.louina@gmail.com,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function
Date: Mon, 06 Jul 2015 09:28:51 -0400 [thread overview]
Message-ID: <34054.1436189331@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 06 Jul 2015 18:50:12 +0530." <20150706132012.GA5180@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said:
> Why would you use a macro to avoid code duplication?
The macro does end up putting code in each place it's used.
However, the actual code is in one place rather than open-coded
in multiple places that can diverge over time (somebody patching 2 of
3 instances, and missing 1, for example).
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2015-07-06 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 18:16 Arjun Krishna Babu
2015-07-06 7:32 ` Dan Carpenter
2015-07-06 12:15 ` Ravi Teja Darbha
2015-07-06 12:27 ` Sudip Mukherjee
2015-07-06 13:20 ` Ravi Teja Darbha
2015-07-06 13:28 ` Valdis.Kletnieks [this message]
2015-07-06 14:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34054.1436189331@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=arjunkrishnababu96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi2j@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome