From: "Andi Kleen" <andi@firstfloor.org>
To: "Lin Ming" <ming.m.lin@intel.com>
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Ingo Molnar" <mingo@elte.hu>,
"Stephane Eranian" <eranian@google.com>,
"Andi Kleen" <andi@firstfloor.org>,
"lkml" <linux-kernel@vger.kernel.org>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Arjan van de Ven" <arjan@infradead.org>
Subject: Re: [RFC PATCH 3/3 v2] perf: Update perf tool to monitor uncore events
Date: Sun, 21 Nov 2010 13:09:35 +0100 [thread overview]
Message-ID: <340872239c47b2ec237c88488cb7b6ac.squirrel@www.firstfloor.org> (raw)
In-Reply-To: <1290340907.2245.125.camel@localhost>
>
> samples pcnt function DSO
> _______ _____ ______________________
> ____________________________________
>
> 8.00 18.6% kallsyms_expand_symbol [kernel.kallsyms]
Reporting a symbol for an uncore event seems highly misleading.
After all the uncore counter has no idea for which core the event was,
so there isn't really any instruction pointer to report.
The event could be event caused by a PCI device or similar.
For per function monitoring of uncore events one has to use
OFFCORE_RESPONSE, like I implemented recently.
I would suggest to not report any symbol names for uncore events.
Doing so just will confuse users.
In fact I suspect uncore events are only really useful
with "stat", but not with "top", or if they are used in top
then the symbol reporting should be disabled.
-Andi
next prev parent reply other threads:[~2010-11-21 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 12:01 Lin Ming
2010-11-21 12:09 ` Andi Kleen [this message]
2010-11-21 12:22 ` Stephane Eranian
2010-11-21 14:19 ` Lin Ming
2010-11-21 16:52 ` Andi Kleen
2010-11-23 9:18 ` Stephane Eranian
2010-11-21 17:45 ` Peter Zijlstra
2010-11-21 18:28 ` Andi Kleen
2010-11-21 18:30 ` Peter Zijlstra
2010-11-21 14:12 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=340872239c47b2ec237c88488cb7b6ac.squirrel@www.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®