From: Valdis.Kletnieks@vt.edu
To: Dan Williams <dan.j.williams@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: Re: linux-next crash in xhci_add_ep_to_interval
Date: Thu, 05 Jun 2014 17:10:43 -0400 [thread overview]
Message-ID: <3417.1402002643@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 05 Jun 2014 12:05:56 -0700." <1401995156.30026.2.camel@dwillia2-mobl2.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Thu, 05 Jun 2014 12:05:56 -0700, Dan Williams said:
> Subject: usb: fix ->update_hub_device() vs hdev->maxchild
>
> From: Dan Williams <dan.j.williams@intel.com>
>
> Commit d8521afe3586 "usb: assign default peer ports for root hubs"
> delayed marking a hub valid (set hdev->maxchild) until it had been fully
> configured and to enable the publishing of valid hubs to be serialized
> by usb_port_peer_mutex.
>
> However, xhci_update_hub_device() in some cases depends on
> hdev->maxchild already being set. Do the minimal fix and move it after
> the setting of hdev->maxchild.
>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Applied cleanly, booted without complaint, the keyboard that's behind
the PS2-USB converter works.
uname -r reports 3.15.0-rc8-next-20140605-dirty as expected.
So feel free to stick a Tested-By: on there. :)
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2014-06-05 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 15:22 Valdis Kletnieks
2014-06-05 15:55 ` Dan Williams
2014-06-05 16:24 ` Valdis.Kletnieks
2014-06-05 16:35 ` Dan Williams
2014-06-05 17:29 ` Valdis.Kletnieks
2014-06-05 19:05 ` Dan Williams
2014-06-05 21:10 ` Valdis.Kletnieks [this message]
2014-06-05 21:13 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3417.1402002643@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®