From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755820AbbCDB2o (ORCPT ); Tue, 3 Mar 2015 20:28:44 -0500 Received: from omr1.cc.vt.edu ([198.82.141.52]:49398 "EHLO omr1.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbbCDB2n (ORCPT ); Tue, 3 Mar 2015 20:28:43 -0500 X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6+dev To: Andy Lutomirski Cc: Ingo Molnar , "linux-kernel@vger.kernel.org" Subject: Re: Patch "x86: Store a per-cpu shadow copy of CR4" gives VirtualBox 4.3.24 indigestion. In-Reply-To: Your message of "Tue, 03 Mar 2015 17:08:37 -0800." From: Valdis.Kletnieks@vt.edu References: <9137.1425430154@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1425432514_8021P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Tue, 03 Mar 2015 20:28:34 -0500 Message-ID: <34194.1425432514@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1425432514_8021P Content-Type: text/plain; charset=us-ascii On Tue, 03 Mar 2015 17:08:37 -0800, Andy Lutomirski said: > > Are they poking cr4 directly with mov? Let's see: > > /* Enable the VMX bit in CR4 if necessary. */ > RTCCUINTREG uCr4 = ASMGetCR4(); > if (!(uCr4 & X86_CR4_VMXE)) > ASMSetCR4(uCr4 | X86_CR4_VMXE); > > ASMSetCR4 is about what you'd expect. > > I deliberately renamed write_cr4 to __write_cr4 to catch this kind of > thing in anything that uses the asm/ headers, but I can't do anything > about asm code in out-of-tree modules. Thanks for the confirmation, I've already updated the tracking bug they were using for 4.0 issues, and will chase it further with them... --==_Exmh_1425432514_8021P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Exmh version 2.5 07/13/2001 iQIVAwUBVPZfwgdmEQWDXROgAQI7VRAAuC1wfdulEOcTsb4Kj+BAz9fAJOpZeaXB 5+XOxPqJtFxIMhi/qNSQsHpDRBcl/6kx5JuFVt/xCyJ2wEwA6W31+J4kgzC5dl94 XhBG3BcvnmeZlo/Mhd9cTZaqov+Tx+cdJYBOt2BEOVmnPZN8Mj4zIkZUSs6+Uol2 OsRElKBQuFzJ6TiGLEMfs9A0+dsaXk9tg0iJMi+rmyQKFEmxYmfCmZaX6J6r0K69 /GzQ0OiDT0cBGHj2ONSw1gP8E6JJHzJaHytwIh5vmf7wxz9HPURwjyLokXqrAPpQ pzr0tRC611zd8Ek9Q4BrKJRXpdgw/KvMjHvUNPI+KzhTwnw9hMGZNZUvdreKOGKy 3fS6VUmwcGn2WjE0jjE2STH7O0UZWoqeA3GJGXikzK5X/5KgTjIUbu9UHfQa+B7I +JGDgv7pKUG24y+3saa0JOIO32XW8e6T26/k1mlOUZVZ1MdZv0cwOyQMBR+1K4Gp xFiGSkMBJltfCmeeaQmVb4POY78yYCZlr8caEJCowfTiwhJGcHdFR1Mo2awCLbci cdHUskTWfzrm+EdVDImriuqSR2yR+UJp5JZ9LttT3i227vm+znXnV/KK4MKKajkO IDtbSaWQG93inwC6ewIgwIBcmZooo2z4tQj2Jeb7Xw/P5rlUqBSFJ1KePc6baI/l WZxiNNgmWvk= =Jy87 -----END PGP SIGNATURE----- --==_Exmh_1425432514_8021P--