From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEB641F344 for ; Mon, 27 Jul 2026 15:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785167958; cv=none; b=I4anuRAcYNNxiVBsD3bOg09TxFMg+ER/HMeNc2RKgEvu8i3Bh1Us2p/b8Y683rp42U547VaNfpDnLVCQzCjh2s/vBmiYNRT++2LWpEIFF5gK/tSxZUF3BdxxcH1C3TIZ+kMf9KZPf7qIiEW2uZasai4cidaQCu7zNUP6vF/HzsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785167958; c=relaxed/simple; bh=GREFLNoFwBaO8g/qcZzBBb5BmM7mDh+vmMslx6ltmZM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qt2/DKxiiS8iLsMlO5hp2o//vVFodc/EJk3tznKC1iyDjXnWz9HEwU5P73tpNu8+Nl3Mk82OMOGGy8k1fyjxhw+D/fW21ozayHvs0Pd1PbH8beDI54Uj3ELkJDu5VKP/t1SowF7zWl6sQdMEXYE89v77gE+x9+q04ON6yeitNXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=WZtZ1fTg; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="WZtZ1fTg" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-51c5382806fso28868471cf.2 for ; Mon, 27 Jul 2026 08:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1785167955; x=1785772755; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+UjimiS1ZGH8Z9qmeBpLWyEaDQH9OUrvKHAWj/PGhmQ=; b=WZtZ1fTgVUxjVHo0yiTn+FjKi6/WHtvsuQlTdY07paWROiJntStJa8+iCGiBnyJLT0 mIaKCz66xRi+z+zi9jRDhmiXuViNE3eQemfmeRXzIzzZbUoS2wg3eHvepUG0VwPFh40a 25ASlNcM3W7MOSqqbtDL+tWj4LZDk1Ls+YX0a7OvsTI05sduf5E4B2SGRYAge14YxIax 6eTW33vTWgMIoD7awi/K18tPCwnR4r7s3BKc7DJo4bv+LvrXhmVU+OBTWkHNHWsJvaC6 hWsBEiMQnx4DlG60FsDVVhTK6JU63hYMTuOPRQ7oaSRv9xJ+MmUljfULMRemLsAey6b5 skYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785167955; x=1785772755; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+UjimiS1ZGH8Z9qmeBpLWyEaDQH9OUrvKHAWj/PGhmQ=; b=pJOmrhIV2XokVTPXpeqk3/qO0vsQp9u3LS0jgcP3INAHYSLtcgULcnaybk6+ZuzHWt DXLzHsCbfgoJKgFnhXZhmZ2GOzLKyz57jYa8T7OsWFpO7jAgigdZzNfNh6hhoJLfDwbn i/BfqvByaPfl6qD63jTX2HV/5TEBqU5w51v3Zf3LA9BXtfKZ9FLMiCTpu/Ct+Bds3VGw wS0hBcjHffoUWlVl2DfQqVijeacPt5R6YHvU0QOyDQyz9qk/IPwAYHzKTgTtqOyCgE9j 04/L94BPq95/pEsqOgMV6MqVVxD31CGZnEtLROmFG8Y5TpE/mD1f6VqebMGm0hNvls+H tgSw== X-Forwarded-Encrypted: i=1; AHgh+RpluEhSmiHy8J6+hvPQ3aKS+7ogpw9014AqAU16DqmbzxjdgZ2F0l68Z1zPiIjlGzwxLyVUjDFYn8EMFuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwvkKDtjISLvu08/NIBVUAu4eM/vI5qNPi7n4l2VQ+bzjabTgox 8plTB9R8vEdTOmAqLFguHjDzHVsAgDhoYIGs2XTB1Vs/AK+Z3pvpsTg/t7GCe1hjL1w= X-Gm-Gg: AR+sD10+AOdROPimVpUa/jPy95+saqMMBQut11jZvriOitZ/rbwAbjpkOZK6m0kUFuy xJmnHpzy+aX+FwxBZgVHRdPeWwA9Kk5Sxm4MoCWjYFsD26OnPltx+xasdOgm0mo7625l4ZcIYUo MCP3ICRSUBI0g60o87Eukcbmj5aL8zP5z9kh7z7SHd5nL+C9QPbPfai8WrDQuA+KoPLiRiu2UH7 WKsGbgbjnpbBVRBMMkd/idyKt38kyH0KxXoG2NFwwC2Cdz6HhHls1a7znBOZYhC70kaLA1QemNr CyyK+QaMMBfcWHmFHHCP4kc/wH1015m87SCuwzaGp691jdrQ0sDbQVAlX3K+159kRVfYBbgESES i7H/fPUK+24lAr3mpYPEIZlrBxWKGhscOjXJBy4hXom5HXxQiuEab9AiV6aw0QVzSUatYKV+aWn uQoA== X-Received: by 2002:a05:622a:d1:b0:51c:2685:2964 with SMTP id d75a77b69052e-529a86811cemr92228301cf.43.1785167955252; Mon, 27 Jul 2026 08:59:15 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529a262fa9dsm56944561cf.0.2026.07.27.08.59.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 08:59:14 -0700 (PDT) Message-ID: <341eff6e-9acb-43c3-9514-578bb628bf27@riscstar.com> Date: Mon, 27 Jul 2026 10:59:14 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] PCI/pwrctrl: tc9563: Rename DSP3 to VDSP To: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Chaitanya Chundru , Bartosz Golaszewski , Bjorn Andersson Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> <20260725-tc9563-fix-v1-5-ec4286e31331@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260725-tc9563-fix-v1-5-ec4286e31331@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/25/26 3:59 AM, Manivannan Sadhasivam via B4 Relay wrote: > From: Manivannan Sadhasivam > > TC9563 Reference Manual calls DSP3 as VDSP (Virtual Downstream Port). Hence > name it as such to avoid ambiguity. I didn't really like the overloaded "virtual" term (though maybe it is normal for PCI). However I do like that this makes it clearer that the third downstream port is different from the first two. Reviewed-by: Alex Elder > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > index 28e9ec3e172a..f1179737f221 100644 > --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > @@ -80,7 +80,7 @@ enum tc9563_pwrctrl_ports { > TC9563_USP, > TC9563_DSP1, > TC9563_DSP2, > - TC9563_DSP3, > + TC9563_VDSP, > TC9563_ETHERNET, > TC9563_MAX > }; > @@ -328,8 +328,8 @@ static int tc9563_pwrctrl_set_tx_amplitude(struct tc9563_pwrctrl *tc9563, > case TC9563_DSP2: > port_access = 0x8; > break; > - case TC9563_DSP3: > - dev_dbg(dev, "Tx amplitude tuning not supported for DSP3\n"); > + case TC9563_VDSP: > + dev_dbg(dev, "Tx amplitude tuning not supported for VDSP\n"); > return 0; > default: > return -EINVAL; > @@ -368,8 +368,8 @@ static int tc9563_pwrctrl_disable_dfe(struct tc9563_pwrctrl *tc9563, > port_access = 0x8; > lane_access = 0x1; > break; > - case TC9563_DSP3: > - dev_dbg(dev, "DFE tuning not supported for DSP3\n"); > + case TC9563_VDSP: > + dev_dbg(dev, "DFE tuning not supported for VDSP\n"); > return 0; > default: > return -EINVAL; > @@ -612,10 +612,10 @@ static int tc9563_pwrctrl_probe(struct platform_device *pdev) > break; > > /* > - * The integrated Ethernet MAC Endpoint under DSP3 is a single > + * The integrated Ethernet MAC Endpoint under VDSP is a single > * device whose functions share the same config registers. > */ > - if (port == TC9563_DSP3) { > + if (port == TC9563_VDSP) { > struct device_node *eth __free(device_node) = > of_get_next_available_child(child, NULL); > if (eth) { >