From: Markus Elfring <Markus.Elfring@web.de>
To: "Ankit Soni" <Ankit.Soni@amd.com>,
iommu@lists.linux.dev, "Jörg Rödel" <joro@8bytes.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Vasant Hegde" <vasant.hegde@amd.com>,
"Will Deacon" <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iommu/amd: move wait_on_sem() out of spinlock
Date: Sat, 10 Jan 2026 15:00:16 +0100 [thread overview]
Message-ID: <34214ff1-3aed-4d6c-8ea6-379341bb0c29@web.de> (raw)
In-Reply-To: <60d2601b17c7008834fe393e75990371cdac74b5.1764591214.git.Ankit.Soni@amd.com>
…
> +++ b/drivers/iommu/amd/iommu.c
…
> @@ -3094,13 +3098,18 @@ static void iommu_flush_irt_and_complete(struct amd_iommu *iommu, u16 devid)
…
> +out_err:
> raw_spin_unlock_irqrestore(&iommu->lock, flags);
> + return;
> }
…
How do you think about to omit a return statement at the end of the implementation
of such a function with the type “void”?
See also:
https://elixir.bootlin.com/linux/v6.19-rc4/source/scripts/checkpatch.pl#L5612-L5622
Regards,
Markus
prev parent reply other threads:[~2026-01-10 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 14:39 Ankit Soni
2025-12-02 5:14 ` Vasant Hegde
2026-01-10 9:54 ` Jörg Rödel
2026-01-10 14:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34214ff1-3aed-4d6c-8ea6-379341bb0c29@web.de \
--to=markus.elfring@web.de \
--cc=Ankit.Soni@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®