From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753854AbdBJU1U (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 15:27:20 -0500
Received: from mout.kundenserver.de ([212.227.17.24]:63580 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752509AbdBJU1R (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 15:27:17 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing
Date: Fri, 10 Feb 2017 21:26:55 +0100
Message-ID: <3421824.lhyKKsOD1E@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.8.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CACRpkdYmfv0XCirnaMSqZ7O9cKp2XAvqJoGQBSXqHN9fSKGnHg@mail.gmail.com>
References: <20170208200010.21522-1-ulli.kroll@googlemail.com> <alpine.LNX.2.00.1702091513580.6226@T420s> <CACRpkdYmfv0XCirnaMSqZ7O9cKp2XAvqJoGQBSXqHN9fSKGnHg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:XuLnfLni/7dhnAp5oOrjO9/6LTsUy1TioBZtY6FnaOoXP/hrp4M
 O+hogYqZZPmKQhJWqisx7GRhqwxqChw4PMjiwiDXFAj2r63R9CNw/Bj2udGfYoGGy10nsNn
 JWyef95sZd+r8PnKkTIJmzsZcrLqzBZNSXUuQVo2FXOdpkpNBROJ9txDgMwUoKjMSIr8N7A
 jKedOe4IXXPpj5XSbTOiQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:dnZ4BRR1BrE=:BnxAmYm50lZM3MASpqOvni
 3mHH/s4Kq6Nc6g2mvadATizgsq+AV0WidFPH9u/w9lJyoQ3ZW4cUhEut7BNqGUzY+MnCmHIsH
 HqPn/9h6vbvpxwtQ+sZ9Q52Aq0aBlrFy1eyBSnhHxnROTJtWS4BwDVtgzow2HmD7hUCaPBI1e
 VmTeTgYvcNT8+Ib+HvLkgsQxqjw0IOApjDMh7PcYQrZKg+ZRLK5MxFSypVO3WrpkI5hgt9T3T
 7QSBUhhyRfVwuVQxeUCOSCdVLDUSPymSxzxMQSNggqRlFUHOWW1+Dp2O0jIELiIZ8WEirV91Y
 rVNI172jHpQIbRPlMsLM2ybPsUQlOKB46YeLZa/hPwIE4jZCLXPKh6G/1x3U+URahhDCYuen0
 2bPe2RhFGWbOj3bMYEjmGNtTZGI3i3ysrbKWK+7HEe8AC1yntMMot3+ZIbziDFZUzSufw9xHp
 HQ78bCHl43VC73RO9pUUwlZMsY8zr32dZzrXZmaDBrcjoE2E1otjarYP3A0GMTDyJPCfuckBe
 V9DOo9xErOiCT4bZWNxDnVtoRLEPf3iM1bR5O2nf8VSs4Jo76240SNus22ydgAUdgphSiNHLQ
 LKxdFiTG3Dn55uNIaMr4HfIUoqca1pw12ZqrgpRil7OY8nYMFG2GZJtd5Dm0/ckBSwhtBST+m
 FZsx86b1B/xAQl5v1u71/trQ2hYEG7oOwjDMOPP4Q1+jkJpvXsvZiZ/6Jjl5PVrZVPTboqfV6
 CUsvlQGk0sxHmTD5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, February 10, 2017 2:12:36 PM CET Linus Walleij wrote:
> 
> > +       /* Right now device-tree probed devices don't get dma_mask set.
> > +        * Since shared usb code relies on it, set it here for now.
> > +        * Once we have dma capability bindings this can go away.
> > +        */
> > +
> > +       retval = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > +       if (retval)
> > +               goto fail_create_hcd;
> 
> Were you able to test this part? I saw the gemini has some DMA engine
> but I never saw a driver for it. It looks like a reasonable thing to do to
> my untrained DMA eye.

We should never use dma_coerce_mask_and_coherent() for new code, it's
only needed for broken platforms without DT.

A 32-bit mask is set by default.

	Arnd