From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Conor Dooley <conor@kernel.org>, <linux-i2c@vger.kernel.org>
Cc: prashanth kumar burujukindi
<prashanthkumar.burujukindi@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Andi Shyti <andi.shyti@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] i2c: microchip-corei2c: add smbus support
Date: Wed, 30 Apr 2025 17:06:09 +0530 [thread overview]
Message-ID: <3421bf4a-afa1-4b4c-8421-bad7187d3d8e@quicinc.com> (raw)
In-Reply-To: <20250430-preview-dormitory-85191523283d@spud>
On 4/30/2025 4:53 PM, Conor Dooley wrote:
> From: prashanth kumar burujukindi <prashanthkumar.burujukindi@microchip.com>
>
> In this driver the supported SMBUS commands are smbus_quick,
> smbus_byte, smbus_byte_data, smbus_word_data and smbus_block_data.
>
Write completely in imperative mood. something like :
Add support for SMBUS commands in driver
Add support for SMBUS commands: smbus_quick, smbus_byte,
smbus_byte_data, smbus_word_data, and smbus_block_data.
Also mention below limitations here .
SMBUS block read is supported by the controller but has not been tested
due to lack of hardware. However, SMBUS I2C block read has been tested.
> Signed-off-by: prashanth kumar burujukindi <prashanthkumar.burujukindi@microchip.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> smbus block read is not tested, due to lack of hardware, but is supported
> by the controller, although we have tested smbus i2c block read.
>
> CC: Conor Dooley <conor.dooley@microchip.com>
> CC: Daire McNamara <daire.mcnamara@microchip.com>
> CC: Andi Shyti <andi.shyti@kernel.org>
> CC: linux-i2c@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
> drivers/i2c/busses/i2c-microchip-corei2c.c | 102 +++++++++++++++++++++
> 1 file changed, 102 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-microchip-corei2c.c b/drivers/i2c/busses/i2c-microchip-corei2c.c
[...]
next prev parent reply other threads:[~2025-04-30 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 11:23 Conor Dooley
2025-04-30 11:36 ` Mukesh Kumar Savaliya [this message]
2025-05-05 20:04 ` Andi Shyti
2025-05-06 10:56 ` Conor Dooley
2025-05-06 12:04 ` Andi Shyti
2025-05-08 11:39 ` Conor Dooley
2025-05-12 23:42 ` Andi Shyti
2025-05-08 10:14 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3421bf4a-afa1-4b4c-8421-bad7187d3d8e@quicinc.com \
--to=quic_msavaliy@quicinc.com \
--cc=andi.shyti@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prashanthkumar.burujukindi@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®