From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755987AbdEKPBs (ORCPT ); Thu, 11 May 2017 11:01:48 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:38337 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755869AbdEKPBo (ORCPT ); Thu, 11 May 2017 11:01:44 -0400 X-AuditID: b6c32a2e-f79506d0000046c0-a4-59147cd00fbe From: Bartlomiej Zolnierkiewicz To: Tejun Heo Cc: SF Markus Elfring , linux-ide@vger.kernel.org, Hans de Goede , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/3] SATA: Fine-tuning for two function implementations Date: Thu, 11 May 2017 17:01:34 +0200 Message-id: <3428511.iH6kg31xz3@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170428215334.GH22354@htj.duckdns.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnleLIzCtJLcpLzFFi42LZdlhTU/dijUikQcsqZovzncuZLd4cn85k sfWWtMWxHY+YLC7vmsNm8Wv5UUYHNo9NqzrZPN7vu8rm0XSqndXj8ya5AJYoLpuU1JzMstQi fbsEroxLkzgKTrNXHL10mqmBsZuti5GTQ0LAROJ9504mCFtM4sK99UBxLg4hgaWMEvOfr2OH cD4zSszc1M4K0/Htw1YWiMRaRonfz/6ygCSEBL4ySuz8EANiswlYSUxsX8UIYosIyEpcmfaQ EaSBWWA/o8TC78/BGoQFvCV+/DvMDGKzCKhK/NzxEayBV0BTYv+T62C2qICXxJZ97WD3cQqY Ssx5948JokZQ4sfke2BzmAXkJfbtn8oKYetInD22DmyZhEAzu8SjBd+AHuIAcmQlNh1ghvjA ReLSn1VQ3whLvDq+hR3ClpLo7pgFZU9nlNj+WwJizmZGiVW7J0AlrCUOH78ItYxPovf3EyaI +bwSHW1CECUeEsuWvGGBCDtKvGovhQTWcUaJpae/Mk5glJ+F5IVZSF6YheSFBYzMqxjFUguK c9NTi00LjPWKE3OLS/PS9ZLzczcxgpOHlt4Oxn8LvA8xCnAwKvHwSlSJRAqxJpYVV+YeYpTg YFYS4VUpBQrxpiRWVqUW5ccXleakFh9ilOZgURLn1Vh5LUJIID2xJDU7NbUgtQgmy8TBKdXA mOk267hdcPr0neb7l0T2/Vxpz6U3udR/cWP0iSDn1It9hs9MTrLUCF9at0ZlX7XIPpdXae9f 8W8MP9NtlbRxfYDVszP+Ho09Jjb8co4vN9y41qP59ijTgknsf3ulSmJCFz2++TKfLem+5qoH c3y8IrLT/NlZrsxYmiJ5yJR7Z/MOP5l1JgyblViKMxINtZiLihMBtFJadBoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t9jQd0LNSKRBm0zpCzOdy5ntnhzfDqT xdZb0hbHdjxisri8aw6bxa/lRxkd2Dw2repk83i/7yqbR9OpdlaPz5vkAlii3GwyUhNTUosU UvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc4B6spG+X4JZxaRJH wWn2iqOXTjM1MHazdTFyckgImEh8+7CVBcIWk7hwbz1QnItDSGA1o8S01xtYIJyvjBI37jYz g1SxCVhJTGxfxQhiiwjISlyZ9pARpIhZYD+jxPwDj9lBEsIC3hI//h0Ga2ARUJX4ueMjWAOv gKbE/ifXwWxRAS+JLfvamUBsTgFTiTnv/oHZQgLFEvNm72eFqBeU+DH5Hth5zALyEvv2T2WF sLUk1u88zjSBUWAWkrJZSMpmISlbwMi8ipErtaA4Nz232KjAaBMjMGa2HdYK2MHYdC76EKMA B6MSD69ElUikEGtiWXFl7iFGCQ5mJRFelVKgEG9KYmVValF+fFFpTmrxIUZToJcmMkuJJucD 4zmvJN7QxNLIxMDMzNDIwNhMSZx3QuCXCCGB9MSS1OzU1ILUIpg+Jg5OqQbGeOZaRmVRj9Nu rpdF551/mRy0oOlvVtvUrI93os0VjO7dlbpcdV1ZxiFXMjQwsvC41z7X1DbZhQuTurpmKjlY TlSXXO/50X6V+sHDm592n9oi/e671+MnaxpZnvjlLJkaqOPJrO7k2d+6csZbyQzz+E2/H23x mRNz8NVEBlcWReaTzaqhroVKLMUZiYZazEXFiQBFV2nIrwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170511150136epcas5p4549f5ae51303ef506c0f7f91b5dd1317 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170511150136epcas5p4549f5ae51303ef506c0f7f91b5dd1317 X-RootMTR: 20170511150136epcas5p4549f5ae51303ef506c0f7f91b5dd1317 References: <20170428215334.GH22354@htj.duckdns.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, April 28, 2017 05:53:34 PM Tejun Heo wrote: > Hello, > > On Tue, Apr 18, 2017 at 10:00:37PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Tue, 18 Apr 2017 21:54:32 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > Hmmm, allocs -> callocs. Are these actually beneficial? If so, why? > Because one multiplication is rolled into the call? Each conversion (i.e. I tried the one from patch #1) seems to add an extra 24 bytes to the resulting code size (using gcc 4.8.4 for ARM32 cross-compilation) so I don't see much point in the automatic conversions. Only instances containing size calculations with real possibility for integer overflows should be converted and the patchset under discussion contains no such instances. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics