From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Kevin Mitchell <kevmitch@arista.com>
Cc: Petr Mladek <pmladek@suse.com>,
Jani Nikula <jani.nikula@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
John Ogness <john.ogness@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ryo Takakura <takakura@valinux.co.jp>,
Joel Granados <joel.granados@kernel.org>,
Jocelyn Falempe <jfalempe@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk/panic: deduplicate backtrace on PANIC_PRINT_ALL_CPU_BT
Date: Thu, 1 May 2025 18:51:19 -0300 [thread overview]
Message-ID: <342e81f3-cd5c-0220-8327-3904f2ebf401@igalia.com> (raw)
In-Reply-To: <20250423202620.1686446-1-kevmitch@arista.com>
On 23/04/2025 17:26, Kevin Mitchell wrote:
> On panic, the backtrace of the panicking CPU will be printed either from
> within panic() itself or by the oops handling. Previously, when
> PANIC_PRINT_ALL_CPU_BT was enabled, the backtrace of the panicking CPU
> would be printed again.
>
> To avoid cluttering up the crash log or console with this redundant
> information, this commit omits the panicking CPU from the all-cpu
> backtrace printed by panic_printk=PANIC_PRINT_ALL_CPU_BT.
>
> Signed-off-by: Kevin Mitchell <kevmitch@arista.com>
> ---
> kernel/panic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Makes total sense - thanks for the improvement!
Feel free to add my:
Reviewed-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Cheers!
prev parent reply other threads:[~2025-05-01 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 20:26 Kevin Mitchell
2025-04-24 9:23 ` Petr Mladek
2025-05-01 21:51 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=342e81f3-cd5c-0220-8327-3904f2ebf401@igalia.com \
--to=gpiccoli@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jfalempe@redhat.com \
--cc=joel.granados@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=kevmitch@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=takakura@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®