From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78DD92BE042 for ; Tue, 8 Jul 2025 15:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751988569; cv=none; b=m1dYz6ujn4hRl6ky/PDgHMeOyAnKVusKP5RYyE4KsR5Kpg7Rg2dRrsmhvB1I357VbSY3ws7a8miA7wDJnx6HxTaJzLtI2FMxOXwLLteavgt3pg3Hl1QBpohLa9EKvDVXTyEc4pmvgI9SRCZe1OpCWZG5sKOsEVeloWtpHKTIneQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751988569; c=relaxed/simple; bh=DMoeAamdcn4x2vujQ/emwPNfhc2+DVpLF/Qy0VyrneI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JE5D68rSqyIr3gz6oH5ZuiAYsvpah6vgedIK16Qrc1KiETBOXRQbfIincsfGGlwagKlZ/zI6Mn+OuwQf08SA3PC7B8ArIQAYjqiugIvbjV4YiRtLPUlNIIJhj2AUd44Bo4XXc1hXRicJm3vh9qU2xPLREQtBBP/RooFfx/Y6rNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KZMF/42S; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KZMF/42S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751988566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qOTqGscz0IC329Fs7upIc9zkrTfsj/JtLQXQ3TvYX/s=; b=KZMF/42SEapufmqMDQG90XFTPnObwtNIQ+HRyPpi/fFI+qYwZa7Ba3ii+S5QoF0ATB6klE ad7bu6C6TBWqVe1FS1Wnnn0G4x++N22RGb2Zq44O6cNU/P6d6gZcjVzUuCtLNuElERhabZ fJL4Hpn7QB0XfE+hijA76aDT9813PH0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-DMM3gD-HN6uBi8y7opY1OA-1; Tue, 08 Jul 2025 11:29:25 -0400 X-MC-Unique: DMM3gD-HN6uBi8y7opY1OA-1 X-Mimecast-MFC-AGG-ID: DMM3gD-HN6uBi8y7opY1OA_1751988564 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45311704d1fso30015005e9.1 for ; Tue, 08 Jul 2025 08:29:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751988564; x=1752593364; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qOTqGscz0IC329Fs7upIc9zkrTfsj/JtLQXQ3TvYX/s=; b=WWTz6BNHLHGGiyCwgbkNv+81butEi/oVUAS8wnIMnT9jZA4WDuV1s9DWh+netmNXN6 wKTt5C3paVz8nSO0bY/unE0xXyJDkzyRF07LxdvjwNHMe8hqH+HxuUXH1gART/EyKl9U rFViVqrQ3EhTXH4rPnkeqPfuH03r1HAdDe8eOyY/jLyYH04FviuWs0Y8uHkZyMS5HN3F K286ZYeiRAB71cwfROp9Dut6nu6be1dps1njrzqm0dnFQaHnMn3NGXe5lYTUO5Mv5hTB TosSnRaIIJdAX6NrWOQd18aak9ZfukvLCJAazvdUTcJdnqamKNEoF8F6D7oiH10Onrey cQwQ== X-Forwarded-Encrypted: i=1; AJvYcCU/iD22kymIzR2pa87W6ErQN0ozMMtOD9Sm+JSXVhbCb62S0F+2mvy8ZIAcMAOTeJJpWVWyRUngF6RWvDs=@vger.kernel.org X-Gm-Message-State: AOJu0YwPy3C8KASMGuY7/nCDQ47EcJg923pWure2sH29erIiE/fcI+1k 4YKGVxEep/q3JVgcfjtyNDVigYjGbBuH8Ma+iVvKeeUxPeXQoecLQGZwSyMsdXpbyon4/oHnUV1 Q4kQuXX0uVCkKA21RnlFOBL/2a8zjPJHWw6L4Fk22eMayG37IA2J5wfHNnkrT84YA5w== X-Gm-Gg: ASbGncuiaC73Vltgl/55E4Ibyd3VV9lGbj2MNve0/o3Px8fHotDbEi9+ojyH+GphVDL UZbe04P+HKDAJSZUZLy4+5uB22iYBTAj9kZhNCwS66BqLethp+QrCZnTMUvwiuBy7EeQQogEpDO IYqDRxIpRLfx+aJJOhlB/HbAZTrgwnMz1fWfo3h1rH8+RC2vGMoIs4i9kX3dX6G7MhBP+T6tnHK QIv7DLEwJChdKWOqg0Wpu4KjdBUtlnv9+jjTT8VVglZ8ZL1eFNX7j2yqYL5L47cyc9eUBcg5/wd h6y3N7GzXuhLZACYmYi+4JB/U/mmzKLw6TIwvDatGhGoCylywQIZrC2QWlWBV0ddZ8e9UoHeb2r U4MF0C0hsUgGRUeVIOPJ1BMYVl+oOwdrVSOx72sfp0pd6TQ+ipA== X-Received: by 2002:a05:6000:40df:b0:3a3:7987:945f with SMTP id ffacd0b85a97d-3b4964ee23emr14743241f8f.57.1751988563855; Tue, 08 Jul 2025 08:29:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5Jx/p06W6BywwUvOMVKdLhp4+iHVWE6JG/qR6+y2wcBz0eHTjdPBuqN/ZiA8hpRlzl534Xw== X-Received: by 2002:a05:6000:40df:b0:3a3:7987:945f with SMTP id ffacd0b85a97d-3b4964ee23emr14743210f8f.57.1751988563395; Tue, 08 Jul 2025 08:29:23 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:f500:4346:f17c:2bde:808c? (p200300d82f1af5004346f17c2bde808c.dip0.t-ipconnect.de. [2003:d8:2f1a:f500:4346:f17c:2bde:808c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454cd3d2656sm25392275e9.21.2025.07.08.08.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 08:29:22 -0700 (PDT) Message-ID: <34344793-128c-445b-9ef4-853c98f3d5a8@redhat.com> Date: Tue, 8 Jul 2025 17:29:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] selftests/mm: Fix UFFDIO_API usage with proper two-step feature negotiation To: Li Wang , akpm@linux-foundation.org, peterx@redhat.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Nadav Amit , Aruna Ramakrishna , Bagas Sanjaya , Catalin Marinas , Dave Hansen , Joey Gouly , Johannes Weiner , Keith Lucas , Ryan Roberts , Shuah Khan References: <20250625004645.400520-1-liwang@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250625004645.400520-1-liwang@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Key changes: > > 1. Use features=0 in the initial UFFDIO_API call to query supported > feature bits, rather than immediately requesting WP support. > > 2. Skip the test gracefully if: > - UFFDIO_API fails with EINVAL (e.g. unsupported API version), or > - UFFD_FEATURE_PAGEFAULT_FLAG_WP is not advertised by the kernel. > > 3. Close the initial userfaultfd and create a new one before enabling > the required feature, since UFFDIO_API can only be called once per fd. > > 4. Improve diagnostics by distinguishing between expected and unexpected > failures, using strerror() to report errors. > > This ensures the test behaves correctly across a wider range of kernel > versions and configurations, while preserving the intended behavior on > kernels that support UFFD-WP. > > Suggestted-by: David Hildenbrand Skimming over this once again ... sorry. Nit: "Suggested-by:" Likely Andrew can fix it up ... if the patch is not upstream yet (did not check). -- Cheers, David / dhildenb