mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sven Peter" <sven@svenpeter.dev>
To: "Fabio Aiuto" <fabioaiuto83@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Felipe Balbi" <balbi@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>, "hch@lst.de" <hch@lst.de>,
	hdegoede@redhat.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: leave default DMA for PCI devices
Date: Sun, 14 Nov 2021 12:56:02 +0100	[thread overview]
Message-ID: <34347fd8-1d67-4d16-b09f-061bc0c0cb5a@www.fastmail.com> (raw)
In-Reply-To: <20211113142959.27191-1-fabioaiuto83@gmail.com>

On Sat, Nov 13, 2021, at 15:29, Fabio Aiuto wrote:
> in case of a PCI dwc3 controller, leave the default DMA
> mask. Calling of a 64 bit DMA mask breaks the driver on
> cherrytrail based tablets like Cyberbook T116.
>
> Fixes: 45d39448b4d0 ("usb: dwc3: support 64 bit DMA in platform driver")
> Reported-by: Hans De Goede <hdegoede@redhat.com>
> Tested-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
>  drivers/usb/dwc3/core.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 643239d7d370..f4c09951b517 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1594,9 +1594,11 @@ static int dwc3_probe(struct platform_device *pdev)
> 
>  	dwc3_get_properties(dwc);
> 
> -	ret = dma_set_mask_and_coherent(dwc->sysdev, DMA_BIT_MASK(64));
> -	if (ret)
> -		return ret;
> +	if (!dwc->sysdev_is_parent) {


Are you sure it's the dwc3 controller that limits DMA to 32 bit addresses and
not the PCI bus itself?
I also think the xhci driver will call dma_set_mask_and_coherent again
later on when dwc3 is used in host mode.



Sven

  reply	other threads:[~2021-11-14 11:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 14:29 Fabio Aiuto
2021-11-14 11:56 ` Sven Peter [this message]
2021-11-14 13:42   ` Hans de Goede
2021-11-14 16:11   ` Fabio Aiuto
2021-11-14 20:58 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34347fd8-1d67-4d16-b09f-061bc0c0cb5a@www.fastmail.com \
    --to=sven@svenpeter.dev \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®