From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07D172FD7D3 for ; Tue, 31 Mar 2026 18:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774983551; cv=none; b=DoBPExSkkHDQNWE/rIiv3T+4HappBHHbzIZbEDSzeVafuihA375BendCCUcDwYSdbY30K+1zcE4+ryNEDSUYodKCKaNOmyD1s8Yav/mf54FCJyI6IzF7XB9xAaYY1FgHUsokX4rFXOInKi+E1V+palaMJRxFQBRp6rNIntuNeBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774983551; c=relaxed/simple; bh=l1cH7gYvlcc0lSooMVlOy/K8fFgRGPMUfDne5EcSqdw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QmsSp8VT/XUCFk+aBr8pBDzGtLzT/FTaVG4b3z7j0qQYxNNbCfovivwHQcJuTQJs6D8qrbX8gUv3o9bgzpmdb4q3C4XIuuMhxq0yAoJaJRIlH/fBZcnUnIqzveX9cuWQ5d0bEVfAbByEihKiYu551WmQQPc2dDIjsB9rSk2HdwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HbSK3R5g; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HbSK3R5g" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso5387717eec.1 for ; Tue, 31 Mar 2026 11:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774983549; x=1775588349; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=twlo6aN4ZIIizkV5asPjuWxWSEYhM+jPy1SPudDCUoI=; b=HbSK3R5gD9d/Fq2ihig09b77i+9HS2EDuIAtB+U7QbEwwvREO+5vbeOto0YPXenQsD nMQ552ktCFrjjBkTsYJQNVv40pCpTVcXXj/k+HXmwQ8M+NfousVDrRL/s9NGfVSZAvms cwjnvUr3p8zeG5aoQnTpLqYd2dPpIztW1Xmj9SivGNyQqo6g9qusl2Ehvu5JvkPRE5Yd VbuA9tGHT1wnnQK+HhLPLIEXxwUR2PXRYdqebEHE+u66oeQL0fp2+VCG3RrlbifcqkoM BDz72qV0Z+xNHa5zGSDeXyZZvv4sZC1TB7lHWCBAIT5+nUvz62oy8TA77PLR0AC3q0s8 hsEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774983549; x=1775588349; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=twlo6aN4ZIIizkV5asPjuWxWSEYhM+jPy1SPudDCUoI=; b=jPKQ156HAb9uZeUwFL05xkDSQNA84jJWueJdDfYvSoq9pJDfprA5tKgBiu7HZ5p6jw p9rH1SZkAwM1o+DzmoW+P7kbEOLHGvIWP/o7dhxjSseTwgUuF4Aet17yb/hWxh+6rqSg uWKszF4/lpQ8zv2buoRf0H+BEi2jdGJADzcJebde52Ju/4ja0cmok/QT+YR6YpA+IUae OwJ3V8HeEswDUaKxEvQd2MzZJuIkp+QcDjzOaJhna2BS5zPVZbIhixZV9u4CCVnS96pZ lCHQo9J8X424bPZn7dae8CE3WlFoADxIRdLZ3SgSpdd7okh74xyRJMz0eyIy2pJUrcbF E03w== X-Forwarded-Encrypted: i=1; AJvYcCWrJ7mIFN7XNiuqppZDxGgsDWd9U8ugKSwmoqLyjZl5hbUDh1f2azAX2S/DkHgAGe0Zfiuh0IwbwU6Lv8U=@vger.kernel.org X-Gm-Message-State: AOJu0YykbbECBFf02gADwNw+fXpz1eCX0ASpbXGZPDxEwwikKA/LOXHo +ljbfyNUlESNmoL8W9E2+wrgmNCT6k1j1PvVCQAfCsNP9f+3H2HTn5Yy X-Gm-Gg: ATEYQzyDNHZGuVKKIwZhcCpYQ/z9mVRQ20r6KHcAExhl1RPu4hdx8GpkPuPLFMob6TP ZxcC93l30i6B2M8KopQBSEzLleqPkv16AsOQBuh0EGVoscvLmLakmmi5Fjw9R3vSnwqD0G9w2pS PGCKQGSk9y0Po6FHY2Czl6sQMVa5SXdtWdmPRjxih9jwFvHgnyXm7qt0kEF06k+v8qAoCDUccoZ cryIkGb3Qxon+hJVioW1kmJrQ0JOhIOUg8H+lM+mhzcktue4ZNZZ12fhMPYKcTv0hKKctU/KsQ+ npiKXD2/T5WNCc8tc6qxOnNUpIl4n+x/lCWbmPj6N6BFewZiu3LXIC9ksBXIy6cpKnYtYrz9P8U F2oPL1fmLyQbn4VNVKlhz9oul4AgABFiRLm4zr9NNDEQU4bLRR3M62Z2tFNykGTlyxnt/qj+BWM FQTYQEET2gMC+SJ6zQJPVAtxgwbDYY7saNNEO0AuSLanImEQNsFbdIRMeDxb+kq/bwJvjUY5Pzt ffjiQ== X-Received: by 2002:a05:7300:2213:b0:2c5:220c:5670 with SMTP id 5a478bee46e88-2c93078fc9dmr270392eec.2.1774983548956; Tue, 31 Mar 2026 11:59:08 -0700 (PDT) Received: from [192.168.68.65] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c68b2c57sm11411406eec.16.2026.03.31.11.59.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 11:59:08 -0700 (PDT) Message-ID: <3435895a-ffd9-4dd3-b21a-4466791183ca@gmail.com> Date: Tue, 31 Mar 2026 11:59:07 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash To: Dmitry Baryshkov Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg , Konrad Dybcio References: <20260331-expressatt_camera_flash-v4-0-f1e99f474513@gmail.com> <20260331-expressatt_camera_flash-v4-3-f1e99f474513@gmail.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Dmitry, >> + vreg_flash: regulator-flash { >> + compatible = "regulator-fixed"; >> + regulator-name = "VREG_FLASH_3P3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + gpio = <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + pinctrl-0 = <&flash_led_unlock>; >> + pinctrl-names = "default"; >> + }; >> + >> + led-controller { > It looks like the nodes are not sorted. Could you please make sure that > they are sorted alphanumerically (if there is no node address)? Thanks for your feedback! Could I request this comment/change be noted in https://lore.kernel.org/all/20260331-expressatt_fuel_guage-v1-1-23d1d8526b69@gmail.com/ instead? As this seems to be the only comment remaining, it will be easier for me to reorganize the DTS in the fuel gauge patch series rather than this one, as the fuel gauge patch series depends on this one. It also won't spam others in the mailing list who don't care about the reorganization of the DTS. Thanks, Rudraksha