From: "Agrawal, Akshu" <Akshu.Agrawal@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: djkurtz@chromium.org, Alexander.Deucher@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Dylan Reid <dgreid@chromium.org>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002
Date: Wed, 25 Jul 2018 14:30:04 +0530 [thread overview]
Message-ID: <343d6aa1-0687-a6d3-fb1a-3f1365db1e6a@amd.com> (raw)
In-Reply-To: <20180724171428.GQ13268@sirena.org.uk>
On 7/24/2018 10:44 PM, Mark Brown wrote:
> On Mon, Jul 23, 2018 at 10:56:44AM +0530, Agrawal, Akshu wrote:
>
>> This approach shows inconsistencies and in some boot cycles da7219 fails
>> to get regulator. Form the logs (below) it shows time gap between the
>> time we call “platform_device_register(&acp_da7219_regulator);” and when
>> the regulator actually gets registered.
>
> This hack isn't going to help with that AFAICT, you're still registering
> a platform device and relying on it appearing in time? It just
> registers less often.
Yes, I agree and by "this approach" I also meant registering platform
device and waiting for its probe to happen.
Instead of adding a platform device to the reg-fixed-voltage, we can
register a regulator and thus not wait for the probe to occur.
Pushing a v2 with this change which has consistent behavior.
Thanks,
Akshu
prev parent reply other threads:[~2018-07-25 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 6:38 Akshu Agrawal
2018-07-20 12:18 ` Mark Brown
2018-07-23 5:26 ` Agrawal, Akshu
2018-07-24 17:14 ` Mark Brown
2018-07-25 9:00 ` Agrawal, Akshu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=343d6aa1-0687-a6d3-fb1a-3f1365db1e6a@amd.com \
--to=akshu.agrawal@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dgreid@chromium.org \
--cc=djkurtz@chromium.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®