From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16643C433FE for ; Thu, 10 Feb 2022 17:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240077AbiBJRaf (ORCPT ); Thu, 10 Feb 2022 12:30:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbiBJRad (ORCPT ); Thu, 10 Feb 2022 12:30:33 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6554E260F for ; Thu, 10 Feb 2022 09:30:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644514232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ipC35w792dvxJk0OyBY7gcESXN0lGemMDfsvs+ruGts=; b=PgZS2bo76IOXJ8difk7giJt3uSk9LdmCy/+A1RhRkA0wsWyfdEFOSsQELauOYjNIkLQw21 0YJSzDEukXbzrNYb08R1z/GVH/lODYZtfyN32ZV5fx6aAAkLOG50rSqQ1+WThqWKJdnJvr su56TS3SvDetOAMbKPTCyKbLQU5b8VQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-3ug5Tgv3P82XFatp9croVg-1; Thu, 10 Feb 2022 12:30:31 -0500 X-MC-Unique: 3ug5Tgv3P82XFatp9croVg-1 Received: by mail-ej1-f72.google.com with SMTP id v2-20020a170906292200b006a94a27f903so3077355ejd.8 for ; Thu, 10 Feb 2022 09:30:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ipC35w792dvxJk0OyBY7gcESXN0lGemMDfsvs+ruGts=; b=q5AsAtkO5e0W3sQ9nQRcSSGSgq+3RMc9ztlWdY6fFUmt0KpayVbIeT1orYhMm5ek3k gq70KrBmRjFFNl5GbVl7E1cTUoNgOrYmrhnlhmXacJKwZrMit1UpcIiIS2Qxb47+gjJs c1ZCJwoZixIrCs/WkFHX2Ol52oDw/KyaaSBCi6Mwepb96NTuCHKla8cqNpK6nqGC5vFV x/Ms5W0wJL6AiQRz9iBT1/xCsMbpg0ioYjYwxb4x49hp94SncruM499E0g6Osk9n9czc wlG4l2dod+8oJNJWLMkc9oz+NmqyyOBPBLITJUElY1xos9dfbEnzPtRx7CXhJtJ/yblP n34A== X-Gm-Message-State: AOAM5312Lt6mMY7J/A2sXcHQF4wsBJOUY704S9/1D29JU59l9kFKV4mU IAaSr9REbIQVIfvuJokGZIYGOhCJQ4fV1rtSQp1gESOWTl8IiuynQnFF7I8s1NlYC9yK8Nj0Wp/ cmSoPdkKwqQj4qUMZitILajPn X-Received: by 2002:a05:6402:2708:: with SMTP id y8mr9445645edd.409.1644514229899; Thu, 10 Feb 2022 09:30:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+5gAesk8y5CJUhwsjQvRSPjVku04l37Bvzlnqcvt9dX9PJwsr+KeQ7sLPZ30dz1n51krz+w== X-Received: by 2002:a05:6402:2708:: with SMTP id y8mr9445622edd.409.1644514229627; Thu, 10 Feb 2022 09:30:29 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id yz13sm5164078ejb.209.2022.02.10.09.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 09:30:28 -0800 (PST) Message-ID: <344042cf-099e-5e26-026a-c42d0825488e@redhat.com> Date: Thu, 10 Feb 2022 18:30:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 00/23] KVM: MMU: MMU role refactoring Content-Language: en-US To: Sean Christopherson Cc: David Matlack , LKML , kvm list , Vitaly Kuznetsov References: <20220204115718.14934-1-pbonzini@redhat.com> <40930834-8f54-4701-d3ec-f8287bc1333f@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 17:55, Sean Christopherson wrote: >> union kvm_mmu_page_role root_role; >> union kvm_mmu_paging_mode cpu_mode; > > I'd prefer to not use "paging mode", the SDM uses that terminology to refer to > the four paging modes. My expectation given the name is that the union would > track only CR0.PG, EFER.LME, CR4.PAE, and CR4.PSE[*]. Yeah, I had started with kvm_mmu_paging_flags, but cpu_flags was an even worse method than kvm_mmu_paging_mode. Anyway, now that I have done _some_ replacement, it's a matter of sed -i on the patch files once you or someone else come up with a good moniker. I take it that "root_role" passed your filter successfully. Paolo > I'm out of ideas at the moment, I'll keep chewing on this while reviewing... > > [*] Someone at Intel rewrote the SDM and eliminated Mode B, a.k.a. PSE 36-bit > physical paging, it's now just part of "32-bit paging". But 5-level paging is > considered it's own paging mode?!?! Lame. I guess they really want to have > exactly four paging modes...