From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753148AbdGXHcK (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 03:32:10 -0400
Received: from www381.your-server.de ([78.46.137.84]:39299 "EHLO
        www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752817AbdGXHb4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 03:31:56 -0400
Subject: Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator
 framework
To: Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <marc.zyngier@arm.com>, Jonathan Corbet <corbet@lwn.net>,
        Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
        Jonathan Cameron <jic23@kernel.org>
References: <1500466814-32679-1-git-send-email-brgl@bgdev.pl>
 <1500466814-32679-2-git-send-email-brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-doc@vger.kernel.org
From: Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <3444eb00-4097-9776-2e40-e19db6be5ab3@metafoo.de>
Date: Mon, 24 Jul 2017 09:31:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1500466814-32679-2-git-send-email-brgl@bgdev.pl>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Authenticated-Sender: lars@metafoo.de
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/19/2017 02:20 PM, Bartosz Golaszewski wrote:
[...]
> +void irq_sim_fini(struct irq_sim *sim)
> +{

Not very likely to happen in practice, but for correctness we should
probably put a irq_work_sync() here for each of the IRQs to make sure that
the memory associated with the irq_sim_work_ctx struct is no longer accessed
and that handle_simple_irq() is not called after irq_free_descs().


> +	irq_free_descs(sim->irq_base, sim->irq_count);
> +	kfree(sim->irqs);
> +}
> +EXPORT_SYMBOL_GPL(irq_sim_fini);