From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH v3] MIPS: loongson32: Remove dma.h and nand.h
Date: Wed, 30 Aug 2023 23:11:23 +0200 [thread overview]
Message-ID: <34466e53-9cab-4094-7a9e-ae1f65385194@linaro.org> (raw)
In-Reply-To: <20230830133505.505597-1-keguang.zhang@gmail.com>
On 30/8/23 15:35, Keguang Zhang wrote:
> Since commit 7b3415f581c7 ("MIPS: Loongson32: Remove
> unused platform devices"), struct plat_ls1x_dma and plat_ls1x_nand
> are unused. Then, dma.h and nand.h are useless.
> Therefore, remove these useless header files.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> V2 -> V3: Fix the build error
> Add Reviewed-by tag from Philippe Mathieu-Daudé
> V1 -> V2: Remove include of dma.h and nand.h
> Update the commit message
> ---
> arch/mips/include/asm/mach-loongson32/dma.h | 21 ---------------
> arch/mips/include/asm/mach-loongson32/nand.h | 26 -------------------
> .../include/asm/mach-loongson32/platform.h | 3 ---
> arch/mips/loongson32/common/platform.c | 2 --
> arch/mips/loongson32/ls1b/board.c | 2 --
> 5 files changed, 54 deletions(-)
> delete mode 100644 arch/mips/include/asm/mach-loongson32/dma.h
> delete mode 100644 arch/mips/include/asm/mach-loongson32/nand.h
> diff --git a/arch/mips/include/asm/mach-loongson32/platform.h b/arch/mips/include/asm/mach-loongson32/platform.h
> index 2cdcfb5f6012..f74292b13bc3 100644
> --- a/arch/mips/include/asm/mach-loongson32/platform.h
> +++ b/arch/mips/include/asm/mach-loongson32/platform.h
> @@ -8,9 +8,6 @@
>
> #include <linux/platform_device.h>
>
> -#include <dma.h>
> -#include <nand.h>
Doh I missed that one in v2 :/
Thanks, R-b stands.
next prev parent reply other threads:[~2023-08-30 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 13:35 Keguang Zhang
2023-08-30 21:11 ` Philippe Mathieu-Daudé [this message]
2023-10-06 8:21 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34466e53-9cab-4094-7a9e-ae1f65385194@linaro.org \
--to=philmd@linaro.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®