mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan-Simon Moeller <dl9pf@gmx.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	llvmlinux@lists.linuxfoundation.org, behanw@converseincode.com
Subject: Re: [PATCH] Make alignment cflags configurable.
Date: Thu, 13 Aug 2015 00:30:19 +0200	[thread overview]
Message-ID: <3447724.z50aeuJHce@aragorn.auenland.lan> (raw)
In-Reply-To: <1439383844.3100.81.camel@infradead.org>

Hi all!

> You could mention that this is to fix the clang build. But why is it
> needed? It isn't that clang just doesn't accept the option, is it?
> Otherwise we could just use $(call cc-option, -falign-jumps=1) etc.

Yes it is to fix the build with clang. 
I tried cc-option, but it does not improve the situation (more below).
This is  why I chose the config option approach in the patch.

 
> Did you get to the bottom of the clang failure here? Just turning this
> off without a coherent explanation doesn't seem like the right thing to
> do.

I know it is not the final solution which is why I turned it into a config 
option. We can still debate if default should be "y" or "n". This way we all 
can proceed.

@Ingo: would it be fine if we wrap it into a config option defaulting to "y" ?


What I can say so far is that although clang warns about the unknown option
and ignores it, the resulting kernel still fails to boot somewhere early in 
start_kernel(). I'm still investigating. 

My current trace ends like this:
page_address_init ~ setup_arch ~ then arch/x86/kernel/setup.c:898
setup.c:898 is a printk actually ... 
early_idt_handler_array[i]  ~> early_idt_handler_common

The mail thread is here:
http://lists.linuxfoundation.org/pipermail/llvmlinux/2015-August/001276.html


<wild guess>
We still build with -no-integrated-as which means we use gas. Maybe the flag
is passed-on there and things get confused. 
</wile guess>

Best,
Jan-Simon

  reply	other threads:[~2015-08-12 22:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 12:32 dl9pf
2015-08-12 12:50 ` David Woodhouse
2015-08-12 22:30   ` Jan-Simon Moeller [this message]
2015-08-12 22:37     ` H. Peter Anvin
2015-08-12 23:17       ` [llvmlinux] " Jan-Simon Moeller
2015-08-12 23:37         ` David Woodhouse
2015-08-12 23:59           ` Jan-Simon Moeller
2015-08-13  0:05             ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3447724.z50aeuJHce@aragorn.auenland.lan \
    --to=dl9pf@gmx.de \
    --cc=behanw@converseincode.com \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvmlinux@lists.linuxfoundation.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®