From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2122.outbound.protection.outlook.com [40.107.236.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 357A21D5ACD for ; Mon, 6 Jan 2025 02:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.122 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736130759; cv=fail; b=jmR6Ph9/Mtr72r+N+/Kgd2H1ITyIN1tZhBIORcLrWEBgHLNGIpeywkGKmnaUOka8dBdUnhv58Qmm4JaaqNdqZbk2sECBThLCAZALiGcCXtdulsJ/9aZpl/yyPQdBCrEq7paJokIuPOJGCedJHhgrwaX2fWtjicjQ89G9cmlNzhs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736130759; c=relaxed/simple; bh=jCfzV+WUvLu+xjqyQT3RY4MZ1bISCI+buG+V9OGVgP4=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=jjqkommsdVXO4Eymyl+PJSEr0Mq58+lKE5QaZDhwU67FzG07LGfWAO9F1fwMzyqm1q1EUh9P+UfoPHuhBfl/UopQLLwqyuO06FUBgvJw2YucyVyqlljogRQkBjCc0Mc6ra7fCdZAS6pmCeagPmjtc5YJ0oq60stkM0RxAt7zvVY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=aMIDFxwx; arc=fail smtp.client-ip=40.107.236.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="aMIDFxwx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a38q641Zf7GE5gENqZCN/Tgoy6cKxFFlvxyvU9cM/6bBlYj+UUdlztu3Mh9TMAjCptty+WpETrczJ8UKJesnf9GbM8bYMOcWbE5GngF2uMIptgyfwsuDYQJqiiID1zX3Ze004l3Ixu56fWsmHzIqkYBDn36ZhAyRKSWM1U4W8SikOSG8pWoUsh2Grdo46tgMEj/HNfR4dQZOJhyu0BoN4JhLM3pEC9Hi6OuBurqAcuSm45gxiog8CqNT/XuS1qwau+OADFVuvtddFJCGkkQ7AMU4pDChAJ5qEHw2dkWqJKVAJZMz86HShEbpBeuqtHs956ExBgAuO1rfkItc01OMjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ZU7m+Fv2jqAAP5/4ZfABtKZmW9/waOAw+dLFtVtYyM=; b=sZF+82aZItIQ25LhAP6/yvOWG7ghsBcXEJv1p6zu93cfXkHCDMHdXx+JQ1Y6y+q4y4m539msk/W41oX9nGV9ShBo5nR3iQ1hd5ZFoVnOVFRwEp8h6XR6subkqojQdpGjU+YILNOYODUQeSKgj2Ga/5wOChF7g7I0WsbetebNWqMTZyRRUNrFuNvU6bmdV7+eA47JWOXR+jMujl7DJ9tj1CCyVZi+Cl1XYjJvBrWItfkEQGEbJeykJHZ5re5seF2NyO9LC927mfwb+UkqY88bzlV1C4DQOoMoLBAohzKZXAefzz1ZgkAgOx82FJgyVxfXpSf2Bk1n0ZeP/g9CbjGpXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ZU7m+Fv2jqAAP5/4ZfABtKZmW9/waOAw+dLFtVtYyM=; b=aMIDFxwxfkvOcs9vyXdSoZkahg5CZUGpXZvuj49Yfyc/nqW9+D+yCzDLGW1b5KzN24QJyF5uHkW8zDSG2ZGAiRJCkjsepwbPgZjmikAZGapTZlrcdFDQi+KSzpejbjetFQwCZLqtx8SAwmn9VILq01oXmPfN4933ATyPrq2AKM8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SJ2PR01MB8193.prod.exchangelabs.com (2603:10b6:a03:4f6::15) by BL1PR01MB7554.prod.exchangelabs.com (2603:10b6:208:385::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.8; Mon, 6 Jan 2025 02:32:30 +0000 Received: from SJ2PR01MB8193.prod.exchangelabs.com ([fe80::4167:3f60:16af:411d]) by SJ2PR01MB8193.prod.exchangelabs.com ([fe80::4167:3f60:16af:411d%4]) with mapi id 15.20.8335.007; Mon, 6 Jan 2025 02:32:30 +0000 Message-ID: <344a5d68-bcb5-46c1-ba58-8cd95c3ac4ee@os.amperecomputing.com> Date: Mon, 6 Jan 2025 09:32:22 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup To: corey@minyard.net Cc: Cosmo Chou , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, cosmo.chou@quantatw.com, potin.lai@quantatw.com, minyard@acm.org References: <20250101165431.2113407-1-chou.cosmo@gmail.com> Content-Language: en-CA From: Quan Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR02CA0054.apcprd02.prod.outlook.com (2603:1096:4:196::13) To SJ2PR01MB8193.prod.exchangelabs.com (2603:10b6:a03:4f6::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8193:EE_|BL1PR01MB7554:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bed3760-e5b6-4496-ba4b-08dd2dfa5e2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dHZTM2NuWU9QTm5DYzhFR00zTVBSSngxRnJKa2NESyttOEd4UlhOUS9ibUpm?= =?utf-8?B?bEhOdUc1bDN3TUQ5OEwwbHNqYVptOEMwL09kSGVYNDJMZ0w2a2FEUWYvMk5h?= =?utf-8?B?STZEam5ubUVhSTZ6cHR0TWl4azdwa1hDdU9HZzhJY09iVU1teStZRkIrc1hp?= =?utf-8?B?TDgzSStHc0pEL1ZWcTIvOTBmSDlpOFhKK3pqNVl2enFLUmRRbisrOThDc0RM?= =?utf-8?B?VGRRNWlibnVENjFTZE1KblBGY2pWblBBNlc0NmloSm5JODBOVGpMcWxUZGVq?= =?utf-8?B?OFlxdkV2S3hKRHR6eSt4K2N5SVhKaTZRV2YxUzBONTJNcG42ZEFZcE1acXNq?= =?utf-8?B?dGxlTzFKNzAyWldtSDRUNzVMZmZPeWJGNVgxUStCNGwzL1VOT3NrOTlRVDZY?= =?utf-8?B?UUZsa2JQeUxMOE5hc05QZUo0dHBWeGtIdzVBeldwcVVoeWZLZElpbnhHa1dl?= =?utf-8?B?VDFOTDhrZmtrOXp6YjVtU2VqK2VvZWIyNytTeVlnMXJNZ3FoSis5aG5RSnd2?= =?utf-8?B?bHNNY2IrNjNoMm55a1ZpeHpWVkt2aWhwWWhWc2NGVHE2cU9yZXNvVUtIQ0dn?= =?utf-8?B?MVhNTWpqSWNQQU5vbDE1bjZ3TFhYZGt0YUR3OXFCVGVvWEd6MmlWdjFtQklX?= =?utf-8?B?NkNKREVkd3d6S04rWnR1aVBPdWVOQkpjNkN6ckV0T3AzeGErSkhHTlNIbFhB?= =?utf-8?B?NlJYWTNPM2lZV09JN2l2QnBPZFhvRlRvc3F3SGxsWjVqdzIvTFd4WkJ4ZTZH?= =?utf-8?B?UytRdTN6Sm9WMEJGWnd4Um5MMGdyYjk5Sk0vV1U5UUNIeE0yRDY4eXpwNHJs?= =?utf-8?B?bTR4bnpuQnVZeFp6SU1JZ0xzQW5KMmk0dkdoWkhmZlJlakhEK3lCRC9Ub21r?= =?utf-8?B?Uk05UjdkNnNsMWxpYTBvZnYrZmxGU0puMTJQR0wzOFpGQ2R6azdyaFFCTUNJ?= =?utf-8?B?S2VwandYUW1iamRqMG1reDVmZFJUdG9CZENWVFYwOE01d3FtaVZxQjMxT2Uy?= =?utf-8?B?QnIzUXBibGF0eFoyMmNVUGwzWUhqTkUzcERqNkNsQ29UUzZ6dEkvNk94MXd4?= =?utf-8?B?d1Nyb1J3U1U2QlV5WVRWcDZPR1RyRkVaZHMwaVdxc1lwWXQxUlRZc2xGWGhB?= =?utf-8?B?ci9IQjJrZHltUXMyVzRZWmp0SE5IbzZDQUdqSkJLR2lPSlVOM01FQ2ExbjMx?= =?utf-8?B?YjJaa25SOTZ0RWVraEhGUGpaRmR4MHdidzcySmFHUHNoQXh5ZFpLZGdWR2du?= =?utf-8?B?MW5YVFQwU1V6QzRXQ0lDKzNOcitIZ0VTNWJwOHJMbGtCR2VJQmtQSkQxWUJ0?= =?utf-8?B?blJpTjhXQTk2QVpDdlJnb0NrVThZQVYxQ2FDbXlIdGVRLzYvUGYzTkZWOTVD?= =?utf-8?B?eHdqeDJ4N1N2OVFsZG03VFBSSUNITkx4TjdjUnRxVnhOWXZTdFFOV3VOdGlV?= =?utf-8?B?dC9HRVFjdGdWbUpZc2FUYVRaT2JEWCtGT1hFZXZNQnFyYXpYODhUSDRzeFNM?= =?utf-8?B?ODJqR2ZsdDJ5eVpBMGFnZUNGWXRLN1BjcDI1OElYWjBwWHg3b0huT29ISzk0?= =?utf-8?B?cXA0cDZjV2hSd2JQMG54UUg2aENuNUFXQkxrUi9zN3NOQUJpYUsxMTREQWJq?= =?utf-8?B?czVXN2NEdCt1amoxR0tVWU16N3RIYVppTEdpSDFXVE56MXFTaTFuRi85VE4z?= =?utf-8?B?K05sdUw0dkJVaTZXZkRiTVc3d0FuUk5CZWs3MjB4ZDhBRldZNzRuNCs4RWMz?= =?utf-8?B?S2FsU1l5T1dRakZjMWZ3YzZIZkEzSGpMOHVWWXBUOVBtLzNBcEVpRXo0eFJm?= =?utf-8?B?UjhqYlhuWEhpcitscWdGWTBXSVZmR0xvNUFvOGJDK003OW5QS1daa0FHZ2Fp?= =?utf-8?Q?IhpWsnVsbHL81?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR01MB8193.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHNzdkxVU25SQjdFMmtzVkRqU2RiekR0eW94OFpvM0w2TWQwRnRGVmtSbGU3?= =?utf-8?B?T1pwamNodjJjZDlLRHFtODk5RHBrUVQzZGF5OGZHMzkvRHd1RnR6QkltN3JR?= =?utf-8?B?am9RU1pncjc1TnI5b1VmaUdBQzF3MkdBSzBLWlJtR3BsNHhCTEZlb1RmQnFH?= =?utf-8?B?YlAzRE9JdWU5dU1YdWdpNmZvYitrd05qL1lhaTRXTXZEaU1zb1hFbkxrSGV2?= =?utf-8?B?VWw2SGdjTFZyekpWa1JLS0pkd2prd0d4VFNTVlBualJ5K0ZpcEdHdnpuMzVR?= =?utf-8?B?bXZwN2lFRFp3Z2JjaGsvTVhWQkFoYzdlTEZXUTlaRzU3K21uOE5FMGxJL0RR?= =?utf-8?B?TGQ4Mkc1QmNpaVFGTFNGK0dmdHZKQ1FXaVlYWFZ5QnpVSW4vY0M4SzY4L3cw?= =?utf-8?B?NXdwRFFaNVFGeTk0cEliWUZjb25FTHJmVEpPVHpPUzFaajYxMFBiWVFFWm1V?= =?utf-8?B?Z2krY1BuWjY1R2hoQUkxY0lZUkMyUytLcWs3cHBvVVQrNTNLaEZEZnB6Y1Zh?= =?utf-8?B?bFpqVTd2azVkZ3Y2a3F6UGYvTWZiYXpqYW1mdU5SYVZNUzhkaXd1dHNDMDI5?= =?utf-8?B?MEFNazE4K2V6eUxPVUczTDJsV1BLbVRtUlhWek5DVDl0SS9DUldWMEVIN3li?= =?utf-8?B?ZTFlSGtHOGhkSGwwdWdUT0FvK1JTS01aaWNKaVFUUlNTMGlpenJSRit6THRS?= =?utf-8?B?Q0dWeGFGRU9aV25PTExibDFMa3dXcHMwZEViS2dBVUxGL3NBcUNHOUFNbFBj?= =?utf-8?B?UWVvVllQL3MrSWtLVUR4MUM3aTFiWmNVYTRsMUd0WTdURThjYlE0eUVDMTdl?= =?utf-8?B?N24zWXByaENhZUNWY2t2OUYxNUdtVXFyS2VKcFZEQjlyZGtBeHcyN3lNZmVJ?= =?utf-8?B?SFgraTVveDlmdy9RTmdPRHpUam9kMVJxZk03RWx1bEJoUnIrVDdnU1g3cG0x?= =?utf-8?B?eisrQVJRQkduRUhTQlAxOXRJMS8zRXlEdlJIWkVRVlR5a3NRd3R6elRmQWw0?= =?utf-8?B?cHFpSlIyOTViMGl1R3JWbktRTDlQWlErRERtUEUzRmRCN29RQ0ZWRzNLMS9j?= =?utf-8?B?bEQ4QWN0UzF5dm1vbjd2T0d3czBqMXNXK3JLRSt0UHlEVGh4clM3b0IrUGtM?= =?utf-8?B?YWc5OTNOc1dkMXRick5mclorVVZWemxlTDkyVG1nUXlqRHQ0bGo5Mnp2Q2x5?= =?utf-8?B?NWt1MFV4YmlWOFVNOW9paFhwUGlqNjQzYmh1eUd6a0szbFZYOU92YnZ3WU94?= =?utf-8?B?UWhtUVJpNnJBQ0xjdWtjT1N3Ynk1REZ4MnlXbXRsNWxiWHNSbWJ2YWhJS2di?= =?utf-8?B?OEpBbUsyQkNmSy9jeXByQytqdWZZSE5CZ1p5Z2x5bmF0UVk4TGdBRVpXRFFU?= =?utf-8?B?K0FSaHRneFZ2TnZOYmNBT3hHZUlram5LNXRyWERKalVoU240SVU3UndEc1pN?= =?utf-8?B?TExqTEc3R3FJYkFubWlma1N2aDByeUhKR2tBTEVUMWJVWDBmUzR0aHVpRnNu?= =?utf-8?B?ZGR3V0trWWs1Z053L0JCY3VMSlJsV2NpV1dkdG9Pa0FaWmRuTTdkT08xai9l?= =?utf-8?B?N3ZIOG10aWJlOXZGaVpRMWZZd29xQWsyNVAxejR1TGRNU3ZHOTZJb1NDQzRL?= =?utf-8?B?Z3cvclc1V3pidVY1UnlTTlpYcjl2MHpha0NhaVpFZm9jY3pyblpHbXlacnVk?= =?utf-8?B?K3JGZEhiRTViSU5UWTRCNEUzbnk2eW15SkFWNk9PSTVIeHNKWktvem1Fcm9o?= =?utf-8?B?T3owRnFiY0F6OGZDZ3RiK1FLZ2I3ZEJmYWRneUorc2o3OW02SHhOaytSd0di?= =?utf-8?B?TUl4WkpqWnBWc3FaU0pnTjB6ZFZORll2R1lpenlvbmV4QVZXMjNKTW9qdEdI?= =?utf-8?B?ZWFSQWFrLzZMZURUc2I5S25kS2NwbXJ1bE5NRTdnRjM3N1NFOG5jTE5YNXhi?= =?utf-8?B?NkFVNFZVdFN5c3YzV3FXVmlCQlhWRlFqa1dkSmFpMjJnWitsS0xiQ3EzZHBu?= =?utf-8?B?UUt1REc1L1ZDdkJ3L2Y4TjdRenU3Y3JmRlRYS21nYjduTENIZG82em1ONzA4?= =?utf-8?B?TnZNcitFRHIzNGwvckJUYmZzM3M3WHpHL0E4UkJORUhqNzduRUZKRnd5Zm4y?= =?utf-8?B?a3orS2JTcDVJc2tFUTNwa211anFyRms3WUVmQXg5b0FBV1pzNUdxNFpOcUd0?= =?utf-8?Q?AJenqRmx3GfVzIShT90tklM=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bed3760-e5b6-4496-ba4b-08dd2dfa5e2c X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8193.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2025 02:32:30.3001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b84ivDfs01Sy0K/sDH1P1sC2iewjW6S8OEV9lwkbCFlrS9QyFkjLJwvS5ekuosztiTP7XWhSNjLpNiyOSWT0S2yUAthnOxKUzLgkFlhrHng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR01MB7554 On 03/01/2025 20:01, Corey Minyard wrote: > On Fri, Jan 03, 2025 at 10:44:46AM +0700, Quan Nguyen wrote: >> >> >> On 01/01/2025 23:54, Cosmo Chou wrote: >>> Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure >>> the new command is not lost when complete_response() is triggered. >>> >> >> Thanks Cosmo for the catch. >> >> And, IMHO, the root cause is the memset() on part buffer called in >> complete_response() is not quite correct. In the current implementation, the >> complete_response() should only be called when the READ is completed, ie: >> only on I2C_SLAVE_STOP of READ transaction, otherwise all the info of >> current on-going request will be mistakenly cleared as in this case. >> >> This patch is good and I wonder if we can make this a bit further as below? > > Yes, this is probably more future proof. > > Can you send me a formal patch, with a "Found-by:" for Cosmo? I'll > replace Cosmo's patch. > Thanks Corey, Will send the formal patch later. Thanks, -- Quan