From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: Mario Limonciello <superm1@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] pinctrl: amd: Fix use of undeclared identifier 'pinctrl_amd_s2idle_dev_ops'
Date: Thu, 10 Apr 2025 13:33:26 +0530 [thread overview]
Message-ID: <344adc8a-6a35-4093-98c1-73f1e6de4eb5@amd.com> (raw)
In-Reply-To: <20250409213521.2218692-1-superm1@kernel.org>
On 4/10/2025 03:05, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> `pinctrl_amd_s2idle_dev_ops` is hidden under both `CONFIG_ACPI` and
> `CONFIG_PM_SLEEP` so the functions that use it need the same scope.
>
> Adjust checks to look for both.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504100420.88UPkUTU-lkp@intel.com/
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Looks good to me.
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
next prev parent reply other threads:[~2025-04-10 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 21:35 Mario Limonciello
2025-04-10 8:03 ` Shyam Sundar S K [this message]
2025-04-10 12:50 ` Rafael J. Wysocki
2025-04-10 20:28 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=344adc8a-6a35-4093-98c1-73f1e6de4eb5@amd.com \
--to=shyam-sundar.s-k@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mario.limonciello@amd.com \
--cc=rjw@rjwysocki.net \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®