From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753947AbbI3RL2 (ORCPT ); Wed, 30 Sep 2015 13:11:28 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:32794 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673AbbI3RL0 (ORCPT ); Wed, 30 Sep 2015 13:11:26 -0400 From: Paul Moore To: Geliang Tang Cc: Stephen Smalley , Eric Paris , James Morris , "Serge E. Hallyn" , selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] selinux: ioctl_has_perm should be static Date: Wed, 30 Sep 2015 13:11:24 -0400 Message-ID: <3451526.pn4qIvD1NX@sifl> User-Agent: KMail/4.14.10 (Linux/4.1.5-gentoo; KDE/4.14.12; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, September 27, 2015 11:10:24 PM Geliang Tang wrote: > Fixes the following sparse warning: > > security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was > not declared. Should it be static? > > Signed-off-by: Geliang Tang > --- > security/selinux/hooks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 84d21f9..5265c74 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file > *file) * Check whether a task has the ioctl permission and cmd > * operation to an inode. > */ > -int ioctl_has_perm(const struct cred *cred, struct file *file, > +static int ioctl_has_perm(const struct cred *cred, struct file *file, > u32 requested, u16 cmd) > { > struct common_audit_data ad; -- paul moore www.paul-moore.com