mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Aniket Limaye <a-limaye@ti.com>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, lianfeng.ouyang@starfivetech.com,
	s-jain1@ti.com, andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add Synopsys DWC_i2c controller
Date: Wed, 11 Nov 2026 13:24:05 +0000	[thread overview]
Message-ID: <34533daa-7eb9-4674-a288-e8d87a8bf29f@sirena.org.uk> (raw)
In-Reply-To: <20261111-smooth-meerkat-of-judgment-dbe8bc@quoll>

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Wed, Nov 11, 2026 at 09:41:40AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Nov 11, 2026 at 12:05:15AM +0000, Mark Brown wrote:

> > I still think we should have a fallback compatible here, while we can't
> > discover the FIFO depths all the uses have a programmed trigger and we
> > know the minimum depth configurable in the IP so we can fall back to
> > using that.  This would be useful for distro kernels, it's one less
> > thing that forces using a kernel with specific SoC support.

> If the driver does not match on such generic compatible - and that's my
> impression from commit msg -  then it is pretty useless.

The driver can match on a generic compatible, it just doesn't right now.
It's getting the FIFO depth from the compatible but as I observe above
the minimum FIFO depth is known so we can just use that as the fallback,
we program the trigger points for the FIFO so it doesn't matter if there
is more space than we're using.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-11-11 13:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 20:35 [PATCH v5 0/2] i2c: Add Synopsys Advanced I2C (DWC_i2c) support for TI TDA54 Aniket Limaye
2026-11-10 20:35 ` [PATCH v5 1/2] dt-bindings: i2c: Add Synopsys DWC_i2c controller Aniket Limaye
2026-11-11  0:05   ` Mark Brown
2026-11-11  8:41     ` Krzysztof Kozlowski
2026-11-11 13:24       ` Mark Brown [this message]
2026-11-10 20:35 ` [PATCH v5 2/2] i2c: Add Synopsys Advanced I2C (DWC_i2c) driver Aniket Limaye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34533daa-7eb9-4674-a288-e8d87a8bf29f@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=a-limaye@ti.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lianfeng.ouyang@starfivetech.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=s-jain1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®