mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Kalle Valo <kvalo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 01/13] dt-bindings: net: wireless: describe the ath12k AHB module
Date: Tue, 4 Feb 2025 11:27:35 +0530	[thread overview]
Message-ID: <345519bb-ba1c-4bcc-a03c-5557f8f40035@quicinc.com> (raw)
In-Reply-To: <aaabcc7a-8234-4753-a8d1-ab36afdafa2e@kernel.org>

On 2/3/2025 3:39 PM, Krzysztof Kozlowski wrote:
> On 03/02/2025 10:05, Raj Kumar Bhagat wrote:
>>
>>>> +    items:
>>>> +      - const: q6-region
>>>> +      - const: m3-dump
>>>> +      - const: q6-caldb
>>>> +      - const: mlo-global-mem
>>>> +
>>>> +  qcom,ath12k-calibration-variant:
>>>> +    $ref: /schemas/types.yaml#/definitions/string
>>> Why this is named after ath12k? Why this is just not
>>> "qcom,calibration-variant"? None of the other properties have ath12k in
>>> their names, so why this one in the WSI schema was named like that?
>>>
>>
>> This property is added after the below comment.
>> https://lore.kernel.org/all/qzjgpwemwaknwbs3dwils6kaa5c3inabfvkaryvc32kblzfhy3@6yduooj4dk63/
>>
>> This `ath12k` in the name of this property is inherited from the 'qcom,ath10k.yaml' and
>> 'qcom,ath11k.yaml'. Same was followed for WSI schema as well.
> 
> They do not have ath12k prefix in the name, so I don't understand.
> 

I meant that, 'qcom,ath10k.yaml' has qcom,ath10k-calibration-variant and
'qcom,ath11k.yaml' has qcom,ath11k-calibration-variant. The same name pattern
has been inherited.

> People, start re-using properties, not creating one per each binding.
> 
>>
>>>> +    description:
>>>> +      String to uniquely identify variant of the calibration data for designs
>>>> +      with colliding bus and device ids
>>> I don't think this property is here possible. How could you have on the
>>> same SoC different devices?
>>
>> The WiFi controller in the SoC includes an internal or external Front-End Module (FEM).
>> These FEMs can vary and require different calibration data. This property uniquely
> 
> 1. So exactly the same SoC package has different FEMs?
> 

Yes, the WiFi component of the same SoC package can have different FEMs.

> 2. How does it exactly work? Different bins? Different revisions?
> 

The calibration board data for different variant are packed into firmware binary 'board-2.bin'.
Thus, board-2.bin can contain multiple board data for various variants. Ath12k driver selects
the correct board data based on the variant. The "qcom,ath12k-calibration-variant" is used
as one of the parameter to select the correct board data from board-2.bin.

> 3. How is it supposed to work in practice - you have one board, but
> might have different SoCs inside? Which calibration data would you use
> in such case?
> 

The SoC in the following statement 'you have one board, but might have different SoCs inside'
, I am assuming SoC to be WiFi controller/component.

Consider, if we have two WiFi (qcom,ipq5332-wifi) controller with different FEM in IPQ5332 board.
Then in the DTS we have two wifi node. Each wifi node in DTS will have different value for
'qcom,ath12k-calibration-variant'. With the help of this property driver will be able to
download the correct calibration board data from board-2.bin.

  reply	other threads:[~2025-02-04  5:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  4:34 [PATCH v5 00/13] wifi: ath12k: add Ath12k AHB driver support for IPQ5332 Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 01/13] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
2025-01-30  8:28   ` Krzysztof Kozlowski
2025-01-30  8:40     ` Krzysztof Kozlowski
2025-02-03  8:43       ` Raj Kumar Bhagat
2025-02-03 10:05         ` Krzysztof Kozlowski
2025-02-03 10:27           ` Raj Kumar Bhagat
2025-02-03  9:05     ` Raj Kumar Bhagat
2025-02-03 10:09       ` Krzysztof Kozlowski
2025-02-04  5:57         ` Raj Kumar Bhagat [this message]
2025-02-04  7:30           ` Krzysztof Kozlowski
2025-01-30 19:07   ` Jeff Johnson
2025-02-03  9:07     ` Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 02/13] wifi: ath12k: fix incorrect CE addresses Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 03/13] wifi: ath12k: refactor ath12k_hw_regs structure Raj Kumar Bhagat
2025-01-30  4:34 ` [PATCH v5 04/13] wifi: ath12k: add ath12k_hw_params for IPQ5332 Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 05/13] wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332 Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 06/13] wifi: ath12k: Add hw_params to remap CE register space for IPQ5332 Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 07/13] wifi: ath12k: add support for fixed QMI firmware memory Raj Kumar Bhagat
2025-01-30  7:46   ` Krzysztof Kozlowski
2025-02-03  9:44     ` Raj Kumar Bhagat
2025-02-03 10:12       ` Krzysztof Kozlowski
2025-02-04  9:06         ` Raj Kumar Bhagat
2025-02-05  9:07           ` Krzysztof Kozlowski
2025-02-05  9:59             ` Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 08/13] wifi: ath12k: add AHB driver support for IPQ5332 Raj Kumar Bhagat
2025-01-30  7:57   ` Krzysztof Kozlowski
2025-02-04 15:45     ` Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 09/13] wifi: ath12k: Power up root PD Raj Kumar Bhagat
2025-01-30  7:58   ` Krzysztof Kozlowski
2025-02-04 16:16     ` Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 10/13] wifi: ath12k: Register various userPD interrupts and save SMEM entries Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 11/13] wifi: ath12k: Power up userPD Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 12/13] wifi: ath12k: Power down userPD Raj Kumar Bhagat
2025-01-30  4:35 ` [PATCH v5 13/13] wifi: ath12k: enable ath12k AHB support Raj Kumar Bhagat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=345519bb-ba1c-4bcc-a03c-5557f8f40035@quicinc.com \
    --to=quic_rajkbhag@quicinc.com \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®