From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757664AbdJQHVj (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 03:21:39 -0400
Received: from mout.web.de ([212.227.15.3]:53772 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754520AbdJQHVh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 03:21:37 -0400
Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function
 implementations
To: Joe Perches <joe@perches.com>, linux-integrity@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        Kenneth Goldman <kgold@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nayna Jain <nayna@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>,
        =?UTF-8?Q?Peter_H=c3=bcwe?= <PeterHuewe@gmx.de>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net>
 <20171016183139.otyh3m5c5yurtmow@linux.intel.com>
 <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com>
 <1508193989.6530.17.camel@perches.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <34574b21-4925-c7f4-0b85-ebe62867c651@users.sourceforge.net>
Date: Tue, 17 Oct 2017 09:20:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508193989.6530.17.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:CJoS3U09HipnQ46PsAChuR1GHU9ezAzIid9fthar2WHypT7J1Nx
 b5F5jtZ/8UNxoVQtT9IZTktjQ2y9YMQKmQXexErQdS4o8qS3oIL6IcZlM2hG68IMor6IH8i
 rtfCpY7Qto7D8kI5L0IEZuSMB9O9EPfxa7uTZcecbT3bVfpgQAx9VfaGgxG20zizZdwlEJB
 GN8gEDJoexJRV0lMaCs4g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:KB3XTolJdTY=:1JD8060uiVCt6s+1oFYzRv
 DRH1kscY606vk22zSQjnelfch5gNq/StP75TdJWTlhBfDTAoA1DplsDUncu2XhueK6l73ecf4
 Jw7Nn19jpZaW9mQkzcwKnOtoO3L4jvvbsSSPyEJI/8aWVBKwWWri2c5uR5U/aTNPwKBIA9fIo
 NT13Ocr4Mvcm99eamJRwztAf4Ock2SvnuCpCA706BqL85T3JeZSQTKtpy0BBZMXL3z3o3iVhs
 DGJoUpHXIxAN9a52d1To1n39a2Af+s4Sc6LD7PycVkjA0zeK3oBrTCBkMz6+DMTdrXdfVlkjB
 pNcDL9V8LUxXTVG41BfL6KlwgBqYDvY7m3fDikYX0zKJRboZ7NBtbFgkbbRmxvllZCwrQAJNV
 bFQtI8ezw0lZJzN+KySn5aMBB6m5RrG+O6C6Cb7hdmjwb5nifajsy1mYqWPNECdCG3ztrcrXW
 4qTtSBe/k17P0bdi+Zag/bLzpMw11gpaqZL52G/Tvr4PGmKoqSZyFi6ljk/MTOuZAnH8TcGUY
 X5M+mqwwZUV+Bqlh67q3/uzVyu34qtt5eKbxw4Lv3q/WeGqsJJ7w0p6ikRsIaGm8C5tW3tivW
 dZyFy0Ws7Z+7kB5ZTB/87CkhGTvxnIWW/q2AWsyyTbMUIwppnUIATF9kVJh7ig4e453Jyjs88
 GqQHmmMSLl7Q/vxNEocjD+IeO+41aRSmvJ7/8DzjpUNQB2GQ9GhIihzBvSj0oZE9JIneP/q3z
 FQ0K0rzsjXtcdMlSML8q8kPmmfiiM4IA1IqKD2PDBBVzTS0VzfFuNbXtx8V1UT5pyR3iPP2yP
 nghMFUPbEaQOJZ16hEKxTotd0LfG4qumyi57zkPk/1YltGpBh4=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> A minor complaint: all commits are missing "Fixes:" tag.
> 
> None of these patches fix anything.

It depends on the view which you prefer.


> All are trivial changes without much of any impact.

I find that they improve the affected software another bit.
Other adjustments can be more noticeable.

Regards,
Markus