From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C20C3D76 for ; Thu, 15 Jan 2026 00:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768436401; cv=none; b=Q8OuxyfCPTwEevtBfabkv1ZcUcxXEh5GyIt3ARAK4TYBUztXWrcqapjvJyl3UtilD475IaxLukAT1bNBTvToG98DoW80/IPr7TPZ/iYPEmHnptuwbD9bichqTr5sAoZ0tZ8INKKkVAf2cr5xl4Ti4Qzd6mVLdmK7+XxvuA3klt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768436401; c=relaxed/simple; bh=2sEhA2J32gRYLjlaKzp2VoItieVdGTof+LBqHBRNaFc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Xik+ysU9CBiqFyDms38Z547gC7UARGjTA2+xRFxselLkk9oYrb0442Aa+WltPPiLJIHOcv3HYr2yo8zHyNBLOgrB4IkArPE91XmA6coLHYeZg6NebBjHmyiDkw+G3lSbJGWFC579hYCS/BWIjRr9ie4QHa3/JFWQQQ1GbFDsPno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i9JITMSu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i9JITMSu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99073C4CEF7; Thu, 15 Jan 2026 00:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768436401; bh=2sEhA2J32gRYLjlaKzp2VoItieVdGTof+LBqHBRNaFc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=i9JITMSuW+iJ2XKztzLyY/cUbvn18pN+iGQyTK1b6uaEVN/sn6oGJK6+KsTqOyltD B8eGPCGUc09KdFq4GahQdX7YPz2tdCVToEOcht+dxEXX8mmDdDSmNfvL7dtS078+gN +rdZHP83ZhxmA0v/n6U8/mJBTn6CRnwwRHf9xJ8OuJ930MgSJmLLFXkLiR6hEL24oh 6BtVqrCvQvC9sWyqdYIRdDk0sGr/yqZw/SXwk3WyybArDwEsaky+FVQU9wMdSns9Mm WcaTPh8A+2zTceO24vMyW8+CSPWq4Vtu9mn6Emn9qjCJ07vwJd1h8l6ndsJ9D1K/b/ xfYZLER9vk7/Q== Date: Wed, 14 Jan 2026 17:19:57 -0700 (MST) From: Paul Walmsley To: Javier Carrasco cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heinrich Schuchardt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: defconfig: enable NLS_ISO8859_1 In-Reply-To: <20260111-nls_iso8859_1_y_riscv-v1-1-2c992bb2c00d@gmail.com> Message-ID: <345da49c-b8b5-8538-6231-c614792c9092@kernel.org> References: <20260111-nls_iso8859_1_y_riscv-v1-1-2c992bb2c00d@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 11 Jan 2026, Javier Carrasco wrote: > NLS_ISO8859_1 was enabled as a module with commit efe1e08bca9a ("riscv: > defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1"), but the > NLS_CODEPAGE_437 counterpart is selected as built-in. The commit does > not explain the reason behind, and it is not consistent with the > defconfig for ARM64 that also enables these modules to mount EFI system > partitions. > > Select NLS_ISO8859_1 as built-in to provide both requirements within the > kernel image. > > Signed-off-by: Javier Carrasco > --- > I stumbled upon this while scripting commands to launch > qemu-system-aarch64 and qemu-system-riscv64 with debian no-cloud images > and -kernel to provide a defconfig kernel in both cases. I expected the > same behavior to mount the EFI partition, but it failed for riscv unless > the modules were installed/provided. That didn't happen for arm64 as > NLS_ISO8859_1 is built-in. > > If there are no good reasons to keep these configurations differently > for these architectures and only have NLS_CODEPAGE_437 bult-in, having > NLS_ISO8859_1 built-in is more consistent and the EFI partitions are > mounted more easily. This is the only configuration that had to be > modified to boot Debian 12 and 13. Thanks, queued for v6.20. - Paul