mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>,
	Gerald Schaefer <gerald.schaefer@de.ibm.com>,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 2/3] iommu/omap: Return ERR_PTR in device_group call-back
Date: Wed, 28 Jun 2017 11:32:02 -0500	[thread overview]
Message-ID: <345ed003-6a6e-a876-fa91-cdc9fcc1cd89@ti.com> (raw)
In-Reply-To: <1498651258-23700-2-git-send-email-joro@8bytes.org>

On 06/28/2017 07:00 AM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
> 
> Make sure that the device_group callback returns an ERR_PTR
> instead of NULL.
> 
> Signed-off-by: Joerg Roedel <jroedel@suse.de>

Thanks for the patch,
Acked-by: Suman Anna <s-anna@ti.com>

regards
Suman

> ---
>  drivers/iommu/omap-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 95dfca3..641e035 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1309,7 +1309,7 @@ static void omap_iommu_remove_device(struct device *dev)
>  static struct iommu_group *omap_iommu_device_group(struct device *dev)
>  {
>  	struct omap_iommu_arch_data *arch_data = dev->archdata.iommu;
> -	struct iommu_group *group = NULL;
> +	struct iommu_group *group = ERR_PTR(-EINVAL);
>  
>  	if (arch_data->iommu_dev)
>  		group = arch_data->iommu_dev->group;
> 

  reply	other threads:[~2017-06-28 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 12:00 [PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs Joerg Roedel
2017-06-28 12:00 ` [PATCH 2/3] iommu/omap: Return ERR_PTR in device_group call-back Joerg Roedel
2017-06-28 16:32   ` Suman Anna [this message]
2017-06-28 12:00 ` [PATCH 3/3] iommu: Warn once when device_group callback returns NULL Joerg Roedel
2017-06-28 15:48 ` [PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs Gerald Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=345ed003-6a6e-a876-fa91-cdc9fcc1cd89@ti.com \
    --to=s-anna@ti.com \
    --cc=gerald.schaefer@de.ibm.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome