From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: Jim Mattson <jmattson@google.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>,
Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks
Date: Wed, 25 Sep 2019 16:55:15 -0700 [thread overview]
Message-ID: <3460bd57-6fdd-f73c-9ce0-c97d4cc85f63@oracle.com> (raw)
In-Reply-To: <CALMp9eTBPTnsRDipdGDgmugWgfFEjQ2wd_9-JY0ZeM9YG2fBjg@mail.gmail.com>
On 09/25/2019 09:47 AM, Jim Mattson wrote:
> On Wed, Sep 25, 2019 at 9:34 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>> KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load
>> IA32_EFER" exit control was reset. Also, some checks were not using
>> the new CC macro for tracing.
>>
>> Cleanup everything so that the vCPU's 64-bit mode is determined
>> directly from EFER_LMA and the VMCS checks are based on that, which
>> matches section 26.2.4 of the SDM.
>>
>> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
>> Cc: Jim Mattson <jmattson@google.com>
>> Cc: Krish Sadhukhan <krish.sadhukhan@oracle.com>
>> Fixes: 5845038c111db27902bc220a4f70070fe945871c
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> arch/x86/kvm/vmx/nested.c | 53 ++++++++++++++++++++---------------------------
>> 1 file changed, 22 insertions(+), 31 deletions(-)
>>
>> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
>> index 70d59d9304f2..e108847f6cf8 100644
>> --- a/arch/x86/kvm/vmx/nested.c
>> +++ b/arch/x86/kvm/vmx/nested.c
>> @@ -2664,8 +2664,26 @@ static int nested_vmx_check_host_state(struct kvm_vcpu *vcpu,
>> CC(!kvm_pat_valid(vmcs12->host_ia32_pat)))
>> return -EINVAL;
>>
>> - ia32e = (vmcs12->vm_exit_controls &
>> - VM_EXIT_HOST_ADDR_SPACE_SIZE) != 0;
>> +#ifdef CONFIG_X86_64
>> + ia32e = !!(vcpu->arch.efer & EFER_LMA);
>> +#else
>> + if (CC(vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE))
>> + return -EINVAL;
> This check is redundant, since it is checked in the else block below.
Should we be re-using is_long_mode() instead of duplicating the code ?
>
>> +
>> + ia32e = false;
>> +#endif
>> +
>> + if (ia32e) {
>> + if (CC(!(vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE)) ||
>> + CC(!(vmcs12->host_cr4 & X86_CR4_PAE)))
>> + return -EINVAL;
>> + } else {
>> + if (CC(vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE) ||
>> + CC(vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE) ||
>> + CC(vmcs12->host_cr4 & X86_CR4_PCIDE) ||
>> + CC(((vmcs12->host_rip) >> 32) & 0xffffffff))
> The mask shouldn't be necessary.
>
>> + return -EINVAL;
>> + }
>>
>> if (CC(vmcs12->host_cs_selector & (SEGMENT_RPL_MASK | SEGMENT_TI_MASK)) ||
>> CC(vmcs12->host_ss_selector & (SEGMENT_RPL_MASK | SEGMENT_TI_MASK)) ||
>> @@ -2684,35 +2702,8 @@ static int nested_vmx_check_host_state(struct kvm_vcpu *vcpu,
>> CC(is_noncanonical_address(vmcs12->host_gs_base, vcpu)) ||
>> CC(is_noncanonical_address(vmcs12->host_gdtr_base, vcpu)) ||
>> CC(is_noncanonical_address(vmcs12->host_idtr_base, vcpu)) ||
>> - CC(is_noncanonical_address(vmcs12->host_tr_base, vcpu)))
>> - return -EINVAL;
>> -
>> - if (!(vmcs12->host_ia32_efer & EFER_LMA) &&
>> - ((vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE) ||
>> - (vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE))) {
>> - return -EINVAL;
>> - }
>> -
>> - if ((vmcs12->host_ia32_efer & EFER_LMA) &&
>> - !(vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE)) {
>> - return -EINVAL;
>> - }
>> -
>> - if (!(vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE) &&
>> - ((vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE) ||
>> - (vmcs12->host_cr4 & X86_CR4_PCIDE) ||
>> - (((vmcs12->host_rip) >> 32) & 0xffffffff))) {
>> - return -EINVAL;
>> - }
>> -
>> - if ((vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE) &&
>> - ((!(vmcs12->host_cr4 & X86_CR4_PAE)) ||
>> - (is_noncanonical_address(vmcs12->host_rip, vcpu)))) {
>> - return -EINVAL;
>> - }
>> -#else
>> - if (vmcs12->vm_entry_controls & VM_ENTRY_IA32E_MODE ||
>> - vmcs12->vm_exit_controls & VM_EXIT_HOST_ADDR_SPACE_SIZE)
>> + CC(is_noncanonical_address(vmcs12->host_tr_base, vcpu)) ||
>> + CC(is_noncanonical_address(vmcs12->host_rip, vcpu)))
>> return -EINVAL;
>> #endif
>>
>> --
>> 1.8.3.1
>>
> Reviewed-by: Jim Mattson <jmattson@google.com>
next prev parent reply other threads:[~2019-09-25 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 16:34 Paolo Bonzini
2019-09-25 16:47 ` Jim Mattson
2019-09-25 23:55 ` Krish Sadhukhan [this message]
2019-09-26 8:42 ` Paolo Bonzini
2019-09-26 11:31 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3460bd57-6fdd-f73c-9ce0-c97d4cc85f63@oracle.com \
--to=krish.sadhukhan@oracle.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®