From: "Christian König" <christian.koenig@amd.com>
To: Danilo Krummrich <dakr@redhat.com>,
airlied@gmail.com, daniel@ffwll.ch, matthew.brost@intel.com,
thomas.hellstrom@linux.intel.com, sarah.walker@imgtec.com,
donald.robson@imgtec.com, boris.brezillon@collabora.com,
faith.ekstrand@collabora.com, bskeggs@redhat.com,
Liam.Howlett@oracle.com
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-misc-next 1/3] drm: drm_exec: build always builtin
Date: Mon, 21 Aug 2023 11:49:56 +0200 [thread overview]
Message-ID: <3462dfaa-96a4-61fd-b31b-fb8d8eb6104c@amd.com> (raw)
In-Reply-To: <20230820215320.4187-2-dakr@redhat.com>
Am 20.08.23 um 23:53 schrieb Danilo Krummrich:
> drm_exec must always be builtin for the DRM GPUVA manager to depend on
> it.
You should probably go the other way around and not always build in the
GPUVA manager.
We have intentionally and with quite a bit of work moved the DRM_EXEC
and DRM_BUDDY into separate modules.
Regards,
Christian.
>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
> drivers/gpu/drm/Kconfig | 6 ------
> drivers/gpu/drm/Makefile | 3 +--
> drivers/gpu/drm/nouveau/Kconfig | 1 -
> 3 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index ab9ef1c20349..85122d4bb1e7 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -210,12 +210,6 @@ config DRM_TTM_KUNIT_TEST
>
> If in doubt, say "N".
>
> -config DRM_EXEC
> - tristate
> - depends on DRM
> - help
> - Execution context for command submissions
> -
> config DRM_BUDDY
> tristate
> depends on DRM
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 215e78e79125..388e0964a875 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -23,6 +23,7 @@ drm-y := \
> drm_dumb_buffers.o \
> drm_edid.o \
> drm_encoder.o \
> + drm_exec.o \
> drm_file.o \
> drm_fourcc.o \
> drm_framebuffer.o \
> @@ -80,8 +81,6 @@ obj-$(CONFIG_DRM_PANEL_ORIENTATION_QUIRKS) += drm_panel_orientation_quirks.o
> # Memory-management helpers
> #
> #
> -obj-$(CONFIG_DRM_EXEC) += drm_exec.o
> -
> obj-$(CONFIG_DRM_BUDDY) += drm_buddy.o
>
> drm_dma_helper-y := drm_gem_dma_helper.o
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index c52e8096cca4..2dddedac125b 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -10,7 +10,6 @@ config DRM_NOUVEAU
> select DRM_KMS_HELPER
> select DRM_TTM
> select DRM_TTM_HELPER
> - select DRM_EXEC
> select DRM_SCHED
> select I2C
> select I2C_ALGOBIT
next prev parent reply other threads:[~2023-08-21 9:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 21:53 [PATCH drm-misc-next 0/3] [RFC] DRM GPUVA Manager GPU-VM features Danilo Krummrich
2023-08-20 21:53 ` [PATCH drm-misc-next 1/3] drm: drm_exec: build always builtin Danilo Krummrich
2023-08-21 9:49 ` Christian König [this message]
2023-08-21 19:14 ` Danilo Krummrich
2023-08-20 21:53 ` [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation Danilo Krummrich
2023-08-22 1:31 ` kernel test robot
2023-08-22 2:18 ` kernel test robot
2023-08-22 3:01 ` kernel test robot
2023-08-30 7:27 ` Thomas Hellström (Intel)
2023-08-30 12:49 ` Danilo Krummrich
2023-08-30 13:42 ` Thomas Hellström (Intel)
2023-08-30 15:00 ` Danilo Krummrich
2023-08-31 9:04 ` Thomas Hellström (Intel)
2023-08-31 11:18 ` Danilo Krummrich
2023-08-31 16:53 ` Thomas Hellström (Intel)
2023-08-31 17:23 ` Thomas Hellström
2023-08-31 19:07 ` Danilo Krummrich
2023-09-01 5:59 ` Thomas Hellström (Intel)
2023-09-01 12:10 ` Danilo Krummrich
2023-09-06 14:20 ` Danilo Krummrich
2023-10-10 20:23 ` Dave Airlie
2023-10-11 7:07 ` Christian König
2023-10-12 10:33 ` Dave Airlie
2023-10-12 12:35 ` Christian König
2023-10-12 13:15 ` Daniel Vetter
2023-10-13 5:19 ` Christoph Hellwig
2023-10-11 8:22 ` Thomas Hellström
2023-08-30 7:48 ` Christian König
2023-08-30 13:05 ` Danilo Krummrich
2023-08-20 21:53 ` [PATCH drm-misc-next 3/3] drm/nouveau: gpuva mgr dma-resv/extobj handling, " Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3462dfaa-96a4-61fd-b31b-fb8d8eb6104c@amd.com \
--to=christian.koenig@amd.com \
--cc=Liam.Howlett@oracle.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=bskeggs@redhat.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=sarah.walker@imgtec.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®