From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216E5C54FCB for ; Mon, 27 Apr 2020 16:50:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F28922078E for ; Mon, 27 Apr 2020 16:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YN4xMzac" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726350AbgD0QuP (ORCPT ); Mon, 27 Apr 2020 12:50:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbgD0QuO (ORCPT ); Mon, 27 Apr 2020 12:50:14 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D597AC03C1A8 for ; Mon, 27 Apr 2020 09:50:12 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j2so21387221wrs.9 for ; Mon, 27 Apr 2020 09:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ifZHzQrYJTJ2psIoVYONoJxVcPBrBwiLq0Ka5H1X7f0=; b=YN4xMzacilYGgkI5xIJKKjKcvwZcZ4qjnwboi7t+4heCeg+DVoCri3aTgOQ43+2b/U ur3Wx9/P9iXCTeuhRKTWS9KtRKW7D4EGSQ1W6lDnSmD3l0qsduegt1i2nxkp/i7sIvSY 40XOB+SMgz68l1/ArBdGciU3CqBzBQR7h2zzVy6FvC8lqekaAiyRsAw56dIw+I4FErQ4 azNHB4ooJm10iR0K4KIDxECVWcNQfJk1j0FaB9+bxGqUgxFV+H5J+klrzmWcM6+4poJV 1RqelOBabzBzN0wbIZzc+jQcxhamURzPkZjnvLWAby0K3AwbgDzpUeJXgcLJw4EKrHSR 6A2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ifZHzQrYJTJ2psIoVYONoJxVcPBrBwiLq0Ka5H1X7f0=; b=KyRk2laheKOQ4kbuHsB+zA8QqWG+hY4nQL2jXK9G5oxOZa3goq1e1x8OakqSVSCOx7 XF+pIMj/WLhv5UblaP+yBBPYp61qr0ipSPSjQCtiM6wFFT2R/oXvI+nlIpnFdEs7P+9y 8LacGy79wYzDIHbWV+7FuthRdf5/w/YpdOQBRVwTdSzAwcPVjGLjakhakRMobzmyEInH UzIKq/V5woMvVsKmSU0hg7DAYiJfV6/gBdOtPO37yjfe3yFboZIGCziFtPknKcxqs/wg K5oTi90L4J8LgM/43ZqDs+BzI0Ojj3Zndf0uRw4is2XB1OmgUwmky4hNHXCJSn2jml7Y S1aw== X-Gm-Message-State: AGi0PuYhVeNfaBNRlsAeBxGMYsZ9PE86GzpKgGFiW5EdfcwuLjHsl4ce xmbGzcHZAdrOQJgqC6lt2Xm9zg== X-Google-Smtp-Source: APiQypLnpGbWiFbiATkGLzM1ksCRfp33HEV/xjz0k0UXMZ8dYv4G0WKZWQ6pcTQZyBZPekAo8fPm6Q== X-Received: by 2002:adf:f24c:: with SMTP id b12mr28353216wrp.359.1588006211473; Mon, 27 Apr 2020 09:50:11 -0700 (PDT) Received: from [192.168.0.41] (lns-bzn-59-82-252-135-148.adsl.proxad.net. [82.252.135.148]) by smtp.googlemail.com with ESMTPSA id f23sm16030600wml.4.2020.04.27.09.50.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 09:50:10 -0700 (PDT) Subject: Re: [PATCH v3 4/4] thermal: cpuidle: Register cpuidle cooling device From: Daniel Lezcano To: Lorenzo Pieralisi , Sudeep Holla Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com, "Rafael J. Wysocki" , "open list:CPU IDLE TIME MANAGEMENT FRAMEWORK" , open list , "open list:CPUIDLE DRIVER - ARM PSCI" References: <20200414220837.9284-1-daniel.lezcano@linaro.org> <20200414220837.9284-4-daniel.lezcano@linaro.org> <6b58035c-fe48-09ab-f042-729b07bcfec6@linaro.org> Message-ID: <34667fb4-664c-c80b-6bba-fe2ae981dcc1@linaro.org> Date: Mon, 27 Apr 2020 18:50:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <6b58035c-fe48-09ab-f042-729b07bcfec6@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi guys, any chance you ack this patch ? On 21/04/2020 10:15, Daniel Lezcano wrote: > > Hi Lorenzo, Sudeep, > > other patches of the series are acked / reviewed. > > If you are ok with these changes, could you add your acked-by so I can > merge all the series via the thermal tree? > > Thanks > > -- Daniel > > On 15/04/2020 00:08, Daniel Lezcano wrote: >> The cpuidle driver can be used as a cooling device by injecting idle >> cycles. The DT binding for the idle state added an optional >> >> When the property is set, register the cpuidle driver with the idle >> state node pointer as a cooling device. The thermal framework will do >> the association automatically with the thermal zone via the >> cooling-device defined in the device tree cooling-maps section. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/cpuidle/cpuidle-arm.c | 5 +++++ >> drivers/cpuidle/cpuidle-psci.c | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c >> index 9e5156d39627..2406ac0ae134 100644 >> --- a/drivers/cpuidle/cpuidle-arm.c >> +++ b/drivers/cpuidle/cpuidle-arm.c >> @@ -8,6 +8,7 @@ >> >> #define pr_fmt(fmt) "CPUidle arm: " fmt >> >> +#include >> #include >> #include >> #include >> @@ -124,6 +125,10 @@ static int __init arm_idle_init_cpu(int cpu) >> if (ret) >> goto out_kfree_drv; >> >> + ret = cpuidle_cooling_register(drv); >> + if (ret) >> + pr_err("Failed to register the idle cooling device: %d\n", ret); >> + >> return 0; >> >> out_kfree_drv: >> diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c >> index edd7a54ef0d3..8e805bff646f 100644 >> --- a/drivers/cpuidle/cpuidle-psci.c >> +++ b/drivers/cpuidle/cpuidle-psci.c >> @@ -9,6 +9,7 @@ >> #define pr_fmt(fmt) "CPUidle PSCI: " fmt >> >> #include >> +#include >> #include >> #include >> #include >> @@ -305,6 +306,10 @@ static int __init psci_idle_init_cpu(int cpu) >> if (ret) >> goto out_kfree_drv; >> >> + ret = cpuidle_cooling_register(drv); >> + if (ret) >> + pr_err("Failed to register the idle cooling device: %d\n", ret); >> + >> return 0; >> >> out_kfree_drv: >> > > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog