From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E64FD3CAE87 for ; Mon, 13 Apr 2026 13:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086347; cv=none; b=NT5n6ceGY9kS37CbP6M9g8szDpAD4ofwUm5kK36LG5m25tdpSSJ8yWaKiXiQBg7emRwAbyi5+kf/eGxY8y4hMfcDH3jg6+aoM/8Ywbq0vVcDWqbvl2m10epo0ZsDG+040b6ZtDdqmNVwFHIiLgb1aPx8RiafVFy58hc1V/8Azl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086347; c=relaxed/simple; bh=tchUCn26E/co8gGiaVaMdaMujQkkkQCs11l6BKW+kp0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gXJOlmpkrotmxI2JwxSK+bVv2JE0nIpwtSucSIj+VLn3Y7mBffsxTTumVE7qcxNWP7eGpnNTIbEculC2d/m8z+8vV7h60+SPELvv/MFVVnOuG+OMTOqVaetCaBOJtTlBXkaEezVrXmuWOeBWHvxJKdrRhMWWa6cGDLKjAB/Zdmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=J2+Xgq4O; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JmYXJXeP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J2+Xgq4O"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JmYXJXeP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776086343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7k2xp3bBV4lET1Ny4Madx/DQczLuqXWtDe45ShURu9Y=; b=J2+Xgq4OrOvRueY7XnF2yehva1T9bX60TRdMGU7L/iuAwnJutrLdXHm1qSOzRQnzUkLlrD fhZIF5lN51Cztfge87tfQnkqgGImKEWu6w/7U44c4ylxLRGVwlT57iVbXoACVPLjO2+t3C BmLpHYuF+mJrvtusIp3+K1WbLcRTAEs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-U46n7ntjO_yVm9_n1-P95Q-1; Mon, 13 Apr 2026 09:19:02 -0400 X-MC-Unique: U46n7ntjO_yVm9_n1-P95Q-1 X-Mimecast-MFC-AGG-ID: U46n7ntjO_yVm9_n1-P95Q_1776086341 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4836abfc742so31845845e9.0 for ; Mon, 13 Apr 2026 06:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776086341; x=1776691141; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7k2xp3bBV4lET1Ny4Madx/DQczLuqXWtDe45ShURu9Y=; b=JmYXJXePNlMkWsi0s2QNctmb3oATwyZfjbxzzQeIk5Im0yKU1IsePQfdQMWev4+yi6 fnxnTkyD1XNTZsXNf8j48I5yPHeklbz7QVDw8KNMRhPT/l/pqCro7VemUPFJ7GZQtUf0 XkP0YEwdLxMmQ/E1LSXyxOkHaai0FYSRLK04iSHziHVU5EtTEiiQlS2Gk+D0XkBGhgvh c9MxjjCcilNI/DbnAHs2LFmFjLm58pCUB0SR2bdW+dYsBYbNlA8LM5zPaNv9B4QM3RO9 uEk6cveJV2HY3Rj+tPyx+gFYTh43t7RL8xNdv1ThU4yN8wO91JoJ3bEI+e0E0N0bw5hW DAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776086341; x=1776691141; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7k2xp3bBV4lET1Ny4Madx/DQczLuqXWtDe45ShURu9Y=; b=RyhAr5o3T6h1TFfZ7PckRqbF1ZeMXjHdTVF0s4OXi7KYwYaJgiQAzcuUYL12JO4OF7 mO25rSOFZE563K9isQ7fKGsBNgtq2nfF2AMdWOKE6pc4qMVnnFf7ZIhehTapXPBD15Xs TE9n7rlzzooUiMaSqay9zBBDjKVhShlHrDwE9pT+72fVhnkqgusK/opL9mQ+5jVF2pKR Yyxf2Me7RmcHVY5Wr0f/Aoocta8/te7Q08tnftdbkrPSeuZxmIUwbHgpdWVdn+mc76sq dtuEFWO/yCAF5gWwy25WTPlqTOAOpwczNfmx5/aQLB0oPcPixzC3M0oEHZOs+JV9fOTG Ie/g== X-Forwarded-Encrypted: i=1; AFNElJ+BzZvIv2DAPBB2qpQND8RI4Ij6M9ddwVtLdeBr+w3nqoR93iOiqR3Lt9waaKFQrZxMcsmQvDASfKFXyk0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgk/7i6oUFgFR+t3+CKbF+gpOTpB6RXOsZ6j2fAIpNPcNafWrF UqwNipxMuJszzRn1TEDYd412/XiFWb6WukiYMhxAhFUrXBdP92/VqAmXKHzdnAoFch4givko2yw U/gopchfiaHKLKWoxDh+BwlqlapSUOJDtMwrgLguQjlYnGkHiPeZ8CbFlCCNbInSglA== X-Gm-Gg: AeBDiet06YsB+niuEKiKl0c9pdsqOBSTPrWj7Nq3hhIdhQ1wRGZHnCPmqwehQllZ7td eWmNocZGHKGxwBd+dxKD65L093+lj9lwerd8eN9uSvLWlbr8uL783YGFFKdfpzLGomssUYKX8li cMaFPHGFJw95qPCA/VRVk3L2je6irl1LycAxmb7VElptfcCqr3QxX19mnV4v+ARrhVbAsMNpjUq DHnTtmPeThY55aT8xra+uyM83HPA0s9G//Z25J8e4iyVW8GvoWqmlHzaubYc8oqJG9H41aAmRRn h0vuDP53JxbBkh1ctuDbxKydx12LiyDZc5xSQEMyrRS8uksz75VDJSa5La9zayURqxjdTreN/p8 /i1y4lmho8GwB3wNoGttkRww8D+F6OKPno5fugghg9NbodzWy9OgpNCwe X-Received: by 2002:a05:600c:c117:b0:486:fb69:4960 with SMTP id 5b1f17b1804b1-488d68af0e7mr124590515e9.19.1776086341111; Mon, 13 Apr 2026 06:19:01 -0700 (PDT) X-Received: by 2002:a05:600c:c117:b0:486:fb69:4960 with SMTP id 5b1f17b1804b1-488d68af0e7mr124589985e9.19.1776086340631; Mon, 13 Apr 2026 06:19:00 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488df272d55sm67056435e9.15.2026.04.13.06.18.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 06:19:00 -0700 (PDT) Message-ID: <346925be-bec3-47ee-866b-a6890b455a0b@redhat.com> Date: Mon, 13 Apr 2026 15:18:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 net-next 4/7] devlink: Implement devlink param multi attribute nested data values To: Ratheesh Kannoth Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, sgoutham@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, donald.hunter@gmail.com, horms@kernel.org, jiri@resnulli.us, chuck.lever@oracle.com, matttbe@kernel.org, cjubran@nvidia.com, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, dtatulea@nvidia.com References: <20260409025055.1664053-1-rkannoth@marvell.com> <20260409025055.1664053-5-rkannoth@marvell.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/13/26 1:00 PM, Ratheesh Kannoth wrote: > On 2026-04-13 at 16:24:41, Paolo Abeni (pabeni@redhat.com) wrote: >> On 4/9/26 4:50 AM, Ratheesh Kannoth wrote: >>> @@ -441,6 +448,7 @@ union devlink_param_value { >>> u64 vu64; >>> char vstr[__DEVLINK_PARAM_MAX_STRING_VALUE]; >>> bool vbool; >>> + struct devlink_param_u64_array u64arr; >> >> You mentioned that you intend to handle the possible CONFIG_FRAME_WARN >> with a separate patch. IMHO such patch need to be part of this series, >> or things will stay broken for an undefined amount of time until such >> patch is merged separatelly. > > Patch no: 3 in the same series. > https://lore.kernel.org/netdev/20260409025055.1664053-4-rkannoth@marvell.com/#t I fear that is not enough ?!? i.e. what's about devl_param_driverinit_value_set()? Likely devlink_param->validate is called with enough space available in the stack to not care about the huge argument, but the mentioned helper is called quite deeper. /P