From: Nadav Amit <nadav.amit@gmail.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions
Date: Fri, 20 Nov 2015 09:46:07 +0200 [thread overview]
Message-ID: <346BBAFD-80C9-4C26-89B7-0F9ECD5D1DA0@gmail.com> (raw)
In-Reply-To: <CANRm+CwSOtY69VpTHSZ1s2-YKWk7jm080rBF_9p-GBdsqDNOgw@mail.gmail.com>
Wanpeng Li <kernellwp@gmail.com> wrote:
> 2015-11-20 10:52 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
>> Hi Paolo,
>> 2015-02-09 17:03 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>>> NoWrite instructions (e.g. cmp or test) never set the "write access"
>>> bit in the error code, even if one of the operands is treated as a
>>> destination.
>>
>> Sorry to reply to an old commit, btw, could you point out where in SDM
>> describe above?
>
> I see.
I don’t understand whether you still need my help, so to clarify: on a
page-fault the error code should indicate whether the access was due to a
write access. Previously KVM marked it as “write access” for instructions
such as test and cmp that do not perform write.
Nadav
prev parent reply other threads:[~2015-11-20 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 9:03 Paolo Bonzini
2015-02-11 0:56 ` Nadav Amit
2015-11-20 2:52 ` Wanpeng Li
2015-11-20 3:27 ` Wanpeng Li
2015-11-20 7:46 ` Nadav Amit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346BBAFD-80C9-4C26-89B7-0F9ECD5D1DA0@gmail.com \
--to=nadav.amit@gmail.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®