From: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
To: "'Greg KH'" <gregkh@suse.de>
Cc: "'Alan Cox'" <alan@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
<qi.wang@intel.com>, <yong.y.wang@intel.com>,
<joel.clark@intel.com>, <kok.howg.ewe@intel.com>,
<toshiharu-linux@dsn.okisemi.com>
Subject: RE: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH
Date: Mon, 30 May 2011 17:17:19 +0900 [thread overview]
Message-ID: <346D35FD8BD841329CFDA7803DDB899E@hacdom.okisemi.com> (raw)
In-Reply-To: <20110530074722.GA7947@suse.de>
On Monday, May 30, 2011 4:47 PM, Greg KH wrote:
> Why put this with an #if around it?
> Why not just always not
> bind to this driver as we have a "correct" driver for the
> hardware now?
Let me clarify your saying.
Which does your saying mean, (1) or (2) or else?
(1)
> +#if defined(CONFIG_SERIAL_PCH_UART) || defined(CONFIG_SERIAL_PCH_UART_MODULE)
> + return -ENODEV;
> +#endif
(2)
> + if ((dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8811) ||
> + (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8812) ||
> + (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8813) ||
> + (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8814) ||
> + (dev->vendor == 0x10DB && dev->device == 0x8027) ||
> + (dev->vendor == 0x10DB && dev->device == 0x8028) ||
> + (dev->vendor == 0x10DB && dev->device == 0x8029) ||
> + (dev->vendor == 0x10DB && dev->device == 0x800C) ||
> + (dev->vendor == 0x10DB && dev->device == 0x800D))
> + return -ENODEV;
With Best Regards,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.
next prev parent reply other threads:[~2011-05-30 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 7:42 Tomoya MORINAGA
2011-05-30 7:47 ` Greg KH
2011-05-30 8:17 ` Tomoya MORINAGA [this message]
2011-05-30 9:46 ` Greg KH
2011-05-30 9:56 ` Alan Cox
2011-05-30 11:19 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346D35FD8BD841329CFDA7803DDB899E@hacdom.okisemi.com \
--to=tomoya-linux@dsn.okisemi.com \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®