From: Grant Coady <grant_lkml@dodo.com.au>
To: Greg KH <greg@kroah.com>
Cc: gcoady@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] pci_ids.h: remove duplicate IDs
Date: Thu, 05 Jan 2006 15:22:34 +1100 [thread overview]
Message-ID: <346pr1th3rlm1rh1im2sjikn6grdrctrn5@4ax.com> (raw)
In-Reply-To: <20060105034213.GA23613@kroah.com>
On Wed, 4 Jan 2006 19:42:13 -0800, Greg KH <greg@kroah.com> wrote:
>On Thu, Jan 05, 2006 at 12:40:12PM +1100, Grant Coady wrote:
>> On Thu, 05 Jan 2006 12:14:16 +1100, Grant Coady <grant_lkml@dodo.com.au> wrote:
>>
>> >
>> >From: Grant Coady <gcoady@gmail.com>
>> >
>> >pci_ids.h: removes eight duplicate IDs that crept in during the
>> > 2.6.15 development cycle, commented a duplicate where one ID was
>> > defined in terms of another. Compile tested with allyesconfig.
>> >
>> >Signed-off-by: Grant Coady <gcoady@gmail.com>
>>
>> Sorry gang, please scratch. I'll wait for -mm1
>
>Why scratch, what was wrong?
'Cos sometimes I do incredibly dumb things like copy 2.6.14 over
2.6.15 (well it was the a and b), so:
grant@sempro:~/linux$ do-device-id linux-2.6.15
find pci_ids defined
find symbols in source tree
find source defined symbols files
summary, line counts:
1797 symbols-pci_ids.h-define
0 symbols-pci_ids.h-dups <<== no duplicates
2194 symbols-pci_ids.h-new
2194 symbols-pci_ids.h-orig
1933 symbols-source-all
433 symbols-source-define
104 symbols-source-define-files <<== clean these up??
1214 symbols-source-files-include-pci.h
29 symbols-source-files-include-pci_ids.h
The patch to scratch was really a 2.6.14 pretending to be 2.6.15,
not wanted by anybody.
Then I was intending to start on the source files then define or
redefine PCI IDs, removing those defines to the main pci_ids.h
file.
>I'd suggest working against Linus's git tree, that might be a bit
>simpler than the -mm tree, and is what I merge against.
Okay, thanks,
Grant.
prev parent reply other threads:[~2006-01-05 4:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-05 1:14 Grant Coady
2006-01-05 1:40 ` Grant Coady
2006-01-05 3:42 ` Greg KH
2006-01-05 4:22 ` Grant Coady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346pr1th3rlm1rh1im2sjikn6grdrctrn5@4ax.com \
--to=grant_lkml@dodo.com.au \
--cc=gcoady@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®