From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD6024DCF6 for ; Wed, 10 Dec 2025 06:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765348234; cv=none; b=H/ki+1BCj7TY1oRacOqcj036wzcAKOnzkHbCmHDr/flo/oNYL38oPzscsDNyaaAJQDVxtZo84h/gI/DMYHx8S0EdV63oj8Rga7WOxV5udLpmSP51w7w/IDXv7hJdmhI+KriZSQDgzhDvjLAwAzJycL/5t4/+mbbPoUTPBRPAQSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765348234; c=relaxed/simple; bh=O8HUoaSUxN0lwQuk2R6pVYJ/E9trzG6EwOSZXVhKEdk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UOzfGOFvccp9MIr3ioqkqg3zsMo9olK7G2eVO4a+Yu0hPM/75iwcJsgrb7dEnTaQH6rrk+6vJpHVO3JnqnBcwcmyfsPupz00xsdev1zJSjUFSB7MXuAmZJ6PPmARDPiF06EGVE/5jVaD9Hzhhjyzq/qEbqXjf0sq/5R38Zf7KUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SQcI/UkZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WJIGDbdm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SQcI/UkZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WJIGDbdm" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA6DkhU2175605 for ; Wed, 10 Dec 2025 06:30:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6q9RFfbyN7BJ8f14Run+4QbQe+TihAeoBebl1Z0ZT0s=; b=SQcI/UkZuz82q2EC ugord4t7WemhvS74IB6IjG8/CJKQisPLSguABIb/HjwJzzYIa6bF/fFVjSrTb66e 78EsLlySuOAQ6DPTKGrZz3T/HMFFcNTwunGqoiW9rmbDrhXcjnNVsYWIpcFY20cs fcgtSJRwI5doz4alP7DDOpaPjla7rT4ylj1em32Xqskeyr0ZNdjj8weA/xgn6BgG 1AV9y94brL3iSdovkagW2QuWCxQd23Jl/XhhOAPWImzbC0HWDkGHnybyQ2BUfMur 0VITdoQ7U6kpGzUTBH5sNFyeRbZ3qAiDa72wVeQt6ElLmgIB/aVHGELW1TGhhEdS mmkH0Q== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ay1xwr9as-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 06:30:32 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-341aec498fdso8285440a91.2 for ; Tue, 09 Dec 2025 22:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765348231; x=1765953031; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6q9RFfbyN7BJ8f14Run+4QbQe+TihAeoBebl1Z0ZT0s=; b=WJIGDbdmhMl/qlg6PO1EI06sNehQuS9Sr0avFIQhmd9qxFc3hAZSymMXb1MD6nisGe WOgNGMenmg5QTMFOq/bd6TLvGj0Dqk+DUcSHVZeReA4q3b8VwmM5e5BfJtyp8rTvxm9F CqSEkMqyZNnYELK927+t0JS2IYe/OnLZ50eLinlvHn1flLvZhB/cLlPfnKCyhVckvRQb SHDphqgn6sJbacrA6mosspXKXrLJW8h5gtcYX+7KtvyGyvzHD9ZL9nHYGNpzzTwNADSR pbTJodClepU5wU2QCF7DK58KDGGruZZgrAaZYxhHeVcE7fRxwkRe88JNlErRg2vUKyv2 pVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765348231; x=1765953031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6q9RFfbyN7BJ8f14Run+4QbQe+TihAeoBebl1Z0ZT0s=; b=VNgn00BTfLiRjurRHXolwjg+KCKvS1B4zpGLe2cc8Sim/Y11CLSRvd4aSJZNc6jAIo JZD4bil7A5DnH1YXe5AzRLCMrD/u4/NwEPthPOIqYzvs0M0Zoii/le1a5MWYjRNXkscV 28gNoqkbUZNoHwWF7IP7y3pRvId5PlNrs7+zsRbgif2gxNmHRD5PqjI9eg494+XbtIyy WCvSjGMWOkhqhNBAW0+U+42Arac/NmCmN54YV+rImzDKdMgdJzIak+cSBDQfpIJEzgQo fqcpyCEkhriNYzpjOUmgtCGswl0VETBKt9AFTQ+31HlROJX2ZVAn7kKDpJsJbLDdeC9b hMpw== X-Forwarded-Encrypted: i=1; AJvYcCVz+yigNYl+957vMqgPU95UztLPBTLtMwmwCEbribrtexZ1QQVsKkw+emJrtdRLNZonnAw5H0ETUEtxMCg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4KGlNfKBq7SwkPj/AlZhrfFIcwtn8xPaOA8/ptC0MSpVpzo30 O8IY3q+sNOQM/JATBjt2T+89veALCBrO39aj1b2309saVTVnoijoQJsHTJ3Xt6UEM09KxmzdPlj w4/a34tzXs1SSPbXu/1UwMAvYIb5SfKfFli6xEGmF+xh5KWwize4KuMW57s+p9C1mTx/VIoQFq+ k= X-Gm-Gg: AY/fxX6sqavzE4iCPU13JAFJwwU9pSok4lI/yhENmVLFHAtg3RDspXBb6EiTP0AX/eE xz4BFipNKoEjezvmfIRwUXzSpJhLA/BmLzJMSM6ORBwbycCGrq6rmWW+IhTuKiky2GbYhcV8QOL SPUsWqP5e+bW+tJGGOPO6cr4Z501Lm2rHNdxrB9X1FdES+lXBsYSVKDj+qPVSdzm47xZbGllcdG rlRXxNv8Jo0zubYcg4zAmAvxBVeguvX3Jo+OfzyMC/PYG306+4WWcTzjdzaSi1EmPntcDYzIn7w yQbMn2ZWCYCWXCIH+dGvW0tqvIOHFkrDeyegraK2xnzdf2uPafh/dV12bXspMcyQMcCLhc7GRr9 sfu2hnKBtu8GFL0ZGcReQ0it7Y6MK23uViVDAdH04vjn4 X-Received: by 2002:a17:90b:4b8b:b0:349:8a8b:da5c with SMTP id 98e67ed59e1d1-34a727cfdbfmr1209102a91.11.1765348231164; Tue, 09 Dec 2025 22:30:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXMxHZ4YLg9CFRwKxi/cgDsFxsPK6LFkqm/CLc1kVT+n707zz0quc94eSaxC/51ZwIj/qpLw== X-Received: by 2002:a17:90b:4b8b:b0:349:8a8b:da5c with SMTP id 98e67ed59e1d1-34a727cfdbfmr1209079a91.11.1765348230691; Tue, 09 Dec 2025 22:30:30 -0800 (PST) Received: from [10.218.37.132] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29daeaabf5fsm172705885ad.78.2025.12.09.22.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 22:30:30 -0800 (PST) Message-ID: <3470cae3-d86c-4dd5-a24c-c7f4bf6e017a@oss.qualcomm.com> Date: Wed, 10 Dec 2025 12:00:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] net: mhi: Enable Ethernet interface support To: Andrew Lunn Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Manivannan Sadhasivam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org References: <20251209-vdev_next-20251208_eth_v6-v6-0-80898204f5d8@quicinc.com> <20251209-vdev_next-20251208_eth_v6-v6-1-80898204f5d8@quicinc.com> <5a137b11-fa08-40b5-b4b4-79d10844a5b7@lunn.ch> Content-Language: en-US From: vivek pernamitta In-Reply-To: <5a137b11-fa08-40b5-b4b4-79d10844a5b7@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDA1NCBTYWx0ZWRfX9xuLnq9WR0KT 054XzEalWp+5IbKg9qja5njYOHQHGSNKtxzYtQTiHEzRv/bJhGt0zbKsPVhLryAGlcsBtRWGJsl tl2YJa3VzizuIznFZY/OQ4A0raNagqiaZY1jqB+QKFRqXH7v8Iulr4s9Optu/H3mjXwDzJfcFYd v8wV+M6JJtt6BB5RBiHntuQKxeF4zfjBpGkhGVhEhHrCkuE40giKCXz3Owopu1xJCJI49FzXV8j Xl5c1xTnD0s/gQFt5ZBaW71y8MYi+jLvVfK7qpwbxxpXBQZhZXUbIQpbpRvxz5lB86SqskplP6e RjiRrOmz3wtNbNcjJThQe+RNJvxRj+qnqI6ERR+HQSj+MBXnpl55av4eobAF6JP2yc0wZW/TIzR yvbrH0XusC3wuflZ6cNjyANbvRojSw== X-Proofpoint-ORIG-GUID: coKcm5vi410ZCgbXvnqilqTbaCV-9gI4 X-Proofpoint-GUID: coKcm5vi410ZCgbXvnqilqTbaCV-9gI4 X-Authority-Analysis: v=2.4 cv=F/lat6hN c=1 sm=1 tr=0 ts=69391388 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=P-IC7800AAAA:8 a=qHXWqmT0JF4T8da83qwA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_05,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100054 On 12/9/2025 7:06 PM, Andrew Lunn wrote: >> ndev = alloc_netdev(sizeof(struct mhi_net_dev), info->netname, >> - NET_NAME_PREDICTABLE, mhi_net_setup); >> + NET_NAME_PREDICTABLE, info->ethernet_if ? >> + mhi_ethernet_setup : mhi_net_setup); > > Is the name predictable? I thought "eth%d" was considered > NET_NAME_ENUM? > > https://elixir.bootlin.com/linux/v6.18/source/net/ethernet/eth.c#L382 > > Andrew For Ethernet-type devices, the interface name will follow the standard convention: eth%d, For normal IP interfaces, the interface will be created as mhi_swip%d/mhi_hwip%d.The naming will depend on the details provided through |struct mhi_device_info.|