From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6288E37E5D7 for ; Wed, 19 Aug 2026 13:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787145484; cv=none; b=ahkuVhjxWObTX/fHaka9YYeKDtP9UtoZlkznbaKBnNHdFndaxpI+7gVGUZP4BMiWh2gxBrp1vjxvuneV0q6QU4IllSBL5qwRoPn1sADpnXUNqW2xVQTYm9pAt7hMuXKR/j+WGtXzapMLzBs9U/b5dBgK6BqnNnk1hyTwiy8bqKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787145484; c=relaxed/simple; bh=+dq/mMnDe9QFfq17yLaBK6nHu+80T6tyc8mfK+ZvPkA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KJSrIr4cECh2CevaN2y6POrDlyM1KDQpisGQRKKpweU2zrOz5OMyEbBeY2XUDOo5jIuC102hccPMI6Gt1p3odDmKoQUXFOtYt1wE+TUyEVFKq7qNB1WYNxnCcdzrNxmE0n+6YXhGtjsU2CFPWLDC0TDRjUBZIdYjqDZojZgJYZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dTR/FC8r; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V9Cc00sj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dTR/FC8r"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V9Cc00sj" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JD0957174263 for ; Wed, 19 Aug 2026 13:17:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DHcojprWwMclTR96W1Kcp7mAYQX7rnuvUTwbQrssUdg=; b=dTR/FC8rtsTF0qmw JN8frrhbf2bjGgTihPM4XakQB12zomE1VpKen0fOtSgG46aHEXyCWFOTuRZKS7Rs ErV6+SGTMSgG3cxaldLhHs3QGPdbiyn9rNpTe7JjLbSzMfqopRCRG987PZcfAFP3 4RMg7P2JPaJrnnQ7ssoi1uBBUtLtsd+EBKmGH2JOp3iaFEp2xOORM+hyYlcjI+LN uVpR0jSaAvc19aIOHICGZ4lUAbji2Hanp3LjYjHTNKhVcpF/n17pggSk2jnYp/4E l5I7Lf5/9XTlCfsMkCZYDby3WDNf8pXxOLhPUtjSUGqljtRZ+UaznP0NSLi1KdVB 2EiJDg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfjkfk0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 13:17:56 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38f97b3f853so1803629a91.3 for ; Wed, 19 Aug 2026 06:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787145475; x=1787750275; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DHcojprWwMclTR96W1Kcp7mAYQX7rnuvUTwbQrssUdg=; b=V9Cc00sjEz1amhk5EKNH2ih1GGZT2kn83EIPGk2ctlUMIqk2b7HgVxiDnvLmMm5M4S 2+b5awUdf0kRXYQ1m3Tp9G8l4DlOGTIj/wEuo9N/w3IqvhG6kxcSu0uZaq991x3+aufP 1VIZygFlCz4jnifTdtwGaGWT9ZxBymM5Veb8uykkmj7dfTA3wwBSlRAAE2MxE7vuM+QC mBZpJC5uoMQaroBbYUzpibafc0FFXA/TrTeOR19w9wMUR29o/NhsrZheTVzohqPY684Q +UV5tF6AbAD5vBt69n5yend2zAuv6xZZ3OH61PEuv2ZL4NYtmvrr/WGWjb3SlmPUC19v ZIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787145475; x=1787750275; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DHcojprWwMclTR96W1Kcp7mAYQX7rnuvUTwbQrssUdg=; b=i+9c5wMJxnPted9SJl6gjNStBG8BpKcWmwE1jw+jhs1FCQxlePQqwm4kZawi9yrUR0 LomyIZG9O5SX5bWL4nJH+8zcEQzZi9V/Q6NlHnHK5ofgGlpU+5zFzvQz15ZpZlGYUkqk nvc2m14Q34tZgbDc4/lMK4s57bzU6gRC607zH1yTjbdZ+j8lKVMPkmWmY+nGlZ/tRBGg jq2YQn0mT1V4wtCrDd1Dun0N4M8kARBb/JDyzUsTQEe4U3XsCAU73UCCI/Yo8wPkCwqp TF5CyCNHTLZb4EQihjy7xgiB9lVou5IBB/H1lXqUF1g/G+t31LMW2N80ELD46MJuwb0B aJnw== X-Forwarded-Encrypted: i=1; AHgh+RrGkq11nCUBC1eF8jO6mGeRlfjJfrdC7+ZWOJNaXXiEj51+QHbopF2NdYul0p5ecjt141ll5lJgjueV0DE=@vger.kernel.org X-Gm-Message-State: AFuF++nH/P2WoQgsBm3JxzhgfzcO1w6TjO7eIuq1F10A0KLpWKYFgOOB HmAk22kItsXcE1OKs9F/5tQ9l6xZXdWF30fTQ5siyHvOxPBPan4p3obv9oqX+Kyymqdc6uDYY9+ jsF0jH0vtBRNkPYgkvnRxG1JLrjRktnKcKYpwvoHFrcvRZtPVCYOSzZvn+txyLqvMbVU= X-Gm-Gg: AR+sD10+FnUTuSNkDaANzScmBUrbTh6fK/dV6l0QqjYvQoNP+aLk70PkkdekS+8wD+7 n5Lj4o98XxYwVXH8b8cegcU3dSSuAhM6LDnnwYeFZeSRZxlobzRmWS5KxSy6hMMLACMm46/lzEZ sV0R7o9CF1H/JcjvLk/RDo1M6sKD1VZ3YY4M3t9gH1nhNUEaz13ePBRtnxlBFTXqjDzE6+38vSp WQezgj/OiGOg7wyDS12rRRshb9GygMO+JpNsiSrIkc65QX7E9xRrz5wWZPmhFvVWdJ4TsqbxQ9A ffRlflOlGhODJnRQsjS9ELueXzI/VyWoYAHvLQBPrZETCk6k6d1YRA2MQnoTpeTOaALpn8ooV9v caI/85IFM8jaTjyRCzXrrQKi/9CEOBg== X-Received: by 2002:a17:90b:57cc:b0:381:a766:efcc with SMTP id 98e67ed59e1d1-395810e93a0mr8967648a91.14.1787145475198; Wed, 19 Aug 2026 06:17:55 -0700 (PDT) X-Received: by 2002:a17:90b:57cc:b0:381:a766:efcc with SMTP id 98e67ed59e1d1-395810e93a0mr8967481a91.14.1787145474636; Wed, 19 Aug 2026 06:17:54 -0700 (PDT) Received: from [10.219.56.166] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957f7c962csm2756751a91.0.2026.08.19.06.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 06:17:54 -0700 (PDT) Message-ID: <3476b5c3-7983-4994-a901-3d7d8bd75255@oss.qualcomm.com> Date: Wed, 19 Aug 2026 18:47:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/15] accel/qda: Add initial QDA DRM accelerator driver To: Krzysztof Kozlowski , Oded Gabbay , Jonathan Corbet , Shuah Khan , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Bharath Kumar , Chenna Kesava Raju , srinivas.kandagatla@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20260817-qda-v2-v2-0-69a02e9090d4@oss.qualcomm.com> <20260817-qda-v2-v2-3-69a02e9090d4@oss.qualcomm.com> <81708487-89ce-4cd5-b39a-2989bdce6088@kernel.org> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <81708487-89ce-4cd5-b39a-2989bdce6088@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDEwMyBTYWx0ZWRfX2L5uySbTjANY ikqfVJ0kGNJaLoaCRZHlbS7uAx4sCIKbbFb08fg2L01Y/eT8z8hVzICQvDt4H8lQ3XCEtyb+wpU X9nlASiZcyBz8ehxyVtJTpGjkrmxDS3qsAHIUe8xLpaaRAzWwSaWUg34wwQsgzLno3NMyztdpcd WtMaAgFCmr3Y+rav8LJDmL6m9dD6dlfT6ZsYLRjPOyIn2yjE3fVEW5MmoA8F/2wMQpoNcZBG/5g 71brPlv2tG8EsJSUjYF8vYFePl8gaOu8hqOp0ZhTcEjmq+6OqjOfa/Bvp4Ay7+ZeQQqDIFkFUwM 54yyP+6aAx/lIW3bAziZi4JD32fAZFfrwmsCdkWKqAddTsC+8VgMKbItn9bV6WhYgMYIxV0rBOX Hcm7cXdh75NtHkQcr+/b14BigxqHppRZjB2TVvhqSLbTSDFAOVeZNirX4y0s15S5gjVjBWKCkMm 2O4WtXmBu52T4J6EysQ== X-Proofpoint-GUID: 81J0mGMot8910S26nRM3Ye-w-vrPefTv X-Proofpoint-ORIG-GUID: 81J0mGMot8910S26nRM3Ye-w-vrPefTv X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDEwMyBTYWx0ZWRfX87HqXWuB9t3d o36FYRgS2mhcvG6bDQ1Eu1q1uDZwN/yiCucbhS7+RBO4lAnAnnQ2d7NLdS7ivnDBNdqeQ8Krhti C539/e1V67FHPF0n4PtkJTMYoFOTRG4= X-Authority-Analysis: v=2.4 cv=Sb7HsPRu c=1 sm=1 tr=0 ts=6a85ad04 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=D19gQVrFAAAA:8 a=EUspDBNiAAAA:8 a=fiCeWNywFvmbcpy1l9YA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=W4TVW4IDbPiebHqcZpNg:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190103 On 19-08-2026 00:40, Krzysztof Kozlowski wrote: > On 17/08/2026 06:47, Ekansh Gupta wrote: >> Add the skeleton of the Qualcomm DSP Accelerator (QDA) driver, a DRM >> accel driver for the Hexagon DSPs found on Qualcomm SoCs. >> >> This patch registers a DRM accel device, exposing a /dev/accel/accelN >> character device node, and binds it to the RPMsg channel used to reach >> the DSP. Buffer management, IOMMU context banks and the FastRPC >> protocol are added by later patches in this series. >> >> qda_drv.c / qda_drv.h define the drm_driver ops table, the per-file >> private state (qda_file_priv) and the main device structure (qda_dev), >> which embeds drm_device so that it can be recovered with container_of(). >> >> qda_rpmsg.c binds to the "qcom,fastrpc" compatible via >> module_rpmsg_driver(), reads the DSP domain name from the "label" >> device-tree property, and registers the DRM device. >> >> Assisted-by: Claude:claude-sonnet-5 >> Signed-off-by: Ekansh Gupta >> --- >> Changes in v2: >> - Use module_rpmsg_driver() and drop the qda_rpmsg_register()/ >> _unregister() wrappers, module_init()/module_exit() and >> qda_rpmsg.h entirely (Dmitry Baryshkov) >> - Read the "label" property directly into qdev->dsp_name (Dmitry Baryshkov) >> - Drop the probe/remove/init log messages (Dmitry Baryshkov) >> - Return the result of qda_register_device() directly (Dmitry Baryshkov) >> - Clarify the Kconfig help text (Dmitry Baryshkov) >> --- >> drivers/accel/Kconfig | 1 + >> drivers/accel/Makefile | 1 + >> drivers/accel/qda/Kconfig | 30 ++++++++++++++++ >> drivers/accel/qda/Makefile | 10 ++++++ >> drivers/accel/qda/qda_drv.c | 71 ++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_drv.h | 61 +++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_rpmsg.c | 79 +++++++++++++++++++++++++++++++++++++++++++ >> 7 files changed, 253 insertions(+) >> >> diff --git a/drivers/accel/Kconfig b/drivers/accel/Kconfig >> index bdf48ccafcf2..74ac0f71bc9d 100644 >> --- a/drivers/accel/Kconfig >> +++ b/drivers/accel/Kconfig >> @@ -29,6 +29,7 @@ source "drivers/accel/ethosu/Kconfig" >> source "drivers/accel/habanalabs/Kconfig" >> source "drivers/accel/ivpu/Kconfig" >> source "drivers/accel/qaic/Kconfig" >> +source "drivers/accel/qda/Kconfig" >> source "drivers/accel/rocket/Kconfig" >> >> endif >> diff --git a/drivers/accel/Makefile b/drivers/accel/Makefile >> index 1d3a7251b950..58c08dd5f389 100644 >> --- a/drivers/accel/Makefile >> +++ b/drivers/accel/Makefile >> @@ -5,4 +5,5 @@ obj-$(CONFIG_DRM_ACCEL_ARM_ETHOSU) += ethosu/ >> obj-$(CONFIG_DRM_ACCEL_HABANALABS) += habanalabs/ >> obj-$(CONFIG_DRM_ACCEL_IVPU) += ivpu/ >> obj-$(CONFIG_DRM_ACCEL_QAIC) += qaic/ >> +obj-$(CONFIG_DRM_ACCEL_QDA) += qda/ >> obj-$(CONFIG_DRM_ACCEL_ROCKET) += rocket/ >> \ No newline at end of file > > You have trivial patch errors. newline problem was already there, wasn't introduced as part of this patch series, so I wasn't sure to fix it here. I can fix this in v3.> > ... > >> +} >> + >> +static const struct of_device_id qda_rpmsg_id_table[] = { >> + { .compatible = "qcom,fastrpc" }, >> + {}, > > Device node with this compatible is already populated, so this looks > simply wrong or you are adding a duplicated driver. > > That's a no-go, you are supposed to work with existing drivers and grow > them. I'll bring the discussion again here, there was a discussion to move the driver to accel subsystem if we want to support new features/uAPI changes. Please read [1],[2] threads. The intention is to replace fastrpc driver with QDA eventually. Do you suggest adding a different compatible, say "qcom,qda" for this driver? Let me know if you have a better suggestion to proceed here. [1] https://lkml.org/lkml/2024/6/24/479 [2] https://lkml.org/lkml/2024/6/21/1252> > > Best regards, > Krzysztof